From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E22C2D0C0 for ; Sat, 21 Dec 2019 12:04:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C0C72070C for ; Sat, 21 Dec 2019 12:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BzoXBwAP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C0C72070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iidUr-0006us-IM for qemu-devel@archiver.kernel.org; Sat, 21 Dec 2019 07:04:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iidUA-0006Oc-0h for qemu-devel@nongnu.org; Sat, 21 Dec 2019 07:03:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iidU8-0003h1-Ci for qemu-devel@nongnu.org; Sat, 21 Dec 2019 07:03:53 -0500 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:40017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iidU7-0003b0-Vh; Sat, 21 Dec 2019 07:03:52 -0500 Received: by mail-ot1-x343.google.com with SMTP id w21so7754740otj.7; Sat, 21 Dec 2019 04:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uM60FLfWItZ2H12vNMdK31k4/HMlT2W6hNndX4nQuXk=; b=BzoXBwAPISbLKvvV4csf2S3K7e0+4LxqJzrkkIoyU5E8oheOxg/3qRZ+jPT0JJyu5C UZeaIPHUjrxVKagcy1IZFfxmzR8i4S3IGjlCfYzu7bwbg0pbR7d1gGGa87Niva64o91B PTfq1M9TyFqGqJcOmelh0+z5ISI2utlbcLBzxxKOtsJPt0Fs6rwrzCBMOZotUCsU8x1Q XvBESybfVXa03XJ4Uj30rLs6EKipyOBuSfudSKoXMup+2EJ8H70BygoEHauakPMY8rgl oll2Qwq/Ibon9U9YjmTcTbIMOm26t6GRMvos/T+lKcnIs1dGmjyyMMX4utJxh1DtZmfo Vtbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uM60FLfWItZ2H12vNMdK31k4/HMlT2W6hNndX4nQuXk=; b=QvbsJePkcSlQmXgrX1VZOfiWRfDFTectd1KqwTCbQjsdSwbymzdJpnxqr/OEgSUQjV +4uOGKj0oQYV2VcwUBXerELQPs5h7b5oXiQ5QQ3aJS98OtjMlARWDhj0YPzF7nQEqv2u 0uyk1n+Q7ldvv92lNuBljMNgw4fdc8yDOuqM+KI8H7j5kGQuSA67hzS5pMMqot8ED79d DwnTDM6BQWHpzQGATBm4x9MnGug9wjtbIyigA6cjfKS3QlX0zFMF+5G4H72DL62tQLf4 P1eDHWYm0dMu3kVzaMSSjwn+2hvxH20+42zVjcob8nj26R7VDAU3knGX6NuSrsOnLJuT zGag== X-Gm-Message-State: APjAAAX8UWKTwBFQGYw9gDYQhBSO57Y6MjuqhDkEJCK0RjIKqwpiDDnU 7WBi39t6ZCDQCUz8bV59g5cwoRd1E9j+gfhdamjirA== X-Google-Smtp-Source: APXvYqyWaeCSKptsu57fjknHip1e17+ldo7wCpLN4Sdyl21ZexP5Cx50epyci40Ku1LF/Rckz8SLWTdjbtXDTyjgbS4= X-Received: by 2002:a9d:7305:: with SMTP id e5mr19717277otk.64.1576929830544; Sat, 21 Dec 2019 04:03:50 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a9d:d21:0:0:0:0:0 with HTTP; Sat, 21 Dec 2019 04:03:49 -0800 (PST) In-Reply-To: References: <067319c3-b426-bb83-56da-6612180d35c5@vivier.eu> From: Aleksandar Markovic Date: Sat, 21 Dec 2019 13:03:49 +0100 Message-ID: Subject: Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation To: Finn Thain Content-Type: multipart/alternative; boundary="00000000000062a8f3059a359640" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::343 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Jason Wang , Laurent Vivier , "qemu-stable@nongnu.org" , Herve Poussineau , Aleksandar Rikalo Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000062a8f3059a359640 Content-Type: text/plain; charset="UTF-8" On Saturday, December 21, 2019, Finn Thain wrote: > On Fri, 20 Dec 2019, Laurent Vivier wrote: > > > Le 20/12/2019 ? 12:38, Aleksandar Markovic a ?crit?: > > > On Sat, Dec 14, 2019 at 2:29 AM Finn Thain > wrote: > > >> > > >> Hi All, > > >> > > >> There is a bug in the DP8393X emulation that can stop packet > reception. > > >> > > >> Whilst debugging that issue I found that the receiver algorithm > differs > > >> from the one described in the National Semiconductor datasheet. > > >> > > > > > > Finn, could you please provide the link to the exact datasheet that > > > you used for reference, so that we are on the same page while looking > > > at your code? > > > > According to his comments ,"National Semiconductor DP83932C" and > > sections seem to be the same, I think the datasheet is: > > > > https://www.eit.lth.se/fileadmin/eit/courses/datablad/Periphery/ > Communication/DP83932C.pdf > > > > Yes. I know of 3 datasheets from National Semiconductor, > > 11719 DP83934CVUL-20/25 MHz SONIC-T Systems-Oriented Network Interface > Controller with Twisted Pair Interface > 10492 DP83932C-20/25/33 MHz SONIC Systems-Oriented Network Interface > Controller > 11722 DP83916 SONIC-16 Systems-Oriented Network Interface Controller > > The publication numbered 10492 is the one that Laurent linked to. It and > 11722 both have the same table of contents. The references I gave in the > patch descriptions are applicable to these. (Having said that, I see now > that I did mess up one reference. I'll fix it.) > > The "1995 National Ethernet Databook" on bitsavers has more information. > https://mirrorservice.org/sites/www.bitsavers.org/components/national/_ > dataBooks/1995_National_Ethernet_Databook.pdf > > -- Finn, I truly appreciate your detailed response. Aleksandar > > Thanks, > > Laurent > > > --00000000000062a8f3059a359640 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Saturday, December 21, 2019, Finn Thain <fthain@telegraphics.com.au> wrote:
On Fri, 20 Dec 2019, Laurent Vivier wrote:

> Le 20/12/2019 ? 12:38, Aleksandar Markovic a ?crit?:
> > On Sat, Dec 14, 2019 at 2:29 AM Finn Thain <fthain@telegraphics.com.au> wrote:
> >>
> >> Hi All,
> >>
> >> There is a bug in the DP8393X emulation that can stop packet = reception.
> >>
> >> Whilst debugging that issue I found that the receiver algorit= hm differs
> >> from the one described in the National Semiconductor datashee= t.
> >>
> >
> > Finn, could you please provide the link to the exact datasheet th= at
> > you used for reference, so that we are on the same page while loo= king
> > at your code?
>
> According to his comments ,"National Semiconductor DP83932C"= and
> sections seem to be the same, I think the datasheet is:
>
> https://www.eit.lth.se/<= wbr>fileadmin/eit/courses/datablad/Periphery/Communication/DP8393= 2C.pdf
>

Yes. I know of 3 datasheets from National Semiconductor,

11719=C2=A0 DP83934CVUL-20/25 MHz SONIC-T Systems-Oriented Network Interfac= e
Controller with Twisted Pair Interface
10492=C2=A0 DP83932C-20/25/33 MHz SONIC Systems-Oriented Network Interface =
Controller
11722=C2=A0 DP83916 SONIC-16 Systems-Oriented Network Interface Controller<= br>
The publication numbered 10492 is the one that Laurent linked to. It and 11722 both have the same table of contents. The references I gave in the patch descriptions are applicable to these. (Having said that, I see now that I did mess up one reference. I'll fix it.)

The "1995 National Ethernet Databook" on bitsavers has more infor= mation.
htt= ps://mirrorservice.org/sites/www.bitsavers.org/components/nationa= l/_dataBooks/1995_National_Ethernet_Databook.pdf

--=C2=A0

Finn,

I t= ruly appreciate your detailed response.

Aleksandar=


> Thanks,
> Laurent
>
--00000000000062a8f3059a359640--