From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Aleksandar Markovic <amarkovic@wavecomp.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
Richard Henderson <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()
Date: Wed, 26 Feb 2020 12:53:39 +0100 [thread overview]
Message-ID: <CAL1e-=jGuEy7kJ4eidi8jG8uEGaESqCH10DV4_Hq3KoHzffuJg@mail.gmail.com> (raw)
In-Reply-To: <20200221162011.26383-1-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Friday, February 21, 2020, Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> Since commit d8ed887bdc, the cpu_mips_irq_request handler takes
> a pointer to MIPSCPU in its opaque argument. Directly pass the
> cpu pointer.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Applied to the next MIPS queue.
> hw/mips/mips_int.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index 863ed45659..796730b11d 100644
> --- a/hw/mips/mips_int.c
> +++ b/hw/mips/mips_int.c
> @@ -77,7 +77,7 @@ void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
> qemu_irq *qi;
> int i;
>
> - qi = qemu_allocate_irqs(cpu_mips_irq_request, env_archcpu(env), 8);
> + qi = qemu_allocate_irqs(cpu_mips_irq_request, cpu, 8);
> for (i = 0; i < 8; i++) {
> env->irq[i] = qi[i];
> }
> --
> 2.21.1
>
>
>
[-- Attachment #2: Type: text/html, Size: 1511 bytes --]
prev parent reply other threads:[~2020-02-26 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:20 [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu() Philippe Mathieu-Daudé
2020-02-26 11:53 ` Aleksandar Markovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1e-=jGuEy7kJ4eidi8jG8uEGaESqCH10DV4_Hq3KoHzffuJg@mail.gmail.com' \
--to=aleksandar.m.mail@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).