From: Brian Steffens <briansteffens@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field
Date: Tue, 5 Sep 2017 11:10:55 -0400 [thread overview]
Message-ID: <CALGxsMdOM_pv-uqMoC0MSVo0ai1vm_nHdZ5U8BNt+YNMXQEpkA@mail.gmail.com> (raw)
In-Reply-To: <20170905095610.GF17449@stefanha-x1.localdomain>
Thanks for taking a look at the patch and fixing the missing CC
addresses!
> Have you considered extending the 'migrate' command with a list of
> drives instead?
That was my original plan but I thought having information on whether a
device is shared or not could potentially be useful to other systems. If
not then you're right, it would be a lighter touch to add it only to the
'migrate' command.
> In case you haven't seen it, the preferred approach for non-shared
> storage migration is drive-mirror + NBD. The block/migration.c code is
> an older feature that is less flexible. More info on drive-mirror +
> NBD:
I didn't realize drive-mirror + NBD was the preferred approach. Are
there any plans to drop support for the block/migration.c style?
next prev parent reply other threads:[~2017-09-05 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 20:10 [Qemu-devel] [PATCH 1/1] block: add block device shared field Brian Steffens
2017-09-01 20:21 ` Eric Blake
2017-09-05 9:56 ` Stefan Hajnoczi
2017-09-05 15:10 ` Brian Steffens [this message]
2017-09-06 14:16 ` Stefan Hajnoczi
2017-09-06 5:58 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALGxsMdOM_pv-uqMoC0MSVo0ai1vm_nHdZ5U8BNt+YNMXQEpkA@mail.gmail.com \
--to=briansteffens@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).