From: sundeep subbaraya <sundeep.lkml@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair23@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-arm] [Qemu-devel PATCH 1/5] msf2: Add Smartfusion2 System timer
Date: Tue, 16 May 2017 12:11:41 +0530 [thread overview]
Message-ID: <CALHRZurDU8fS3GSKproqP83Un2mVnJ75ptydf4QsRZvyzsZz1Q@mail.gmail.com> (raw)
In-Reply-To: <d82b2e7c-e983-b227-b300-ceea0bd8b2cb@amsat.org>
Hi Philippe,
On Mon, May 15, 2017 at 5:22 PM, Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> Hi Subbaraya,
>
> + if (value & TIMER_MODE) {
>>> + qemu_log_mask(LOG_UNIMP, "64-bit mode not supported\n");
>>>
>>
>> No need of trailing '\n', be more specific, something like:
>>
>> qemu_log_mask(LOG_UNIMP, TYPE_MSF2_TIMER ": 64-bit mode not
>> supported");
>>
>
> I mistaken with error_report(), qemu_log_mask() does use trailing newline,
> sorry!
>
thats ok :)
Thanks,
Sundeep
>
> Phil.
>
next prev parent reply other threads:[~2017-05-16 6:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 16:44 [Qemu-devel] [Qemu-devel PATCH 0/5] Add support for Smartfusion2 SoC Subbaraya Sundeep
2017-05-09 16:44 ` [Qemu-devel] [Qemu-devel PATCH 1/5] msf2: Add Smartfusion2 System timer Subbaraya Sundeep
2017-05-10 9:41 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-05-10 12:37 ` sundeep subbaraya
2017-05-12 4:38 ` Philippe Mathieu-Daudé
2017-05-12 5:16 ` sundeep subbaraya
2017-05-15 11:52 ` Philippe Mathieu-Daudé
2017-05-16 6:41 ` sundeep subbaraya [this message]
2017-05-09 16:44 ` [Qemu-devel] [Qemu-devel PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block Subbaraya Sundeep
2017-05-10 10:34 ` Philippe Mathieu-Daudé
2017-05-12 3:48 ` sundeep subbaraya
2017-05-12 4:12 ` Philippe Mathieu-Daudé
2017-05-09 16:44 ` [Qemu-devel] [Qemu-devel PATCH 3/5] msf2: Add Smartfusion2 SPI controller Subbaraya Sundeep
2017-05-10 12:12 ` Philippe Mathieu-Daudé
2017-05-12 3:31 ` sundeep subbaraya
2017-05-12 3:54 ` Philippe Mathieu-Daudé
2017-05-09 16:44 ` [Qemu-devel] [Qemu-devel PATCH 4/5] msf2: Add Smartfusion2 SoC Subbaraya Sundeep
2017-05-10 11:50 ` Philippe Mathieu-Daudé
2017-05-12 3:17 ` sundeep subbaraya
2017-05-12 5:02 ` Philippe Mathieu-Daudé
2017-05-15 16:54 ` Alistair Francis
2017-05-16 6:40 ` sundeep subbaraya
2017-05-09 16:44 ` [Qemu-devel] [Qemu-devel PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit Subbaraya Sundeep
2017-05-10 11:16 ` Philippe Mathieu-Daudé
2017-05-10 9:44 ` [Qemu-devel] [Qemu-arm] [Qemu-devel PATCH 0/5] Add support for Smartfusion2 SoC Philippe Mathieu-Daudé
2017-05-10 15:24 ` sundeep subbaraya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALHRZurDU8fS3GSKproqP83Un2mVnJ75ptydf4QsRZvyzsZz1Q@mail.gmail.com \
--to=sundeep.lkml@gmail.com \
--cc=alistair23@gmail.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).