From: Xin Tong <xerox.time.tech@gmail.com>
To: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] passing translated address out in QEMU
Date: Thu, 23 Aug 2012 21:29:09 -0700 [thread overview]
Message-ID: <CALKntY2047ghSNd2Nc0fiVsg6s8YM2gOFfWHVCNMyAdpyJ0S-g@mail.gmail.com> (raw)
In-Reply-To: <20120824040645.GA62833@cs.nctu.edu.tw>
On Thu, Aug 23, 2012 at 9:06 PM, 陳韋任 (Wei-Ren Chen)
<chenwj@iis.sinica.edu.tw> wrote:
>> That might be difficult. what i did was that i disabled inlined
>> translated and push the virt/phys address into 2 new fields in the cpu
>> structure in the call out lookup. because in the callout lookup we
>> have a handle to the cpu env.
>
> What you mean by "disabled inlined translated"? You mean apply Max's
> patch so that all guest memory access go through the slow path without
> looking software tlb? Since you said you're running arm on x86 host,
> I guess what you did might be,
>
> int cpu_arm_handle_mmu_fault (CPUARMState *env, target_ulong address,
> int access_type, int mmu_idx)
> {
> ...
>
> ret = get_phys_addr(env, address, access_type, is_user, &phys_addr, &prot,
> &page_size);
>
> // store phys_addr into env->cpu_last_paddr
>
> ...
> }
>
>> not too sure how much impact inlined lookup has on the performance.
>> since i disabled it, next step i would just get rid of that piece of
>> generated assembly, as it is no good for icache ( generated for every
>> memory operation).
>
> You can run a benchmark inside your guest. I guess if you run a
> long-running benchmark, you can see performance degradation. If software
> tlb hit, you can get the value of guest memory in the code cache
> with a few host instructions. Disabling software tlb lookup, every guest
> memory access will call a helper function which takes a lot of time.
> What you mean by "get rid of that piece of generated assembly"?
every inlined TLB lookup has ~10 instructions .
Xin
>
> Regards,
> chenwj
>
> --
> Wei-Ren Chen (陳韋任)
> Computer Systems Lab, Institute of Information Science,
> Academia Sinica, Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> Homepage: http://people.cs.nctu.edu.tw/~chenwj
next prev parent reply other threads:[~2012-08-24 4:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 17:17 [Qemu-devel] passing translated address out in QEMU Xin Tong
2012-08-23 3:14 ` 陳韋任 (Wei-Ren Chen)
2012-08-23 4:38 ` Xin Tong
2012-08-23 10:06 ` 陳韋任 (Wei-Ren Chen)
2012-08-23 10:11 ` 陳韋任 (Wei-Ren Chen)
2012-08-23 15:34 ` Xin Tong
2012-08-23 15:52 ` Peter Maydell
2012-08-23 16:18 ` Xin Tong
2012-08-23 21:55 ` Steven
2012-08-24 2:57 ` 陳韋任 (Wei-Ren Chen)
2012-08-24 3:24 ` Xin Tong
2012-08-24 4:06 ` 陳韋任 (Wei-Ren Chen)
2012-08-24 4:29 ` Xin Tong [this message]
2012-08-24 8:15 ` 陳韋任 (Wei-Ren Chen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALKntY2047ghSNd2Nc0fiVsg6s8YM2gOFfWHVCNMyAdpyJ0S-g@mail.gmail.com \
--to=xerox.time.tech@gmail.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).