From: Yee Li <seven.yi.lee@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, pbonzini@redhat.com,
richard.henderson@linaro.org, eduardo@habkost.net,
qemu-devel@nongnu.org
Subject: Re: [PATCH] intel-iommu: fix Read DMAR IQA REG DW
Date: Tue, 23 Jul 2024 10:40:14 +0800 [thread overview]
Message-ID: <CALX8JfRTecBexP8bV8LW2yGuj-hfWuYYz97FzTKdrL43GF3+Ew@mail.gmail.com> (raw)
In-Reply-To: <20240720142902-mutt-send-email-mst@kernel.org>
> > When dmar_readq or devmem2 read the DW of IQA always 0UL because
> > "& VTD_IQA_QS". So, try to fix it.
> >
> > case:
> > after vtd_mem_write
> > IQA val: 0x100206801
> >
> > after vtd_mem_read
> > IQA val: 0x100206001
> >
> > Signed-off-by: yeeli <seven.yi.lee@gmail.com>
>
>
> how was this tested?
If VT-D hardware supports scalable mode, Linux will set the IQA DW (bit 11).
In qemu, the vtd_mem_write and vtd_update_iq_dw set DW well, however,
vtd_mem_read the DW wrong because "& VTD_IQA_QS" dropped the value
of DW (bit 11).
So testing the patch is easy,
config the "x-scalable-mode" option as below:
"-device intel-iommu,caching-mode=on,x-scalable-mode=on,aw-bits=48"
after Linux OS boot, check the IQA_REG DW (bit 11) as below:
IOMMU_DEBUGFS:
"cat /sys/kernel/debug/iommu/intel |grep IQA"
"IQA 0x90 0x00000001001da801"
or devmem2 read the reg:
"devmem2 0xfed90090"
"/dev/mem opened."
"Memory mapped at address 0x7f983014f000."
"Value at address 0xFED90090 (0x7f983014f000): 0x0"
next prev parent reply other threads:[~2024-07-23 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 3:53 [PATCH] intel-iommu: fix Read DMAR IQA REG DW YeeLi
2024-07-04 6:54 ` Yee Li
2024-07-20 18:28 ` Michael S. Tsirkin
2024-07-20 18:29 ` Michael S. Tsirkin
2024-07-23 2:40 ` Yee Li [this message]
2024-07-23 3:02 ` Yee Li
2024-07-23 8:05 ` Yi Liu
2024-07-24 6:34 ` Yee Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALX8JfRTecBexP8bV8LW2yGuj-hfWuYYz97FzTKdrL43GF3+Ew@mail.gmail.com \
--to=seven.yi.lee@gmail.com \
--cc=eduardo@habkost.net \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).