From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <robherring2@gmail.com>) id 1WhgpD-0005YM-6W
	for qemu-devel@nongnu.org; Tue, 06 May 2014 10:58:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <robherring2@gmail.com>) id 1WhgpC-0005De-1H
	for qemu-devel@nongnu.org; Tue, 06 May 2014 10:58:31 -0400
Received: from mail-vc0-x235.google.com ([2607:f8b0:400c:c03::235]:44840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <robherring2@gmail.com>) id 1WhgpB-0005DS-TW
	for qemu-devel@nongnu.org; Tue, 06 May 2014 10:58:29 -0400
Received: by mail-vc0-f181.google.com with SMTP id hy4so1091522vcb.26
	for <qemu-devel@nongnu.org>; Tue, 06 May 2014 07:58:29 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAAHg+HjhLAKyH=qts8gsgmDsk+G1L6t+WYALvFvfhrAKwwH+Hw@mail.gmail.com>
References: <1399280234-25036-1-git-send-email-pranavkumar@linaro.org>
	<1399280234-25036-5-git-send-email-pranavkumar@linaro.org>
	<CAL_JsqLwV01OiBou4N-76SSAwfNAVfEnWitB0+H1akdu-s+CdA@mail.gmail.com>
	<CAL_Jsq+Bu6vjcJ93OPSCikMjnrD+9AYN9taGPeRcdciVRHwK2g@mail.gmail.com>
	<CAFEAcA_pmzquh1MX5R7qU0t64hMZ_2Kpah8UkjmwsTV3XpncnQ@mail.gmail.com>
	<CAAHg+HjhLAKyH=qts8gsgmDsk+G1L6t+WYALvFvfhrAKwwH+Hw@mail.gmail.com>
Date: Tue, 6 May 2014 09:58:28 -0500
Message-ID: <CAL_Jsq+3Vq9U2bb7r-5e60BmQRLMD0FYepAFeMhvSWZWbcV9eA@mail.gmail.com>
From: Rob Herring <robherring2@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2
 compatible when kernel supports it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anup Patel <anup.patel@linaro.org>, "patches@apm.com" <patches@apm.com>, QEMU Developers <qemu-devel@nongnu.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On Tue, May 6, 2014 at 12:24 AM, Pranavkumar Sawargaonkar
<pranavkumar@linaro.org> wrote:
> Hi Rob, Peter,
>
> On 5 May 2014 20:13, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 5 May 2014 15:09, Rob Herring <robherring2@gmail.com> wrote:
>>> On Mon, May 5, 2014 at 9:06 AM, Rob Herring <robherring2@gmail.com> wro=
te:
>>>> This does not compile for me:
>>>>
>>>>   CC    aarch64-softmmu/hw/arm/virt.o
>>>> hw/arm/virt.c: In function =E2=80=98create_fdt=E2=80=99:
>>>> hw/arm/virt.c:186:44: error: =E2=80=98KVM_CAP_ARM_PSCI_0_2=E2=80=99 un=
declared (first
>>>> use in this function)
>>>>          if (kvm_check_extension(kvm_state, KVM_CAP_ARM_PSCI_0_2)) {
>>>>                                             ^
>>>
>>> Note that I am building for system emulation, not KVM which may
>>> explain the difference (I assume it actually builds for you).
>>
> Yes actually it builds for me since i am building KVM.
>
>> Yes, you can't use the kernel header constants here, you need
>> to use the QEMU_ variants that kvm-consts.h provides.
>
> Sure I will do use QEMU_ variants in next patch so that it builds for
> non KVM case also.

We created the psci.h header to be a common header to define the ABI.
It has no linux dependency other than that is the master copy ATM. Can
we just copy the header to a non-Linux location rather than creating
duplicate QEMU_ prefixed defines?

Rob