From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <robherring2@gmail.com>) id 1WhJZw-00016N-SE
	for qemu-devel@nongnu.org; Mon, 05 May 2014 10:09:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <robherring2@gmail.com>) id 1WhJZv-0002Qf-Sk
	for qemu-devel@nongnu.org; Mon, 05 May 2014 10:09:12 -0400
Received: from mail-ve0-x236.google.com ([2607:f8b0:400c:c01::236]:33047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <robherring2@gmail.com>) id 1WhJZv-0002Qb-OU
	for qemu-devel@nongnu.org; Mon, 05 May 2014 10:09:11 -0400
Received: by mail-ve0-f182.google.com with SMTP id sa20so2524575veb.13
	for <qemu-devel@nongnu.org>; Mon, 05 May 2014 07:09:11 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAL_JsqLwV01OiBou4N-76SSAwfNAVfEnWitB0+H1akdu-s+CdA@mail.gmail.com>
References: <1399280234-25036-1-git-send-email-pranavkumar@linaro.org>
	<1399280234-25036-5-git-send-email-pranavkumar@linaro.org>
	<CAL_JsqLwV01OiBou4N-76SSAwfNAVfEnWitB0+H1akdu-s+CdA@mail.gmail.com>
Date: Mon, 5 May 2014 09:09:11 -0500
Message-ID: <CAL_Jsq+Bu6vjcJ93OPSCikMjnrD+9AYN9taGPeRcdciVRHwK2g@mail.gmail.com>
From: Rob Herring <robherring2@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2
 compatible when kernel supports it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anup Patel <anup.patel@linaro.org>, "patches@apm.com" <patches@apm.com>, QEMU Developers <qemu-devel@nongnu.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On Mon, May 5, 2014 at 9:06 AM, Rob Herring <robherring2@gmail.com> wrote:
> On Mon, May 5, 2014 at 3:57 AM, Pranavkumar Sawargaonkar
> <pranavkumar@linaro.org> wrote:
>> If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then
>> we enable PSCI v0.2 for each VCPU at the time of VCPU init hence we
>> need to provide PSCI v0.2 compatible string via generated DTB.
>>
>> This patch updates generated DTB to have PSCI v0.2 compatible string
>> when we have in-kernel emulation PSCI v0.2 for KVM ARM/ARM64.
>>
>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
>> Signed-off-by: Anup Patel <anup.patel@linaro.org>
>> ---
>>  hw/arm/virt.c |   16 ++++++++++------
>>  1 file changed, 10 insertions(+), 6 deletions(-)
>
> This does not compile for me:
>
>   CC    aarch64-softmmu/hw/arm/virt.o
> hw/arm/virt.c: In function =E2=80=98create_fdt=E2=80=99:
> hw/arm/virt.c:186:44: error: =E2=80=98KVM_CAP_ARM_PSCI_0_2=E2=80=99 undec=
lared (first
> use in this function)
>          if (kvm_check_extension(kvm_state, KVM_CAP_ARM_PSCI_0_2)) {
>                                             ^

Note that I am building for system emulation, not KVM which may
explain the difference (I assume it actually builds for you).

Rob