From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A9DC47087 for ; Fri, 28 May 2021 19:42:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BCB561358 for ; Fri, 28 May 2021 19:42:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BCB561358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmiNd-0001S4-7j for qemu-devel@archiver.kernel.org; Fri, 28 May 2021 15:42:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmiMi-0008Qg-AZ; Fri, 28 May 2021 15:41:52 -0400 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]:35469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmiMg-0004XM-FW; Fri, 28 May 2021 15:41:52 -0400 Received: by mail-oi1-x236.google.com with SMTP id v22so5348457oic.2; Fri, 28 May 2021 12:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3b/5hZoUJnGGXW2KW5LT7/3XSDYmASHQYpEKst3achE=; b=spzRWMOFz+UiIQApbd5NLLF6F7WYevJuGPDz5O41WKqrk4oC8VtG+v9mrqb+zgGpBK Yszqc7vPC3so7DmS1cA7MQjZD1arZQvpH3MQvWsMxz2vdtAvPJ+BM4IGaI351KHD3dP5 yi79DB/9KjlJ7EtHocjd4Ktl5yr8rTg72T7/uOk1DOac8E6rjMilb0gaLHmAwFoQ4n1V REL+oHSXtPXOv/l0eOpNbyPZ3IdDnuVxrQDv5XX5Ii5WDpqhP0/xB6W8A0aXJyJ+Mnz0 vHsPaDxMPmwNm73E9IZFZ0eHePdsQuZ64opKe2WxF9aT9ytkvY1DF9b3BkLCGDDXrNg9 6xzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3b/5hZoUJnGGXW2KW5LT7/3XSDYmASHQYpEKst3achE=; b=m7TlgU1qJQeGk26LyKPFPqdv5KwBN64Y5hMsdVVyR9kh6bNWTV7rmecBRreUoZSNhT GD+0O76wX8R+zxwWtyGBvpCxE2tK5GULoIL0S8FsmtyOoF0va9Dt28PaoyKjWpt0A6wR ZsCxLek3k5upBWJfm0NmkNQ2NGZ0LkT4E6I7x1huLZTtvYEe8fxy3UAZewCjANLE7vwO y68FXQjl3yo5Bf6uRUXqdzl2QXCa/19rf1wxxPtQO8dkgztsHcIIPVCEuR2V1Ksvhnyw qi7crT8IEgCLpoREL9qrzXyYYfO9lwrB/12uuKVnPYKYZ0D+gemo/2tsHG89o1c/4NRD f6Tw== X-Gm-Message-State: AOAM530nxAsSwLtXHET2tpf1lTRItQwoT6BmWoNkMnB2JE9IOJ0MWrC/ kTyF2txoVun1us1tFZZdTq+/tvwWT3R1jA1LTsY= X-Google-Smtp-Source: ABdhPJwDupQxXhznQqnnc1SLRoqVEGDzttT4r7hTDgl5I/IqLT6tSn+GdwAVup2obdwMyvE6kniKUz+SpBcoWKFGml8= X-Received: by 2002:aca:c384:: with SMTP id t126mr10283471oif.69.1622230908409; Fri, 28 May 2021 12:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20210525025823.3208218-1-swethajoshi139@gmail.com> <331a819e-1745-4d4b-cc4a-82521a58186a@linaro.org> In-Reply-To: From: Swetha Joshi Date: Fri, 28 May 2021 12:41:33 -0700 Message-ID: Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled To: Dongjiu Geng Content-Type: multipart/alternative; boundary="0000000000000a198c05c36911ae" Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=swethajoshi139@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Peter Maydell , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000000a198c05c36911ae Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I apologize for the delay, here are the repro steps: 1. Remove CONFIG_ARM_VIRT=3Dy from arm-softmmu.mak 2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, in all the places where we disable kvm using -disable-kvm, replace this with -enable-kvm 3. Build You should see errors pointing to these routines: virt_is_acpi_enabled, acpi_ghes_record_errors Thanks, Swetha. On Fri, May 28, 2021 at 12:08 AM Dongjiu Geng wrote: > Peter Maydell =E4=BA=8E2021=E5=B9=B45=E6=9C=88= 27=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8A=E5=8D=882:19=E5=86=99=E9=81=93=EF= =BC=9A > > > > On Wed, 26 May 2021 at 18:32, Swetha Joshi > wrote: > > > > > > Hello, > > > > > > One of the qemu machines we use has KVM enabled, but we don't want th= e > CONFIG_ARM_VIRT enabled as it pulls in emulation of a variety of physical > hardware that we don't need. The compilation errors I mentioned are not i= n > the qemu mainline per say but we see them in one of the qemu derived > machines we use. > > > > Sure, but unless you can give me a recipe for reproducing the > > build failure in mainline I can't really help... > > Hi Swetha=EF=BC=8C > Yes, Can you give a method that how to reproduce the build > failure issues? Thanks > > > > > thanks > > -- PMM > --=20 Regards Swetha Joshi. --0000000000000a198c05c36911ae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I apologize for the delay, here are the repro steps:
1= . Remove=C2=A0CONFIG_ARM_VIRT=3Dy from arm-softmmu.mak
2. In .git= lab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, in all the pla= ces where we disable kvm using=C2=A0-disable-kvm, replace this with=C2=A0-e= nable-kvm
3. Build

You should see errors= pointing to these routines:=C2=A0v= irt_is_acpi_enabled, acpi_gh= es_record_errors
<= br>
Thanks,=
Swetha.

On F= ri, May 28, 2021 at 12:08 AM Dongjiu Geng <gengdongjiu1@gmail.com> wrote:
Peter Maydell <peter.maydell@linaro.org> = =E4=BA=8E2021=E5=B9=B45=E6=9C=8827=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8A=E5= =8D=882:19=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, 26 May 2021 at 18:32, Swetha Joshi <swethajoshi139@gmail.com> wro= te:
> >
> > Hello,
> >
> > One of the qemu machines we use has KVM enabled, but we don't= want the CONFIG_ARM_VIRT enabled as it pulls in emulation of a variety of = physical hardware that we don't need. The compilation errors I mentione= d are not in the qemu mainline per say but we see them in one of the qemu d= erived machines we use.
>
> Sure, but unless you can give me a recipe for reproducing the
> build failure in mainline I can't really help...

Hi Swetha=EF=BC=8C
=C2=A0 =C2=A0 =C2=A0Yes,=C2=A0 Can you give a method that how to reproduce = the build
failure issues? Thanks

>
> thanks
> -- PMM


--
Regards

Swet= ha Joshi.
--0000000000000a198c05c36911ae--