From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
To: Gan Qixin <ganqixin@huawei.com>
Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com,
"Michael S . Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, Qemu Developers <qemu-devel@nongnu.org>,
kuhn.chenqun@huawei.com
Subject: Re: [PATCH 02/13] virtio-pmem: put it into the 'storage' category
Date: Thu, 19 Nov 2020 15:12:46 +0100 [thread overview]
Message-ID: <CAM9Jb+hf=mcuN_fYYxMS4s-ha2A8Hkqpnjz=-oTtk7D9bcGVDQ@mail.gmail.com> (raw)
In-Reply-To: <20201115184903.1292715-3-ganqixin@huawei.com>
> The category of the virtio-pmem device is not set, put it into the 'storage'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio/virtio-pmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c
> index ddb0125901..98b3139cd0 100644
> --- a/hw/virtio/virtio-pmem.c
> +++ b/hw/virtio/virtio-pmem.c
> @@ -175,6 +175,7 @@ static void virtio_pmem_class_init(ObjectClass *klass, void *data)
>
> vpc->fill_device_info = virtio_pmem_fill_device_info;
> vpc->get_memory_region = virtio_pmem_get_memory_region;
> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
> }
>
> static TypeInfo virtio_pmem_info = {
Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
next prev parent reply other threads:[~2020-11-19 14:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:48 [PATCH 00/13] Categorize some uncategorized devices Gan Qixin
2020-11-15 18:48 ` [PATCH 01/13] pc-dimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 02/13] virtio-pmem: " Gan Qixin
2020-11-19 14:12 ` Pankaj Gupta [this message]
2020-12-04 7:24 ` Pankaj Gupta
2020-11-15 18:48 ` [PATCH 03/13] vmmouse: put it into the 'input' category Gan Qixin
2020-11-16 14:05 ` Philippe Mathieu-Daudé
2020-11-15 18:48 ` [PATCH 04/13] nvdimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 05/13] mc146818rtc: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 06/13] ipmi: put some ipmi devices into the correct category Gan Qixin
2020-11-15 18:48 ` [PATCH 07/13] tpm: put some tpm " Gan Qixin
2020-11-15 18:48 ` [PATCH 08/13] AMDVI-PCI: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 09/13] u2f-passthru: put it into the 'usb' category Gan Qixin
2020-11-16 14:04 ` Philippe Mathieu-Daudé
2020-11-17 6:58 ` Gerd Hoffmann
2020-11-17 13:40 ` ganqixin
2020-11-17 13:37 ` ganqixin
2020-12-04 13:50 ` Philippe Mathieu-Daudé
2020-12-07 8:05 ` ganqixin
2020-12-07 8:52 ` Thomas Huth
2020-11-15 18:49 ` [PATCH 10/13] tosa-ssp: put it into the 'misc' category Gan Qixin
2020-11-15 18:49 ` [PATCH 11/13] spitz: put some Spitz-family devices into the correct category Gan Qixin
2020-11-15 18:49 ` [PATCH 12/13] SPI flash devices: put them into the 'storage' category Gan Qixin
2020-11-16 13:59 ` Philippe Mathieu-Daudé
2020-11-16 16:19 ` Alistair Francis
2020-11-15 18:49 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category Gan Qixin
2020-11-16 13:25 ` Philippe Mathieu-Daudé
2020-11-16 13:31 ` Peter Maydell
2020-11-16 14:33 ` Thomas Huth
2020-11-16 14:30 ` Thomas Huth
2020-11-16 17:00 ` Markus Armbruster
2020-11-16 17:15 ` Peter Maydell
2020-11-17 5:41 ` Markus Armbruster
2020-11-17 11:08 ` Peter Maydell
2020-11-17 20:12 ` Thomas Huth
2020-11-18 8:41 ` Markus Armbruster
2020-11-18 8:50 ` Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category) Markus Armbruster
2020-11-18 9:08 ` Thomas Huth
2020-11-17 14:02 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category ganqixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9Jb+hf=mcuN_fYYxMS4s-ha2A8Hkqpnjz=-oTtk7D9bcGVDQ@mail.gmail.com' \
--to=pankaj.gupta.linux@gmail.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).