From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namhyung@gmail.com>) id 1bPr3N-0003T6-6X
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 08:56:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namhyung@gmail.com>) id 1bPr3K-0004SY-3l
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 08:56:43 -0400
Received: from mail-vk0-x244.google.com ([2607:f8b0:400c:c05::244]:32868)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namhyung@gmail.com>) id 1bPr3J-0004SP-Vx
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 08:56:42 -0400
Received: by mail-vk0-x244.google.com with SMTP id s189so4137910vkh.0
	for <qemu-devel@nongnu.org>; Wed, 20 Jul 2016 05:56:39 -0700 (PDT)
MIME-Version: 1.0
Sender: namhyung@gmail.com
In-Reply-To: <20160719134303.GA20047@danjae.aot.lge.com>
References: <1468816661-6345-1-git-send-email-namhyung@kernel.org>
	<1468816661-6345-2-git-send-email-namhyung@kernel.org>
	<CAGXu5jL8frrV99QXrw4touwnXAX0pesxKJnq4Bd_2QZDip7K6Q@mail.gmail.com>
	<20160718055037.GA8051@danjae.aot.lge.com>
	<CAGXu5jJBM6GLwR6B28US11v90pFsiU2yJddm4V6kx3CHdLcOqQ@mail.gmail.com>
	<20160719134303.GA20047@danjae.aot.lge.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Wed, 20 Jul 2016 21:56:19 +0900
Message-ID: <CAM9d7cinK951NOk3HBnmFbJEFYGSQoJQSHVrBZtfECFPXByXBg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio
 pstore driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>, Radim Kr??m???? <rkrcmar@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@kernel.org>, Minchan Kim <minchan@kernel.org>, KVM <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>

On Tue, Jul 19, 2016 at 10:43 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> The other one is the file management on the host side.  I am thinking
> of a simple way that the log file is splitted when it exceeds the half
> of the allowed max size.  It would be configurable and might allow
> unlimited logs if user requests it explicitly (if qemu guys say ok)..

On a second thought, I think that size of log file should not exceed
the pstore buffer size in order to be read back later.  When total size
of log files becomes larger then the limit, the oldest file of same
type can be deleted. This way looks simpler to manage IMHO.

Also I think the pstore id should be managed by host device rather
than guest driver to handle splitted files properly.

Thanks,
Namhyung