From: Gang Chen <gang.chen.5i5j@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xffffffff for tcg_target_ulong using
Date: Wed, 21 Jan 2015 09:46:57 +0800 [thread overview]
Message-ID: <CAMCqw8JDF4BamxKvNahWHJ-ZAzv8Hv9B80GdTwnD8tKJ2gmyvg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9a3msdQYp_2VTYdzT5JGmPtReLMYxtEuFGB=HqsaAxRw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
It is not for fixing bugs. I guess it belongs to trivial patch (not fix
bugs, not changing any working flow).
And excuse me, gmail is broken again, in China, I have to reply on web site
via my Mac book Safari (which is not a pure text).
On Mon, Jan 19, 2015 at 11:58 PM, Peter Maydell <peter.maydell@linaro.org>
wrote:
> On 19 January 2015 at 15:34, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> > For tcg_target_ulong (include TCGArg), it often uses lower 32-bit mask
> > and higher 32-bit mask, so define the related macro for it, so can let
> > code simpler, and avoid various coding styles for them.
> >
> > - For lower, some append 'u', some append 'U', and some no 'u' or 'U'.
> >
> > - For higher, some append 'ull', some use type cast.
> >
> > - For lower but may be used higher bits, append 'ull'.
>
> Is this patch fixing any actual bugs? I think code-style-wise
> I prefer what we have at the moment...
>
> -- PMM
>
--
Chen Gang
[-- Attachment #2: Type: text/html, Size: 1562 bytes --]
next prev parent reply other threads:[~2015-01-21 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 15:34 [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xffffffff for tcg_target_ulong using Chen Gang
2015-01-19 15:58 ` Peter Maydell
2015-01-21 1:46 ` Gang Chen [this message]
[not found] <54BBDDDC.9000804@sunrus.com.cn>
2015-01-18 16:25 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMCqw8JDF4BamxKvNahWHJ-ZAzv8Hv9B80GdTwnD8tKJ2gmyvg@mail.gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).