From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDkNo-00005K-Nd for qemu-devel@nongnu.org; Tue, 20 Jan 2015 20:47:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDkNn-0001Q3-JU for qemu-devel@nongnu.org; Tue, 20 Jan 2015 20:47:00 -0500 MIME-Version: 1.0 In-Reply-To: References: <54BD23F7.7010700@gmail.com> Date: Wed, 21 Jan 2015 09:46:57 +0800 Message-ID: From: Gang Chen Content-Type: multipart/alternative; boundary=001a11c3f1a612578a050d1fbb07 Subject: Re: [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xffffffff for tcg_target_ulong using List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , qemu-devel , Alexander Graf , "rth@twiddle.net" --001a11c3f1a612578a050d1fbb07 Content-Type: text/plain; charset=UTF-8 It is not for fixing bugs. I guess it belongs to trivial patch (not fix bugs, not changing any working flow). And excuse me, gmail is broken again, in China, I have to reply on web site via my Mac book Safari (which is not a pure text). On Mon, Jan 19, 2015 at 11:58 PM, Peter Maydell wrote: > On 19 January 2015 at 15:34, Chen Gang wrote: > > For tcg_target_ulong (include TCGArg), it often uses lower 32-bit mask > > and higher 32-bit mask, so define the related macro for it, so can let > > code simpler, and avoid various coding styles for them. > > > > - For lower, some append 'u', some append 'U', and some no 'u' or 'U'. > > > > - For higher, some append 'ull', some use type cast. > > > > - For lower but may be used higher bits, append 'ull'. > > Is this patch fixing any actual bugs? I think code-style-wise > I prefer what we have at the moment... > > -- PMM > -- Chen Gang --001a11c3f1a612578a050d1fbb07 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
It is not for fixing bugs. I guess it belongs to trivial p= atch (not fix bugs, not changing any working flow).

And = excuse me, gmail is broken again, in China, I have to reply on web site via= my Mac book Safari (which is not a pure text).

On Mon, Jan 19, 2015 at 11:58 PM,= Peter Maydell <peter.maydell@linaro.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On 19 January 2015 at 15:34,= Chen Gang <gang.chen.5i5j@g= mail.com> wrote:
> For tcg_target_ulong (include TCGArg), it often uses lower 32-bit mask=
> and higher 32-bit mask, so define the related macro for it, so can let=
> code simpler, and avoid various coding styles for them.
>
>=C2=A0 - For lower, some append 'u', some append 'U', a= nd some no 'u' or 'U'.
>
>=C2=A0 - For higher, some append 'ull', some use type cast.
>
>=C2=A0 - For lower but may be used higher bits, append 'ull'.
Is this patch fixing any actual bugs? I think code-style-wise
I prefer what we have at the moment...

-- PMM



--
Chen Gang
--001a11c3f1a612578a050d1fbb07--