From: Ard Biesheuvel <ardb@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ard Biesheuvel <ardb+git@google.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/x86: Always treat the PVH entrypoint as a 32-bit field
Date: Fri, 27 Sep 2024 15:24:01 +0200 [thread overview]
Message-ID: <CAMj1kXF4C5ybD=GdwgN6BMb2u0N44e0ccupvPoAtmHi432zh+w@mail.gmail.com> (raw)
In-Reply-To: <4bd26d6c-1f68-43e9-ac99-b542f24676ef@redhat.com>
On Fri, 27 Sept 2024 at 14:05, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 9/27/24 09:19, Ard Biesheuvel wrote:
> > -
> > - pvh_start_addr = *(uint32_t *)elf_note_data_addr;
> > }
> >
> > + pvh_start_addr = *(uint32_t *)elf_note_data_addr;
>
> I think we even want ldl_le_p(elf_note_data_addr) here? It makes no
> sense to read big-endian data.
>
Yeah good point.
prev parent reply other threads:[~2024-09-27 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 7:19 [PATCH] hw/x86: Always treat the PVH entrypoint as a 32-bit field Ard Biesheuvel
2024-09-27 12:05 ` Paolo Bonzini
2024-09-27 13:24 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXF4C5ybD=GdwgN6BMb2u0N44e0ccupvPoAtmHi432zh+w@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=ardb+git@google.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).