From: Ard Biesheuvel <ardb@kernel.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, berrange@redhat.com
Subject: Re: [RFC PATCH for-8.2 00/18] crypto: Provide clmul.h and host accel
Date: Thu, 3 Aug 2023 16:02:45 +0200 [thread overview]
Message-ID: <CAMj1kXHKXeH6JvEqwvJQcpL1kje0rJbx9-WkAgDBiUzr78VMYA@mail.gmail.com> (raw)
In-Reply-To: <20230713211435.13505-1-richard.henderson@linaro.org>
On Thu, 13 Jul 2023 at 23:14, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Inspired by Ard Biesheuvel's RFC patches [1] for accelerating
> carry-less multiply under emulation.
>
> This is less polished than the AES patch set:
>
> (1) Should I split HAVE_CLMUL_ACCEL into per-width HAVE_CLMUL{N}_ACCEL?
> The "_generic" and "_accel" split is different from aes-round.h
> because of the difference in support for different widths, and it
> means that each host accel has more boilerplate.
>
> (2) Should I bother trying to accelerate anything other than 64x64->128?
That is the only compelling use case afaict.
> That seems to be the one that GSM really wants anyway. I'd keep all
> of the sizes implemented generically, since that centralizes the 3
> target implementations.
>
> (3) The use of Int128 isn't fantastic -- better would be a vector type,
> though that has its own special problems for ppc64le (see the
> endianness hoops within aes-round.h). Perhaps leave things in
> env memory, like I was mostly able to do with AES?
>
> (4) No guest test case(s).
>
>
> r~
>
>
> [1] https://patchew.org/QEMU/20230601123332.3297404-1-ardb@kernel.org/
>
> Richard Henderson (18):
> crypto: Add generic 8-bit carry-less multiply routines
> target/arm: Use clmul_8* routines
> target/s390x: Use clmul_8* routines
> target/ppc: Use clmul_8* routines
> crypto: Add generic 16-bit carry-less multiply routines
> target/arm: Use clmul_16* routines
> target/s390x: Use clmul_16* routines
> target/ppc: Use clmul_16* routines
> crypto: Add generic 32-bit carry-less multiply routines
> target/arm: Use clmul_32* routines
> target/s390x: Use clmul_32* routines
> target/ppc: Use clmul_32* routines
> crypto: Add generic 64-bit carry-less multiply routine
> target/arm: Use clmul_64
> target/s390x: Use clmul_64
> target/ppc: Use clmul_64
> host/include/i386: Implement clmul.h
> host/include/aarch64: Implement clmul.h
>
> host/include/aarch64/host/cpuinfo.h | 1 +
> host/include/aarch64/host/crypto/clmul.h | 230 +++++++++++++++++++++++
> host/include/generic/host/crypto/clmul.h | 28 +++
> host/include/i386/host/cpuinfo.h | 1 +
> host/include/i386/host/crypto/clmul.h | 187 ++++++++++++++++++
> host/include/x86_64/host/crypto/clmul.h | 1 +
> include/crypto/clmul.h | 123 ++++++++++++
> target/arm/tcg/vec_internal.h | 11 --
> crypto/clmul.c | 163 ++++++++++++++++
> target/arm/tcg/mve_helper.c | 16 +-
> target/arm/tcg/vec_helper.c | 112 ++---------
> target/ppc/int_helper.c | 63 +++----
> target/s390x/tcg/vec_int_helper.c | 175 +++++++----------
> util/cpuinfo-aarch64.c | 4 +-
> util/cpuinfo-i386.c | 1 +
> crypto/meson.build | 9 +-
> 16 files changed, 865 insertions(+), 260 deletions(-)
> create mode 100644 host/include/aarch64/host/crypto/clmul.h
> create mode 100644 host/include/generic/host/crypto/clmul.h
> create mode 100644 host/include/i386/host/crypto/clmul.h
> create mode 100644 host/include/x86_64/host/crypto/clmul.h
> create mode 100644 include/crypto/clmul.h
> create mode 100644 crypto/clmul.c
>
> --
> 2.34.1
>
prev parent reply other threads:[~2023-08-03 14:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 21:14 [RFC PATCH for-8.2 00/18] crypto: Provide clmul.h and host accel Richard Henderson
2023-07-13 21:14 ` [PATCH 01/18] crypto: Add generic 8-bit carry-less multiply routines Richard Henderson
2023-07-13 21:14 ` [PATCH 02/18] target/arm: Use clmul_8* routines Richard Henderson
2023-07-13 21:43 ` Philippe Mathieu-Daudé
2023-07-13 21:14 ` [PATCH 03/18] target/s390x: " Richard Henderson
2023-07-13 21:14 ` [PATCH 04/18] target/ppc: " Richard Henderson
2023-07-13 21:14 ` [PATCH 05/18] crypto: Add generic 16-bit carry-less multiply routines Richard Henderson
2023-07-13 21:14 ` [PATCH 06/18] target/arm: Use clmul_16* routines Richard Henderson
2023-07-13 21:14 ` [PATCH 07/18] target/s390x: " Richard Henderson
2023-07-13 21:14 ` [PATCH 08/18] target/ppc: " Richard Henderson
2023-07-13 21:14 ` [PATCH 09/18] crypto: Add generic 32-bit carry-less multiply routines Richard Henderson
2023-07-13 21:14 ` [PATCH 10/18] target/arm: Use clmul_32* routines Richard Henderson
2023-07-13 21:14 ` [PATCH 11/18] target/s390x: " Richard Henderson
2023-07-13 21:14 ` [PATCH 12/18] target/ppc: " Richard Henderson
2023-07-13 21:14 ` [PATCH 13/18] crypto: Add generic 64-bit carry-less multiply routine Richard Henderson
2023-07-13 21:14 ` [PATCH 14/18] target/arm: Use clmul_64 Richard Henderson
2023-07-13 21:14 ` [PATCH 15/18] target/s390x: " Richard Henderson
2023-07-13 21:14 ` [PATCH 16/18] target/ppc: " Richard Henderson
2023-07-13 21:14 ` [PATCH 17/18] host/include/i386: Implement clmul.h Richard Henderson
2023-07-19 11:52 ` Ilya Leoshkevich
2023-07-22 11:47 ` Richard Henderson
2023-07-13 21:14 ` [PATCH 18/18] host/include/aarch64: " Richard Henderson
2023-08-03 14:02 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHKXeH6JvEqwvJQcpL1kje0rJbx9-WkAgDBiUzr78VMYA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).