From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM2mp-0008VD-1d for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:21:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TM2mn-0003TR-Mm for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:21:46 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:54906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM2mn-0003TM-IS for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:21:45 -0400 Received: by mail-oa0-f45.google.com with SMTP id i18so923382oag.4 for ; Wed, 10 Oct 2012 13:21:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5075A346.80601@suse.de> References: <1337742502-28565-1-git-send-email-afaerber@suse.de> <1337742502-28565-43-git-send-email-afaerber@suse.de> <5075912D.1090401@suse.de> <5075A346.80601@suse.de> Date: Thu, 11 Oct 2012 00:21:44 +0400 Message-ID: From: Max Filippov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next 42/59] xtensa_pic: Pass XtensaCPU to xtensa_ccompare_cb() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org On Wed, Oct 10, 2012 at 8:33 PM, Andreas F=E4rber wrote: > Am 10.10.2012 17:35, schrieb Max Filippov: >> On Wed, Oct 10, 2012 at 7:15 PM, Andreas F=E4rber wro= te: >>> Am 23.05.2012 05:08, schrieb Andreas F=E4rber: >>>> Needed for cpu_has_work(). >>>> >>>> Signed-off-by: Andreas F=E4rber >>> >>> Max, could you ack this trivial patch please? It still applies. >> >> Well, it does but why do you want to add a level of indirection here? >> Does that mean that cpu->env may change during cpu lifetime? >> Commit message is not very helpful here. > > Patch 43/59 in that series updates cpu_has_work() argument to CPUState*, > thus this patch prepares xtensa_pic as one of the callers. > > This is the only xtensa patch I have in my queue, so I wanted to avoid > hitting you with a large resend. > > I see now that xtensa_set_irq could get an XtensaCPU opaque as well, but > so far there was no need apparently, so that can be changed later. > > For target-specific code my general rule of thumb is, use FooCPU rather > than CPUFooState arguments and opaques wherever possible since the need > is growing. Also, any new fields that are not accessed by TCG should be > placed into FooCPU rather than CPUFooState. Ok, Acked-by: Max Filippov --=20 Thanks. -- Max