From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1UvbBd-00050i-Hk
	for qemu-devel@nongnu.org; Sat, 06 Jul 2013 18:42:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1UvbBc-0005iM-EU
	for qemu-devel@nongnu.org; Sat, 06 Jul 2013 18:42:37 -0400
MIME-Version: 1.0
In-Reply-To: <51D87BC6.2090600@suse.de>
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-34-git-send-email-afaerber@suse.de>
	<51D87BC6.2090600@suse.de>
Date: Sun, 7 Jul 2013 02:42:35 +0400
Message-ID: <CAMo8BfJeTR127oRbnJSdusw76eWjsQrv9RDGOK9_j-LDk6uugg@mail.gmail.com>
From: Max Filippov <jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 33/41] cpu: Turn
 cpu_get_phys_page_debug() into a CPUClass hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Green <green@moxielogic.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Michael Walle <michael@walle.cc>, qemu-ppc <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, jan.kiszka@web.de, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On Sun, Jul 7, 2013 at 12:19 AM, Andreas F=C3=A4rber <afaerber@suse.de> wro=
te:
> Am 29.06.2013 22:01, schrieb Andreas F=C3=A4rber:
>> Since all targets now assign a softmmu-only field, we can drop helpers
>> cpu_class_set_{do_unassigned_access,vmsd}() and device_class_set_vmsd().
>>
>> Prepares for changing cpu_memory_rw_debug() argument to CPUState.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>
> The following fixup for xtensa is required. This demonstrates how
> dangerous it is to pass void* arguments directly into functions - please
> always use a typed local variable to enforce type checks.

With this fix it works, so for xtensa part
Acked-by: Max Filippov <jcmvbkbc@gmail.com>

My question about having configuration pointer cached in the env
still remains though.

--=20
Thanks.
-- Max