From: Max Filippov <jcmvbkbc@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel <qemu-devel@nongnu.org>, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub
Date: Wed, 7 Jun 2017 12:26:25 -0700 [thread overview]
Message-ID: <CAMo8BfK_X_uzUOOYmdT3Hty3GcE80vJMxmrqDA0RsFTeFxWmkQ@mail.gmail.com> (raw)
In-Reply-To: <cdeaf0b3-e304-3518-9d71-95a30e85a8a1@twiddle.net>
On Tue, Jun 6, 2017 at 5:55 PM, Richard Henderson <rth@twiddle.net> wrote:
> On 06/03/2017 02:19 AM, Max Filippov wrote:
>>
>> + memset(mem_buf, 0, reg->size);
>> + return reg->size;
>> return 0;
>
> Leaving a dead return.
Meh ): Thanks for the review. Will send a fix.
--
Thanks.
-- Max
prev parent reply other threads:[~2017-06-07 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 9:19 [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub Max Filippov
2017-06-07 0:55 ` Richard Henderson
2017-06-07 19:26 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfK_X_uzUOOYmdT3Hty3GcE80vJMxmrqDA0RsFTeFxWmkQ@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).