From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIgb6-0007Hn-EA for qemu-devel@nongnu.org; Wed, 07 Jun 2017 15:26:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIgb5-0001e3-Ox for qemu-devel@nongnu.org; Wed, 07 Jun 2017 15:26:28 -0400 MIME-Version: 1.0 In-Reply-To: References: <1496481564-20545-1-git-send-email-jcmvbkbc@gmail.com> From: Max Filippov Date: Wed, 7 Jun 2017 12:26:25 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel , qemu-stable On Tue, Jun 6, 2017 at 5:55 PM, Richard Henderson wrote: > On 06/03/2017 02:19 AM, Max Filippov wrote: >> >> + memset(mem_buf, 0, reg->size); >> + return reg->size; >> return 0; > > Leaving a dead return. Meh ): Thanks for the review. Will send a fix. -- Thanks. -- Max