From: Max Filippov <jcmvbkbc@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug
Date: Wed, 5 Dec 2012 14:36:20 +0300 [thread overview]
Message-ID: <CAMo8BfL2Bfwq-KAzA=JVEPS8hGJjYKMUaxSzrCa3j2tn8LSsiQ@mail.gmail.com> (raw)
In-Reply-To: <50BF2CBE.8070006@suse.de>
On Wed, Dec 5, 2012 at 3:15 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 17.11.2012 21:52, schrieb Max Filippov:
>> cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault:
>> the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK.
>>
>> This fixes odd gdb code display with PAE enabled.
>>
>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>
> You write, they are "not in sync". Would it be possible to share code to
> assure this, e.g., by calling a helper function from both?
I'd say yes though that'd be a bigger change. I'll try to do it.
--
Thanks.
-- Max
prev parent reply other threads:[~2012-12-05 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 20:52 [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug Max Filippov
2012-12-04 19:36 ` Max Filippov
2012-12-05 11:15 ` Andreas Färber
2012-12-05 11:36 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMo8BfL2Bfwq-KAzA=JVEPS8hGJjYKMUaxSzrCa3j2tn8LSsiQ@mail.gmail.com' \
--to=jcmvbkbc@gmail.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).