From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52858)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1TgDU0-0003HI-Le
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:49:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1TgDTk-0005bS-E9
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:49:44 -0500
Received: from mail-ob0-f173.google.com ([209.85.214.173]:33071)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1TgDH3-0002kD-3O
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:36:21 -0500
Received: by mail-ob0-f173.google.com with SMTP id xn12so4652835obc.4
	for <qemu-devel@nongnu.org>; Wed, 05 Dec 2012 03:36:20 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <50BF2CBE.8070006@suse.de>
References: <1353185531-17042-1-git-send-email-jcmvbkbc@gmail.com>
	<50BF2CBE.8070006@suse.de>
Date: Wed, 5 Dec 2012 14:36:20 +0300
Message-ID: <CAMo8BfL2Bfwq-KAzA=JVEPS8hGJjYKMUaxSzrCa3j2tn8LSsiQ@mail.gmail.com>
From: Max Filippov <jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in
	cpu_get_phys_page_debug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org

On Wed, Dec 5, 2012 at 3:15 PM, Andreas F=E4rber <afaerber@suse.de> wrote:
> Am 17.11.2012 21:52, schrieb Max Filippov:
>> cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault:
>> the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK.
>>
>> This fixes odd gdb code display with PAE enabled.
>>
>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>
> You write, they are "not in sync". Would it be possible to share code to
> assure this, e.g., by calling a helper function from both?

I'd say yes though that'd be a bigger change. I'll try to do it.

--=20
Thanks.
-- Max