From: Max Filippov <jcmvbkbc@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Jason Wang <jasowang@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH 2/2] hw/net/opencores_eth: Remove unnecessary address masking
Date: Mon, 8 Jun 2020 02:27:36 -0700 [thread overview]
Message-ID: <CAMo8BfLJrrAM9EL80SF36qLTO0Kut8ODOuDN5kC1LoVNjBKEYA@mail.gmail.com> (raw)
In-Reply-To: <20200608091508.19838-3-f4bug@amsat.org>
On Mon, Jun 8, 2020 at 2:15 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The memory region is limited to 1 KiB, so the address is
> garantied to be in that range. No need to mask.
>
> 711 static const MemoryRegionOps open_eth_desc_ops = {
> 712 .read = open_eth_desc_read,
> 713 .write = open_eth_desc_write,
> 714 };
> ...
> 725 memory_region_init_io(&s->desc_io, OBJECT(dev),
> 725 &open_eth_desc_ops, s,
> 726 "open_eth.desc", 0x400);
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/net/opencores_eth.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
next prev parent reply other threads:[~2020-06-08 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:15 [PATCH 0/2] hw/net/opencores_eth: Trivial patches Philippe Mathieu-Daudé
2020-06-08 9:15 ` [PATCH 1/2] hw/net/opencores_eth: Use definitions instead of magic values Philippe Mathieu-Daudé
2020-06-08 9:25 ` Max Filippov
2020-06-08 9:15 ` [PATCH 2/2] hw/net/opencores_eth: Remove unnecessary address masking Philippe Mathieu-Daudé
2020-06-08 9:27 ` Max Filippov [this message]
2020-09-02 12:26 ` [PATCH 0/2] hw/net/opencores_eth: Trivial patches Philippe Mathieu-Daudé
2020-09-09 18:00 ` Philippe Mathieu-Daudé
2020-09-10 1:44 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfLJrrAM9EL80SF36qLTO0Kut8ODOuDN5kC1LoVNjBKEYA@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).