Re: [RFC PATCH 3/3] hw/peci: add support for EndPointConfig reads

[Titus Rwantare <titusr@google.com>]

On Fri, 9 Sept 2022 at 12:48, Peter Delevoryas <peter@pjd.dev> wrote:
>
> On Tue, Sep 06, 2022 at 10:05:52PM +0000, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare <titusr@google.com>
> > Reviewed-by: Hao Wu <wuhaotsh@google.com>
> > ---
...
> > +++ b/include/hw/peci/peci.h
> > @@ -112,6 +112,26 @@ typedef struct PECITempTarget {
> >      uint8_t tjmax;
> >  } PECITempTarget;
> >
> > +typedef enum PECIEndPtType {
> > +    LOCAL_PCI_CFG = 3,
> > +    PCI_CFG,
> > +    MMIO_BDF,
> > +} PECIEndPtType;
> > +
> > +typedef struct __attribute__ ((__packed__)) {
> > +    PECIEndPtType msg_type;
> > +    uint8_t addr_type;
> > +    uint8_t bus;
> > +    uint8_t dev;
> > +    uint8_t func;
> > +    uint16_t reg;
> > +} PECIEndPtHeader;
> > +
> > +typedef struct {
> > +    PECIEndPtHeader hdr;
> > +    uint32_t data;
> > +} PECIEndPtConfig;
>
> I noticed the summary is "hw/peci: add support for EndPointConfig reads"
> but type definitions here use "EndPt", maybe they should be
> "PECIEndPoint*"? I don't think extending to Point is too long.

Fair, fixed in v2.


Titus