Re: [PATCH v1 6/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test

["Marc-André Lureau" <marcandre.lureau@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Wed, Feb 17, 2021 at 4:19 PM Alex Bennée <alex.bennee@linaro.org> wrote:

> This is a band-aid with a TODO for cases when QEMU doesn't start due
> to missing VirGL. Longer term we could do with some proper feature
> probing.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
>  tests/acceptance/virtio-gpu.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/virtio-gpu.py
> b/tests/acceptance/virtio-gpu.py
> index ab1a4c1a71..ab18cddbb7 100644
> --- a/tests/acceptance/virtio-gpu.py
> +++ b/tests/acceptance/virtio-gpu.py
> @@ -85,7 +85,12 @@ def test_virtio_vga_virgl(self):
>              "-append",
>              kernel_command_line,
>          )
> -        self.vm.launch()
> +        try:
> +            self.vm.launch()
> +        except:
> +            # TODO: probably fails because we are missing the VirGL
> features
> +            self.cancel("VirGL not enabled?")
> +
>          self.wait_for_console_pattern("as init process")
>          exec_command_and_wait_for_pattern(
>              self, "/usr/sbin/modprobe virtio_gpu", ""
> --
> 2.20.1
>
>

[-- Attachment #2: Type: text/html, Size: 2139 bytes --]