qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Revert "Revert "mux: fix ctrl-a b again"" again
Date: Fri, 20 Apr 2018 00:12:49 +0200	[thread overview]
Message-ID: <CAMxuvaw1sobCX+rM1OXWjo9cxxtt27jPY1Fstuq3f=fhfH3wyw@mail.gmail.com> (raw)
In-Reply-To: <20180419220914.959-3-f4bug@amsat.org>

Hi

On Fri, Apr 20, 2018 at 12:09 AM, Philippe Mathieu-Daudé
<f4bug@amsat.org> wrote:
> This reverts commit 6f660996f1623034344cc37a1d430099067b755b to
> reintroduce commit 1b2503fcf7b5932c5a3779ca2ceb92bd403c4ee7.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

I think we agreed this would go after 2.12.

I was going to send an updated patch with additional tests. I can take
your patch for the next series perhaps, instead of doing the double
revert ;)

> ---
>  chardev/char-mux.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/chardev/char-mux.c b/chardev/char-mux.c
> index 1b925c8dec..6055e76293 100644
> --- a/chardev/char-mux.c
> +++ b/chardev/char-mux.c
> @@ -304,6 +304,7 @@ void mux_set_focus(Chardev *chr, int focus)
>      }
>
>      d->focus = focus;
> +    chr->be = d->backends[focus];
>      mux_chr_send_event(d, d->focus, CHR_EVENT_MUX_IN);
>  }
>
> --
> 2.17.0
>

      reply	other threads:[~2018-04-19 22:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 22:09 [Qemu-devel] [PATCH 0/2] hw/superio: Fix inconsistent use of Chardev->be Philippe Mathieu-Daudé
2018-04-19 22:09 ` [Qemu-devel] [PATCH 1/2] hw/isa/superio: " Philippe Mathieu-Daudé
2018-04-20  8:43   ` Peter Maydell
2018-04-20 12:39     ` Philippe Mathieu-Daudé
2018-04-20 12:59       ` Peter Maydell
2018-04-20 13:04         ` Philippe Mathieu-Daudé
2018-04-20 14:00           ` Peter Maydell
2018-04-20 14:29           ` Philippe Mathieu-Daudé
2018-04-20 14:43             ` Peter Maydell
2018-04-19 22:09 ` [Qemu-devel] [PATCH 2/2] Revert "Revert "mux: fix ctrl-a b again"" again Philippe Mathieu-Daudé
2018-04-19 22:12   ` Marc-André Lureau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMxuvaw1sobCX+rM1OXWjo9cxxtt27jPY1Fstuq3f=fhfH3wyw@mail.gmail.com' \
    --to=marcandre.lureau@redhat.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).