* [PATCH] ui/gtk: fix passing y0_top parameter to scanout
@ 2023-02-20 17:56 Erico Nunes
2023-02-20 17:58 ` Marc-André Lureau
0 siblings, 1 reply; 3+ messages in thread
From: Erico Nunes @ 2023-02-20 17:56 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau, Erico Nunes
The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however
in the gtk ui both implementations dropped it when doing the next
scanout_texture call.
Fixes flipped linux console using vhost-user-gpu with the gtk ui
display.
Signed-off-by: Erico Nunes <ernunes@redhat.com>
---
ui/gtk-egl.c | 2 +-
ui/gtk-gl-area.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index e84431790c..557668e418 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -256,7 +256,7 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,
}
gd_egl_scanout_texture(dcl, dmabuf->texture,
- false, dmabuf->width, dmabuf->height,
+ dmabuf->y0_top, dmabuf->width, dmabuf->height,
0, 0, dmabuf->width, dmabuf->height);
if (dmabuf->allow_fences) {
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 7696df1f6b..c384a1516b 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -298,7 +298,7 @@ void gd_gl_area_scanout_dmabuf(DisplayChangeListener *dcl,
}
gd_gl_area_scanout_texture(dcl, dmabuf->texture,
- false, dmabuf->width, dmabuf->height,
+ dmabuf->y0_top, dmabuf->width, dmabuf->height,
0, 0, dmabuf->width, dmabuf->height);
if (dmabuf->allow_fences) {
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ui/gtk: fix passing y0_top parameter to scanout
2023-02-20 17:56 [PATCH] ui/gtk: fix passing y0_top parameter to scanout Erico Nunes
@ 2023-02-20 17:58 ` Marc-André Lureau
2023-05-11 13:05 ` Erico Nunes
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2023-02-20 17:58 UTC (permalink / raw)
To: Erico Nunes; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]
On Mon, Feb 20, 2023 at 9:56 PM Erico Nunes <ernunes@redhat.com> wrote:
> The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however
> in the gtk ui both implementations dropped it when doing the next
> scanout_texture call.
>
> Fixes flipped linux console using vhost-user-gpu with the gtk ui
> display.
>
> Signed-off-by: Erico Nunes <ernunes@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/gtk-egl.c | 2 +-
> ui/gtk-gl-area.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
> index e84431790c..557668e418 100644
> --- a/ui/gtk-egl.c
> +++ b/ui/gtk-egl.c
> @@ -256,7 +256,7 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,
> }
>
> gd_egl_scanout_texture(dcl, dmabuf->texture,
> - false, dmabuf->width, dmabuf->height,
> + dmabuf->y0_top, dmabuf->width, dmabuf->height,
> 0, 0, dmabuf->width, dmabuf->height);
>
> if (dmabuf->allow_fences) {
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 7696df1f6b..c384a1516b 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -298,7 +298,7 @@ void gd_gl_area_scanout_dmabuf(DisplayChangeListener
> *dcl,
> }
>
> gd_gl_area_scanout_texture(dcl, dmabuf->texture,
> - false, dmabuf->width, dmabuf->height,
> + dmabuf->y0_top, dmabuf->width,
> dmabuf->height,
> 0, 0, dmabuf->width, dmabuf->height);
>
> if (dmabuf->allow_fences) {
> --
> 2.39.2
>
>
[-- Attachment #2: Type: text/html, Size: 2536 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ui/gtk: fix passing y0_top parameter to scanout
2023-02-20 17:58 ` Marc-André Lureau
@ 2023-05-11 13:05 ` Erico Nunes
0 siblings, 0 replies; 3+ messages in thread
From: Erico Nunes @ 2023-05-11 13:05 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel
Hello,
On 20/02/2023 18:58, Marc-André Lureau wrote:
>
>
> On Mon, Feb 20, 2023 at 9:56 PM Erico Nunes <ernunes@redhat.com
> <mailto:ernunes@redhat.com>> wrote:
>
> The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however
> in the gtk ui both implementations dropped it when doing the next
> scanout_texture call.
>
> Fixes flipped linux console using vhost-user-gpu with the gtk ui
> display.
>
> Signed-off-by: Erico Nunes <ernunes@redhat.com
> <mailto:ernunes@redhat.com>>
>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com
> <mailto:marcandre.lureau@redhat.com>>
Looks like this patch was never applied, could you look at it again please?
Thanks
Erico
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-11 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 17:56 [PATCH] ui/gtk: fix passing y0_top parameter to scanout Erico Nunes
2023-02-20 17:58 ` Marc-André Lureau
2023-05-11 13:05 ` Erico Nunes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).