[PATCH] ui/gtk: fix passing y0_top parameter to scanout

[PATCH] ui/gtk: fix passing y0_top parameter to scanout

[Erico Nunes]

The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however
in the gtk ui both implementations dropped it when doing the next
scanout_texture call.

Fixes flipped linux console using vhost-user-gpu with the gtk ui
display.

Signed-off-by: Erico Nunes <ernunes@redhat.com>
---
 ui/gtk-egl.c     | 2 +-
 ui/gtk-gl-area.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index e84431790c..557668e418 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -256,7 +256,7 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,
     }
 
     gd_egl_scanout_texture(dcl, dmabuf->texture,
-                           false, dmabuf->width, dmabuf->height,
+                           dmabuf->y0_top, dmabuf->width, dmabuf->height,
                            0, 0, dmabuf->width, dmabuf->height);
 
     if (dmabuf->allow_fences) {
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 7696df1f6b..c384a1516b 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -298,7 +298,7 @@ void gd_gl_area_scanout_dmabuf(DisplayChangeListener *dcl,
     }
 
     gd_gl_area_scanout_texture(dcl, dmabuf->texture,
-                               false, dmabuf->width, dmabuf->height,
+                               dmabuf->y0_top, dmabuf->width, dmabuf->height,
                                0, 0, dmabuf->width, dmabuf->height);
 
     if (dmabuf->allow_fences) {
-- 
2.39.2

Re: [PATCH] ui/gtk: fix passing y0_top parameter to scanout

[Marc-André Lureau]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

On Mon, Feb 20, 2023 at 9:56 PM Erico Nunes <ernunes@redhat.com> wrote:

> The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however
> in the gtk ui both implementations dropped it when doing the next
> scanout_texture call.
>
> Fixes flipped linux console using vhost-user-gpu with the gtk ui
> display.
>
> Signed-off-by: Erico Nunes <ernunes@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>




> ---
>  ui/gtk-egl.c     | 2 +-
>  ui/gtk-gl-area.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
> index e84431790c..557668e418 100644
> --- a/ui/gtk-egl.c
> +++ b/ui/gtk-egl.c
> @@ -256,7 +256,7 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,
>      }
>
>      gd_egl_scanout_texture(dcl, dmabuf->texture,
> -                           false, dmabuf->width, dmabuf->height,
> +                           dmabuf->y0_top, dmabuf->width, dmabuf->height,
>                             0, 0, dmabuf->width, dmabuf->height);
>
>      if (dmabuf->allow_fences) {
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 7696df1f6b..c384a1516b 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -298,7 +298,7 @@ void gd_gl_area_scanout_dmabuf(DisplayChangeListener
> *dcl,
>      }
>
>      gd_gl_area_scanout_texture(dcl, dmabuf->texture,
> -                               false, dmabuf->width, dmabuf->height,
> +                               dmabuf->y0_top, dmabuf->width,
> dmabuf->height,
>                                 0, 0, dmabuf->width, dmabuf->height);
>
>      if (dmabuf->allow_fences) {
> --
> 2.39.2
>
>

[-- Attachment #2: Type: text/html, Size: 2536 bytes --]

Re: [PATCH] ui/gtk: fix passing y0_top parameter to scanout

[Erico Nunes]

Hello,

On 20/02/2023 18:58, Marc-André Lureau wrote:
> 
> 
> On Mon, Feb 20, 2023 at 9:56 PM Erico Nunes <ernunes@redhat.com
> <mailto:ernunes@redhat.com>> wrote:
> 
>     The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however
>     in the gtk ui both implementations dropped it when doing the next
>     scanout_texture call.
> 
>     Fixes flipped linux console using vhost-user-gpu with the gtk ui
>     display.
> 
>     Signed-off-by: Erico Nunes <ernunes@redhat.com
>     <mailto:ernunes@redhat.com>>
> 
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com
> <mailto:marcandre.lureau@redhat.com>>

Looks like this patch was never applied, could you look at it again please?

Thanks

Erico