From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED52CD116F1 for ; Mon, 1 Dec 2025 12:58:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQ3TK-000571-0S; Mon, 01 Dec 2025 07:57:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQ3TI-000524-DJ for qemu-devel@nongnu.org; Mon, 01 Dec 2025 07:57:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQ3TD-0004iS-8H for qemu-devel@nongnu.org; Mon, 01 Dec 2025 07:57:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764593850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3hFQFNQBqF7rbiqmG48xV2Hhtk5twPvbs+zvSZx1j4A=; b=KCgaIVRtaFVQR1Cgsc7Xui1L2aUKQU8C0gH7z9xNxnwEtBsI7UUHEzPyojF2g46AlVMsW1 AAys9vehhR/f9YP/87/5pg4WbSWqB4OMhGoH86BBvWSDqQQOEzMJtRqe+kvoLqNAYd2a4v YE4pAvE5ZLZMZVJe2na2gtAJ7I4Mg68= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-utb7aFAWPDuTP9-O8pYb0g-1; Mon, 01 Dec 2025 07:57:28 -0500 X-MC-Unique: utb7aFAWPDuTP9-O8pYb0g-1 X-Mimecast-MFC-AGG-ID: utb7aFAWPDuTP9-O8pYb0g_1764593847 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29845b18d1aso76081115ad.1 for ; Mon, 01 Dec 2025 04:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764593847; x=1765198647; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3hFQFNQBqF7rbiqmG48xV2Hhtk5twPvbs+zvSZx1j4A=; b=ai0DZa+v7Pd9R+WuYxcVp4PhRaiBGPa+b8VGAowY1K/nYHe5xaXUQ1B1KK+CZ4gcYv QwPDSYHoNH9nQTwj6HZLM4NtTB0dqI8OELhf7ktIY1+KXr+3tvRmVMQsuM4S4/LmwWxZ TBfuWqBcn07FJCaY4xyeujUnvhdnUjN/YlSILtlvp1l6E1B9ufUMqwElXgmWi7GduptP 2CkeTk1tVNglSj5kR5Gj0pVHG3Rzx2uwED58XK9oO5DHfW1eOqZbA5Scwti3Anstg59J aZQPdvI3oIFunhkuFUl4f8PEvo3KpLgvqpCqq4jCChVoytGR+Q7G/H7AsFrQ10RsqTP2 32Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764593847; x=1765198647; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3hFQFNQBqF7rbiqmG48xV2Hhtk5twPvbs+zvSZx1j4A=; b=T4hgtbWgLS5/G9m1LB7cSbGsZT9BUFwbBJqlW6pAlOnuyIu+eZn5dQI+vxVu+ypFcL KhjmCsUnT59f2I90uCOn4/JXHdSZOsptcnittvisnJlC86hclUJy3KTKEHq2hTmXqHYS Yt/58vD3mWlbhMH9boYhwBl3Zp9VebS/HDPYo1gWSt5n3jjkh/atuxo3v0eqLQ/HKVJw Zeag+ZtpdU1L9z8x9ObwfTN08AZkHo1cbkJBUY/8A0F9KlsMoPJCyQ5eAmTCsDBReSmy i+N4+p0R8g2J2c7KMECz9ua4DdCPO5IXqjSEEKl1FtEkpAPSP6wTWgAeTYmDVAyVPKFP suLg== X-Forwarded-Encrypted: i=1; AJvYcCVMwtFWFO/4xvFMPJBwicAQBhCW+hH8Yp9iZdeWu7uZEQD82RJPbxnV1PZzhk+/cyXbCgfYPBM/3Xpj@nongnu.org X-Gm-Message-State: AOJu0YyFYbKCkalk6EhAjqRk2yfEzFLO/6chwbMAMdm9+o2TOiWuWxpj Rhhfb2ewcsxGRylp6BxHR6OfPiVootNQP9xfhdRbPigZlwVVsNjLbSJpWiEZd88SgahAxm4YKLJ 8WQOnYkVzTvGo0F3lSfEP+utRj9hrFvy9RJIyi6FspHbd3/jzEiADdzHyc6ZDAq/Y2mllH1+kIR BGYLOKlEha9gu6+4BXylGwsJW10gAtYKg= X-Gm-Gg: ASbGncsQBM5jWO6xMBtAjA54bIQcLx/ufcl7cMr+ZTEzRO8QKiCb538iRCgDUNbEMFg JpeEHef6ohjMtM1CAU20nJnXyPDzsqP/Z1GdXQZmF+M6BngWQP5KhGIZkVlazRsSWf4WrdfMo93 4G/4+uC2+LKybh6xLcaXT62UaqtVYdd0YFLZ1N/VybAwB64aHIf+naNVI8KYTLLII96rXrPu4nG b/ZquY20lt5v+qoP/ftaQsqNA== X-Received: by 2002:a17:903:1b24:b0:297:f35b:e214 with SMTP id d9443c01a7336-29b6c6ae346mr389857325ad.47.1764593847009; Mon, 01 Dec 2025 04:57:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFO1vKZnUTWIc/zWv8972Q6z5BQR1cbdv5JTH523EjTJHqLMAiOLGDuvviuB+yy84qayN481TBS/3JUfd1Jims= X-Received: by 2002:a17:903:1b24:b0:297:f35b:e214 with SMTP id d9443c01a7336-29b6c6ae346mr389857145ad.47.1764593846487; Mon, 01 Dec 2025 04:57:26 -0800 (PST) MIME-Version: 1.0 References: <20251129134350.487839-1-vsementsov@yandex-team.ru> <20251129134350.487839-4-vsementsov@yandex-team.ru> In-Reply-To: <20251129134350.487839-4-vsementsov@yandex-team.ru> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Mon, 1 Dec 2025 16:57:14 +0400 X-Gm-Features: AWmQ_bnn5FNz4sFMDITDa8iVlSizFoCH0I-5FMULrLgSIf6xJ3bFw12xBYye_T8 Message-ID: Subject: Re: [PATCH 3/8] chardev: .chr_open(): drop be_opened parameter To: Vladimir Sementsov-Ogievskiy Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, d-tatianin@yandex-team.ru, Samuel Thibault , =?UTF-8?B?QWxleCBCZW5uw6ll?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="00000000000064a3710644e385b3" Received-SPF: pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --00000000000064a3710644e385b3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Sat, Nov 29, 2025 at 5:44=E2=80=AFPM Vladimir Sementsov-Ogievskiy < vsementsov@yandex-team.ru> wrote: > The logic around the parameter is rather tricky. Let's instead > explicitly send CHR_EVENT_OPENED in all bakends where needed. > backends I like the general idea, I wonder if I miss something though > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > chardev/baum.c | 7 +++---- > chardev/char-console.c | 5 ++--- > chardev/char-file.c | 7 +++---- > chardev/char-hub.c | 11 +++++------ > chardev/char-mux.c | 19 +++++++++++-------- > chardev/char-null.c | 7 ++----- > chardev/char-parallel.c | 15 ++++----------- > chardev/char-pipe.c | 14 ++++++-------- > chardev/char-pty.c | 6 +----- > chardev/char-ringbuf.c | 3 ++- > chardev/char-serial.c | 18 +++++++++--------- > chardev/char-socket.c | 10 +++------- > chardev/char-stdio.c | 7 +++---- > chardev/char-udp.c | 6 +----- > chardev/char-win-stdio.c | 2 +- > chardev/char.c | 11 +++-------- > chardev/msmouse.c | 4 ++-- > chardev/spice.c | 13 ++++--------- > chardev/wctablet.c | 5 ++--- > gdbstub/system.c | 5 ++--- > include/chardev/char.h | 3 +-- > ui/console-vc.c | 7 ++----- > ui/dbus-chardev.c | 6 ++---- > ui/gtk.c | 9 +++------ > ui/spice-app.c | 10 +++------- > ui/vdagent.c | 3 +-- > 26 files changed, 81 insertions(+), 132 deletions(-) > > diff --git a/chardev/baum.c b/chardev/baum.c > index 6b81c97d10..58b74dc98d 100644 > --- a/chardev/baum.c > +++ b/chardev/baum.c > @@ -642,10 +642,7 @@ static void char_braille_finalize(Object *obj) > } > } > > -static void baum_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void baum_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > BaumChardev *baum =3D BAUM_CHARDEV(chr); > brlapi_handle_t *handle; > @@ -670,6 +667,8 @@ static void baum_chr_open(Chardev *chr, > * as an integer, but in practice it seems to work > */ > qemu_set_fd_handler(baum->brlapi_fd, baum_chr_read, NULL, baum); > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > static void char_braille_class_init(ObjectClass *oc, const void *data) > diff --git a/chardev/char-console.c b/chardev/char-console.c > index f3ef1a7748..423f0f4cc4 100644 > --- a/chardev/char-console.c > +++ b/chardev/char-console.c > @@ -26,12 +26,11 @@ > #include "chardev/char-win.h" > #include "qemu/module.h" > > -static void console_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > +static void console_chr_open(Chardev *chr, ChardevBackend *backend, > Error **errp) > { > win_chr_set_file(chr, GetStdHandle(STD_OUTPUT_HANDLE), true); > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > static void char_console_class_init(ObjectClass *oc, const void *data) > diff --git a/chardev/char-file.c b/chardev/char-file.c > index 568600bb7c..34ef386abc 100644 > --- a/chardev/char-file.c > +++ b/chardev/char-file.c > @@ -34,10 +34,7 @@ > #include "chardev/char-fd.h" > #endif > > -static void file_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void file_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevFile *file =3D backend->u.file.data; > #ifdef _WIN32 > @@ -100,6 +97,8 @@ static void file_chr_open(Chardev *chr, > return; > } > #endif > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > static void file_chr_parse(QemuOpts *opts, ChardevBackend *backend, > diff --git a/chardev/char-hub.c b/chardev/char-hub.c > index 11556dfa72..aa6058c2f6 100644 > --- a/chardev/char-hub.c > +++ b/chardev/char-hub.c > @@ -203,10 +203,7 @@ static void hub_chr_update_read_handlers(Chardev *ch= r) > } > } > > -static void hub_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void hub_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevHub *hub =3D backend->u.hub.data; > HubChardev *d =3D HUB_CHARDEV(chr); > @@ -241,8 +238,10 @@ static void hub_chr_open(Chardev *chr, > list =3D list->next; > } > > - /* Closed until an explicit event from backend */ > - *be_opened =3D false; > + /* > + * Closed until an explicit event from backend, so we don't > + * send CHR_EVENT_OPENED now. > + */ > } > > static void hub_chr_parse(QemuOpts *opts, ChardevBackend *backend, Error > **errp) > diff --git a/chardev/char-mux.c b/chardev/char-mux.c > index f38d66b21f..7210df431f 100644 > --- a/chardev/char-mux.c > +++ b/chardev/char-mux.c > @@ -361,10 +361,7 @@ void mux_set_focus(Chardev *chr, unsigned int focus) > mux_chr_send_event(d, d->focus, CHR_EVENT_MUX_IN); > } > > -static void mux_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void mux_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevMux *mux =3D backend->u.mux.data; > Chardev *drv; > @@ -377,11 +374,17 @@ static void mux_chr_open(Chardev *chr, > } > > d->focus =3D -1; > - /* only default to opened state if we've realized the initial > - * set of muxes > + if (!qemu_chr_fe_init(&d->chr, drv, errp)) { > + return; > + } > + > + /* > + * Only move to opened state if we've realized > + * the initial set of muxes: > */ > - *be_opened =3D muxes_opened; > - qemu_chr_fe_init(&d->chr, drv, errp); > + if (muxes_opened) { > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > + } > } > > static void mux_chr_parse(QemuOpts *opts, ChardevBackend *backend, Error > **errp) > diff --git a/chardev/char-null.c b/chardev/char-null.c > index 674603b380..900b5febb6 100644 > --- a/chardev/char-null.c > +++ b/chardev/char-null.c > @@ -26,12 +26,9 @@ > #include "chardev/char.h" > #include "qemu/module.h" > > -static void null_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void null_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > - *be_opened =3D false; > + /* do not send CHR_EVENT_OPENED */ > } > > static void char_null_class_init(ObjectClass *oc, const void *data) > diff --git a/chardev/char-parallel.c b/chardev/char-parallel.c > index 1be1ef4629..359efa3c9c 100644 > --- a/chardev/char-parallel.c > +++ b/chardev/char-parallel.c > @@ -157,10 +157,7 @@ static int parallel_chr_ioctl(Chardev *chr, int cmd, > void *arg) > return 0; > } > > -static void parallel_chr_open_fd(Chardev *chr, > - int fd, > - bool *be_opened, > - Error **errp) > +static void parallel_chr_open_fd(Chardev *chr, int fd, Error **errp) > { > ParallelChardev *drv =3D PARALLEL_CHARDEV(chr); > > @@ -172,6 +169,7 @@ static void parallel_chr_open_fd(Chardev *chr, > } > > drv->mode =3D IEEE1284_MODE_COMPAT; > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > #endif /* __linux__ */ > > @@ -227,21 +225,16 @@ static int parallel_chr_ioctl(Chardev *chr, int cmd= , > void *arg) > return 0; > } > > -static void parallel_chr_open_fd(Chardev *chr, > - int fd, > - bool *be_opened, > - Error **errp) > +static void parallel_chr_open_fd(Chardev *chr, int fd, Error **errp) > { > ParallelChardev *drv =3D PARALLEL_CHARDEV(chr); > drv->fd =3D fd; > - *be_opened =3D false; > } > #endif > > #ifdef HAVE_CHARDEV_PARALLEL > static void parallel_chr_open(Chardev *chr, > ChardevBackend *backend, > - bool *be_opened, > Error **errp) > { > ChardevHostdev *parallel =3D backend->u.parallel.data; > @@ -251,7 +244,7 @@ static void parallel_chr_open(Chardev *chr, > if (fd < 0) { > return; > } > - parallel_chr_open_fd(chr, fd, be_opened, errp); > + parallel_chr_open_fd(chr, fd, errp); > } > > static void parallel_chr_parse(QemuOpts *opts, ChardevBackend *backend, > diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c > index e84492d42b..2f26372dfc 100644 > --- a/chardev/char-pipe.c > +++ b/chardev/char-pipe.c > @@ -103,10 +103,7 @@ static int win_chr_pipe_init(Chardev *chr, const cha= r > *filename, > return -1; > } > > -static void pipe_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void pipe_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevHostdev *opts =3D backend->u.pipe.data; > const char *filename =3D opts->device; > @@ -114,14 +111,13 @@ static void pipe_chr_open(Chardev *chr, > if (win_chr_pipe_init(chr, filename, errp) < 0) { > return; > } > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > #else > > -static void pipe_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void pipe_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevHostdev *opts =3D backend->u.pipe.data; > int fd_in, fd_out; > @@ -158,6 +154,8 @@ static void pipe_chr_open(Chardev *chr, > } > return; > } > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > #endif /* !_WIN32 */ > diff --git a/chardev/char-pty.c b/chardev/char-pty.c > index 909ab01f5f..d4d69a29a9 100644 > --- a/chardev/char-pty.c > +++ b/chardev/char-pty.c > @@ -331,10 +331,7 @@ static int qemu_openpty_raw(int *aslave, char > *pty_name) > return amaster; > } > > -static void pty_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void pty_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > PtyChardev *s; > int master_fd, slave_fd; > @@ -364,7 +361,6 @@ static void pty_chr_open(Chardev *chr, > qio_channel_set_name(s->ioc, name); > g_free(name); > s->timer_src =3D NULL; > - *be_opened =3D false; > > /* create symbolic link */ > if (path) { > diff --git a/chardev/char-ringbuf.c b/chardev/char-ringbuf.c > index 19652fe2b3..30b17a96d3 100644 > --- a/chardev/char-ringbuf.c > +++ b/chardev/char-ringbuf.c > @@ -94,7 +94,6 @@ static void char_ringbuf_finalize(Object *obj) > > static void ringbuf_chr_open(Chardev *chr, > ChardevBackend *backend, > - bool *be_opened, > Error **errp) > { > ChardevRingbuf *opts =3D backend->u.ringbuf.data; > @@ -111,6 +110,8 @@ static void ringbuf_chr_open(Chardev *chr, > d->prod =3D 0; > d->cons =3D 0; > d->cbuf =3D g_malloc0(d->size); > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > void qmp_ringbuf_write(const char *device, const char *data, > diff --git a/chardev/char-serial.c b/chardev/char-serial.c > index 54c2b3935c..9995f18425 100644 > --- a/chardev/char-serial.c > +++ b/chardev/char-serial.c > @@ -41,14 +41,15 @@ > > #ifdef _WIN32 > > -static void serial_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void serial_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevHostdev *serial =3D backend->u.serial.data; > + int ret =3D win_chr_serial_init(chr, serial->device, errp); > + if (ret < 0) { > + return; > + } > > - win_chr_serial_init(chr, serial->device, errp); > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) > \ > @@ -258,10 +259,7 @@ static int serial_chr_ioctl(Chardev *chr, int cmd, > void *arg) > return 0; > } > > -static void serial_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void serial_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevHostdev *serial =3D backend->u.serial.data; > int fd; > @@ -281,6 +279,8 @@ static void serial_chr_open(Chardev *chr, > close(fd); > return; > } > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > #endif /* __linux__ || __sun__ */ > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index 329cd9f0a8..3f57ef4016 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -1365,10 +1365,7 @@ static bool > qmp_chardev_validate_socket(ChardevSocket *sock, > } > > > -static void tcp_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void tcp_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > SocketChardev *s =3D SOCKET_CHARDEV(chr); > ChardevSocket *sock =3D backend->u.socket.data; > @@ -1439,9 +1436,6 @@ static void tcp_chr_open(Chardev *chr, > } > s->registered_yank =3D true; > > - /* be isn't opened until we get a connection */ > - *be_opened =3D false; > - > update_disconnected_filename(s); > > if (s->is_listen) { > @@ -1454,6 +1448,8 @@ static void tcp_chr_open(Chardev *chr, > return; > } > } > + > + /* be isn't opened until we get a connection */ > } > > static void tcp_chr_parse(QemuOpts *opts, ChardevBackend *backend, Error > **errp) > diff --git a/chardev/char-stdio.c b/chardev/char-stdio.c > index f0920a23fa..534f6ed565 100644 > --- a/chardev/char-stdio.c > +++ b/chardev/char-stdio.c > @@ -85,10 +85,7 @@ static void term_stdio_handler(int sig) > stdio_chr_set_echo(NULL, stdio_echo_state); > } > > -static void stdio_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void stdio_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevStdio *opts =3D backend->u.stdio.data; > struct sigaction act; > @@ -123,6 +120,8 @@ static void stdio_chr_open(Chardev *chr, > > stdio_allow_signal =3D !opts->has_signal || opts->signal; > stdio_chr_set_echo(chr, false); > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > #endif > > diff --git a/chardev/char-udp.c b/chardev/char-udp.c > index 099f76b8c2..b835a967e1 100644 > --- a/chardev/char-udp.c > +++ b/chardev/char-udp.c > @@ -188,10 +188,7 @@ static void udp_chr_parse(QemuOpts *opts, > ChardevBackend *backend, Error **errp) > } > } > > -static void upd_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void upd_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevUdp *udp =3D backend->u.udp.data; > SocketAddress *local_addr =3D socket_address_flatten(udp->local); > @@ -215,7 +212,6 @@ static void upd_chr_open(Chardev *chr, > > s->ioc =3D QIO_CHANNEL(sioc); > /* be isn't opened until we get a connection */ > - *be_opened =3D false; > } > > static void char_udp_class_init(ObjectClass *oc, const void *data) > diff --git a/chardev/char-win-stdio.c b/chardev/char-win-stdio.c > index 866f3a2039..0535960ff1 100644 > --- a/chardev/char-win-stdio.c > +++ b/chardev/char-win-stdio.c > @@ -144,7 +144,6 @@ static void win_stiod_chr_set_echo(Chardev *chr, bool > echo) > > static void win_stdio_chr_open(Chardev *chr, > ChardevBackend *backend, > - bool *be_opened, > Error **errp) > { > ChardevStdio *opts =3D backend->u.stdio.data; > @@ -208,6 +207,7 @@ static void win_stdio_chr_open(Chardev *chr, > > win_stiod_chr_set_echo(chr, false); > > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > return; > > err3: > diff --git a/chardev/char.c b/chardev/char.c > index df37d1df16..44bfed3627 100644 > --- a/chardev/char.c > +++ b/chardev/char.c > @@ -246,8 +246,7 @@ int qemu_chr_add_client(Chardev *s, int fd) > CHARDEV_GET_CLASS(s)->chr_add_client(s, fd) : -1; > } > > -static void qemu_char_open(Chardev *chr, ChardevBackend *backend, > - bool *be_opened, Error **errp) > +static void qemu_char_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevClass *cc =3D CHARDEV_GET_CLASS(chr); > /* Any ChardevCommon member would work */ > @@ -268,7 +267,7 @@ static void qemu_char_open(Chardev *chr, > ChardevBackend *backend, > } > > if (cc->chr_open) { > - cc->chr_open(chr, backend, be_opened, errp); > + cc->chr_open(chr, backend, errp); > } > } > > @@ -1009,7 +1008,6 @@ static Chardev *chardev_new(const char *id, const > char *typename, > Object *obj; > Chardev *chr =3D NULL; > Error *local_err =3D NULL; > - bool be_opened =3D true; > > assert(g_str_has_prefix(typename, "chardev-")); > assert(id); > @@ -1020,7 +1018,7 @@ static Chardev *chardev_new(const char *id, const > char *typename, > chr->label =3D g_strdup(id); > chr->gcontext =3D gcontext; > > - qemu_char_open(chr, backend, &be_opened, &local_err); > + qemu_char_open(chr, backend, &local_err); > if (local_err) { > error_propagate(errp, local_err); > object_unref(obj); > @@ -1030,9 +1028,6 @@ static Chardev *chardev_new(const char *id, const > char *typename, > if (!chr->filename) { > chr->filename =3D g_strdup(typename + 8); > } > - if (be_opened) { > - qemu_chr_be_event(chr, CHR_EVENT_OPENED); > - } > > return chr; > } > diff --git a/chardev/msmouse.c b/chardev/msmouse.c > index d07cd998cb..9dc04e3b3e 100644 > --- a/chardev/msmouse.c > +++ b/chardev/msmouse.c > @@ -255,16 +255,16 @@ static void char_msmouse_finalize(Object *obj) > > static void msmouse_chr_open(Chardev *chr, > ChardevBackend *backend, > - bool *be_opened, > Error **errp) > { > MouseChardev *mouse =3D MOUSE_CHARDEV(chr); > > - *be_opened =3D false; > mouse->hs =3D qemu_input_handler_register((DeviceState *)mouse, > &msmouse_handler); > mouse->tiocm =3D 0; > fifo8_create(&mouse->outbuf, MSMOUSE_BUF_SZ); > + > + /* Never send CHR_EVENT_OPENED */ > } > > static void char_msmouse_class_init(ObjectClass *oc, const void *data) > diff --git a/chardev/spice.c b/chardev/spice.c > index 800784da26..612f358885 100644 > --- a/chardev/spice.c > +++ b/chardev/spice.c > @@ -251,9 +251,7 @@ static void chr_open(Chardev *chr, const char *subtyp= e) > s->sin.subtype =3D g_strdup(subtype); > } > > -static void spice_vmc_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > +static void spice_vmc_chr_open(Chardev *chr, ChardevBackend *backend, > Error **errp) > { > ChardevSpiceChannel *spicevmc =3D backend->u.spicevmc.data; > @@ -277,19 +275,17 @@ static void spice_vmc_chr_open(Chardev *chr, > return; > } > > - *be_opened =3D false; > #if SPICE_SERVER_VERSION < 0x000e02 > /* Spice < 0.14.2 doesn't explicitly open smartcard chardev */ > if (strcmp(type, "smartcard") =3D=3D 0) { > - *be_opened =3D true; > + chr_open(chr, type); > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > #endi Can you add a preliminary patch to drop support for spice < 0.15 ? According to repology: debian_13: 0.15.2 fedora_42: 0.15.1 opensuse_leap_15_4: 0.15.0 ubuntu_22_04: 0.15.0 > f > chr_open(chr, type); > } > > -static void spice_port_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > +static void spice_port_chr_open(Chardev *chr, ChardevBackend *backend, > Error **errp) > { > ChardevSpicePort *spiceport =3D backend->u.spiceport.data; > @@ -308,7 +304,6 @@ static void spice_port_chr_open(Chardev *chr, > > chr_open(chr, "port"); > > - *be_opened =3D false; > s =3D SPICE_CHARDEV(chr); > s->sin.portname =3D g_strdup(name); > > diff --git a/chardev/wctablet.c b/chardev/wctablet.c > index 8285a56e7b..65b2ceb58c 100644 > --- a/chardev/wctablet.c > +++ b/chardev/wctablet.c > @@ -326,13 +326,10 @@ static void wctablet_chr_finalize(Object *obj) > > static void wctablet_chr_open(Chardev *chr, > ChardevBackend *backend, > - bool *be_opened, > Error **errp) > { > TabletChardev *tablet =3D WCTABLET_CHARDEV(chr); > > - *be_opened =3D true; > - > /* init state machine */ > memcpy(tablet->outbuf, WC_FULL_CONFIG_STRING, > WC_FULL_CONFIG_STRING_LENGTH); > tablet->outlen =3D WC_FULL_CONFIG_STRING_LENGTH; > @@ -340,6 +337,8 @@ static void wctablet_chr_open(Chardev *chr, > > tablet->hs =3D qemu_input_handler_register((DeviceState *)tablet, > &wctablet_handler); > + > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > static void wctablet_chr_class_init(ObjectClass *oc, const void *data) > diff --git a/gdbstub/system.c b/gdbstub/system.c > index 61b2b4b8da..49da1f73cc 100644 > --- a/gdbstub/system.c > +++ b/gdbstub/system.c > @@ -233,10 +233,9 @@ static int gdb_chr_write(Chardev *chr, const uint8_t > *buf, int len) > return len; > } > > -static void gdb_chr_open(Chardev *chr, ChardevBackend *backend, > - bool *be_opened, Error **errp) > +static void gdb_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > - *be_opened =3D false; > + /* Never send CHR_EVENT_OPENED */ > } > > static void char_gdb_class_init(ObjectClass *oc, const void *data) > diff --git a/include/chardev/char.h b/include/chardev/char.h > index 2baf2a8a1a..47c75c3582 100644 > --- a/include/chardev/char.h > +++ b/include/chardev/char.h > @@ -260,8 +260,7 @@ struct ChardevClass { > void (*chr_parse)(QemuOpts *opts, ChardevBackend *backend, Error > **errp); > > /* called after construction, open/starts the backend */ > - void (*chr_open)(Chardev *chr, ChardevBackend *backend, > - bool *be_opened, Error **errp); > + void (*chr_open)(Chardev *chr, ChardevBackend *backend, Error **errp= ); > > /* write buf to the backend */ > int (*chr_write)(Chardev *s, const uint8_t *buf, int len); > diff --git a/ui/console-vc.c b/ui/console-vc.c > index 931068d43a..4c8ea4c148 100644 > --- a/ui/console-vc.c > +++ b/ui/console-vc.c > @@ -1093,10 +1093,7 @@ void qemu_text_console_update_size(QemuTextConsole > *c) > dpy_text_resize(QEMU_CONSOLE(c), c->width, c->height); > } > > -static void vc_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void vc_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ChardevVC *vc =3D backend->u.vc.data; > VCChardev *drv =3D VC_CHARDEV(chr); > @@ -1144,7 +1141,7 @@ static void vc_chr_open(Chardev *chr, > drv->t_attrib =3D TEXT_ATTRIBUTES_DEFAULT; > } > > - *be_opened =3D true; > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > static void vc_chr_parse(QemuOpts *opts, ChardevBackend *backend, Error > **errp) > diff --git a/ui/dbus-chardev.c b/ui/dbus-chardev.c > index f6c426e220..3e471f84cd 100644 > --- a/ui/dbus-chardev.c > +++ b/ui/dbus-chardev.c > @@ -176,9 +176,7 @@ dbus_chr_send_break( > return DBUS_METHOD_INVOCATION_HANDLED; > } > > -static void > -dbus_chr_open(Chardev *chr, ChardevBackend *backend, > - bool *be_opened, Error **errp) > +static void dbus_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > ERRP_GUARD(); > > @@ -211,7 +209,7 @@ dbus_chr_open(Chardev *chr, ChardevBackend *backend, > return; > } > CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_SOCKET))->chr_open( > - chr, be, be_opened, errp); > + chr, be, errp); > } > > static void > diff --git a/ui/gtk.c b/ui/gtk.c > index b5498a7ce3..3eeb5baa11 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -1963,10 +1963,7 @@ static void gd_vc_chr_set_echo(Chardev *chr, bool > echo) > > static int nb_vcs; > static Chardev *vcs[MAX_VCS]; > -static void gd_vc_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void gd_vc_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > if (nb_vcs =3D=3D MAX_VCS) { > error_setg(errp, "Maximum number of consoles reached"); > @@ -1975,10 +1972,10 @@ static void gd_vc_chr_open(Chardev *chr, > > vcs[nb_vcs++] =3D chr; > > - /* console/chardev init sometimes completes elsewhere in a 2nd > + /* > + * console/chardev init sometimes completes elsewhere in a 2nd > * stage, so defer OPENED events until they are fully initialized > */ > - *be_opened =3D false; > } > > static void char_gd_vc_class_init(ObjectClass *oc, const void *data) > diff --git a/ui/spice-app.c b/ui/spice-app.c > index ea0b62a22b..7ac9ae4e78 100644 > --- a/ui/spice-app.c > +++ b/ui/spice-app.c > @@ -49,8 +49,7 @@ struct VCChardev { > > struct VCChardevClass { > ChardevClass parent; > - void (*parent_open)(Chardev *chr, ChardevBackend *backend, > - bool *be_opened, Error **errp); > + void (*parent_open)(Chardev *chr, ChardevBackend *backend, Error > **errp); > }; > > #define TYPE_CHARDEV_VC "chardev-vc" > @@ -67,10 +66,7 @@ chr_spice_backend_new(void) > return be; > } > > -static void vc_chr_open(Chardev *chr, > - ChardevBackend *backend, > - bool *be_opened, > - Error **errp) > +static void vc_chr_open(Chardev *chr, ChardevBackend *backend, Error > **errp) > { > VCChardevClass *vc =3D CHARDEV_VC_GET_CLASS(chr); > ChardevBackend *be; > @@ -87,7 +83,7 @@ static void vc_chr_open(Chardev *chr, > be =3D chr_spice_backend_new(); > be->u.spiceport.data->fqdn =3D fqdn ? > g_strdup(fqdn) : g_strdup_printf("org.qemu.console.%s", > chr->label); > - vc->parent_open(chr, be, be_opened, errp); > + vc->parent_open(chr, be, errp); > qapi_free_ChardevBackend(be); > } > > diff --git a/ui/vdagent.c b/ui/vdagent.c > index 9972a9c476..3becc6c076 100644 > --- a/ui/vdagent.c > +++ b/ui/vdagent.c > @@ -662,7 +662,6 @@ static void vdagent_chr_recv_clipboard(VDAgentChardev > *vd, VDAgentMessage *msg) > > static void vdagent_chr_open(Chardev *chr, > ChardevBackend *backend, > - bool *be_opened, > Error **errp) > { > VDAgentChardev *vd =3D QEMU_VDAGENT_CHARDEV(chr); > @@ -692,7 +691,7 @@ static void vdagent_chr_open(Chardev *chr, > > &vdagent_mouse_handler); > } > > - *be_opened =3D true; > + qemu_chr_be_event(chr, CHR_EVENT_OPENED); > } > > static void vdagent_clipboard_peer_register(VDAgentChardev *vd) > -- > 2.48.1 > > --00000000000064a3710644e385b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Sat, Nov 29, 2= 025 at 5:44=E2=80=AFPM Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
The logic around the par= ameter is rather tricky. Let's instead
explicitly send CHR_EVENT_OPENED in all bakends where needed.

backends

I like the general= idea, I wonder if I miss something though
=C2=A0

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
=C2=A0chardev/baum.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 7 +++-= ---
=C2=A0chardev/char-console.c=C2=A0 =C2=A0|=C2=A0 5 ++---
=C2=A0chardev/char-file.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 7 +++----
=C2=A0chardev/char-hub.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 +++++------
=C2=A0chardev/char-mux.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 19 +++++++++++--------=
=C2=A0chardev/char-null.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 7 ++-----
=C2=A0chardev/char-parallel.c=C2=A0 | 15 ++++-----------
=C2=A0chardev/char-pipe.c=C2=A0 =C2=A0 =C2=A0 | 14 ++++++--------
=C2=A0chardev/char-pty.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +-----
=C2=A0chardev/char-ringbuf.c=C2=A0 =C2=A0|=C2=A0 3 ++-
=C2=A0chardev/char-serial.c=C2=A0 =C2=A0 | 18 +++++++++---------
=C2=A0chardev/char-socket.c=C2=A0 =C2=A0 | 10 +++-------
=C2=A0chardev/char-stdio.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 7 +++----
=C2=A0chardev/char-udp.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +-----
=C2=A0chardev/char-win-stdio.c |=C2=A0 2 +-
=C2=A0chardev/char.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 +++------= --
=C2=A0chardev/msmouse.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 4 ++--
=C2=A0chardev/spice.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 13 ++++---------<= br> =C2=A0chardev/wctablet.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 ++---
=C2=A0gdbstub/system.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 ++---
=C2=A0include/chardev/char.h=C2=A0 =C2=A0|=C2=A0 3 +--
=C2=A0ui/console-vc.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 7 ++----- =C2=A0ui/dbus-chardev.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 6 ++----
=C2=A0ui/gtk.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 9 +++------
=C2=A0ui/spice-app.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 10 +++------= -
=C2=A0ui/vdagent.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 3= +--
=C2=A026 files changed, 81 insertions(+), 132 deletions(-)

diff --git a/chardev/baum.c b/chardev/baum.c
index 6b81c97d10..58b74dc98d 100644
--- a/chardev/baum.c
+++ b/chardev/baum.c
@@ -642,10 +642,7 @@ static void char_braille_finalize(Object *obj)
=C2=A0 =C2=A0 =C2=A0}
=C2=A0}

-static void baum_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Error **errp)
+static void baum_chr_open(Chardev *chr, ChardevBackend *backend, Error **e= rrp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0BaumChardev *baum =3D BAUM_CHARDEV(chr);
=C2=A0 =C2=A0 =C2=A0brlapi_handle_t *handle;
@@ -670,6 +667,8 @@ static void baum_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 * as an integer, but in practice it seems to work
=C2=A0 =C2=A0 =C2=A0 */
=C2=A0 =C2=A0 =C2=A0qemu_set_fd_handler(baum->brlapi_fd, baum_chr_read, = NULL, baum);
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0static void char_braille_class_init(ObjectClass *oc, const void *data= )
diff --git a/chardev/char-console.c b/chardev/char-console.c
index f3ef1a7748..423f0f4cc4 100644
--- a/chardev/char-console.c
+++ b/chardev/char-console.c
@@ -26,12 +26,11 @@
=C2=A0#include "chardev/char-win.h"
=C2=A0#include "qemu/module.h"

-static void console_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
+static void console_chr_open(Chardev *chr, ChardevBackend *backend,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0win_chr_set_file(chr, GetStdHandle(STD_OUTPUT_HANDLE), = true);
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0static void char_console_class_init(ObjectClass *oc, const void *data= )
diff --git a/chardev/char-file.c b/chardev/char-file.c
index 568600bb7c..34ef386abc 100644
--- a/chardev/char-file.c
+++ b/chardev/char-file.c
@@ -34,10 +34,7 @@
=C2=A0#include "chardev/char-fd.h"
=C2=A0#endif

-static void file_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Error **errp)
+static void file_chr_open(Chardev *chr, ChardevBackend *backend, Error **e= rrp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevFile *file =3D backend->u.file.data;
=C2=A0#ifdef _WIN32
@@ -100,6 +97,8 @@ static void file_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}
=C2=A0#endif
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0static void file_chr_parse(QemuOpts *opts, ChardevBackend *backend, diff --git a/chardev/char-hub.c b/chardev/char-hub.c
index 11556dfa72..aa6058c2f6 100644
--- a/chardev/char-hub.c
+++ b/chardev/char-hub.c
@@ -203,10 +203,7 @@ static void hub_chr_update_read_handlers(Chardev *chr)=
=C2=A0 =C2=A0 =C2=A0}
=C2=A0}

-static void hub_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Error **errp)
+static void hub_chr_open(Chardev *chr, ChardevBackend *backend, Error **er= rp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevHub *hub =3D backend->u.hub.data;
=C2=A0 =C2=A0 =C2=A0HubChardev *d =3D HUB_CHARDEV(chr);
@@ -241,8 +238,10 @@ static void hub_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0list =3D list->next;
=C2=A0 =C2=A0 =C2=A0}

-=C2=A0 =C2=A0 /* Closed until an explicit event from backend */
-=C2=A0 =C2=A0 *be_opened =3D false;
+=C2=A0 =C2=A0 /*
+=C2=A0 =C2=A0 =C2=A0* Closed until an explicit event from backend, so we d= on't
+=C2=A0 =C2=A0 =C2=A0* send CHR_EVENT_OPENED now.
+=C2=A0 =C2=A0 =C2=A0*/
=C2=A0}

=C2=A0static void hub_chr_parse(QemuOpts *opts, ChardevBackend *backend, Er= ror **errp)
diff --git a/chardev/char-mux.c b/chardev/char-mux.c
index f38d66b21f..7210df431f 100644
--- a/chardev/char-mux.c
+++ b/chardev/char-mux.c
@@ -361,10 +361,7 @@ void mux_set_focus(Chardev *chr, unsigned int focus) =C2=A0 =C2=A0 =C2=A0mux_chr_send_event(d, d->focus, CHR_EVENT_MUX_IN); =C2=A0}

-static void mux_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Error **errp)
+static void mux_chr_open(Chardev *chr, ChardevBackend *backend, Error **er= rp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevMux *mux =3D backend->u.mux.data;
=C2=A0 =C2=A0 =C2=A0Chardev *drv;
@@ -377,11 +374,17 @@ static void mux_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0}

=C2=A0 =C2=A0 =C2=A0d->focus =3D -1;
-=C2=A0 =C2=A0 /* only default to opened state if we've realized the in= itial
-=C2=A0 =C2=A0 =C2=A0* set of muxes
+=C2=A0 =C2=A0 if (!qemu_chr_fe_init(&d->chr, drv, errp)) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return;
+=C2=A0 =C2=A0 }
+
+=C2=A0 =C2=A0 /*
+=C2=A0 =C2=A0 =C2=A0* Only move to opened state if we've realized
+=C2=A0 =C2=A0 =C2=A0* the initial set of muxes:
=C2=A0 =C2=A0 =C2=A0 */
-=C2=A0 =C2=A0 *be_opened =3D muxes_opened;
-=C2=A0 =C2=A0 qemu_chr_fe_init(&d->chr, drv, errp);
+=C2=A0 =C2=A0 if (muxes_opened) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
+=C2=A0 =C2=A0 }
=C2=A0}

=C2=A0static void mux_chr_parse(QemuOpts *opts, ChardevBackend *backend, Er= ror **errp)
diff --git a/chardev/char-null.c b/chardev/char-null.c
index 674603b380..900b5febb6 100644
--- a/chardev/char-null.c
+++ b/chardev/char-null.c
@@ -26,12 +26,9 @@
=C2=A0#include "chardev/char.h"
=C2=A0#include "qemu/module.h"

-static void null_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Error **errp)
+static void null_chr_open(Chardev *chr, ChardevBackend *backend, Error **e= rrp)
=C2=A0{
-=C2=A0 =C2=A0 *be_opened =3D false;
+=C2=A0 =C2=A0 /* do not send CHR_EVENT_OPENED */
=C2=A0}

=C2=A0static void char_null_class_init(ObjectClass *oc, const void *data) diff --git a/chardev/char-parallel.c b/chardev/char-parallel.c
index 1be1ef4629..359efa3c9c 100644
--- a/chardev/char-parallel.c
+++ b/chardev/char-parallel.c
@@ -157,10 +157,7 @@ static int parallel_chr_ioctl(Chardev *chr, int cmd, v= oid *arg)
=C2=A0 =C2=A0 =C2=A0return 0;
=C2=A0}

-static void parallel_chr_open_fd(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 int fd,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
+static void parallel_chr_open_fd(Chardev *chr, int fd, Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ParallelChardev *drv =3D PARALLEL_CHARDEV(chr);

@@ -172,6 +169,7 @@ static void parallel_chr_open_fd(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0}

=C2=A0 =C2=A0 =C2=A0drv->mode =3D IEEE1284_MODE_COMPAT;
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}
=C2=A0#endif /* __linux__ */

@@ -227,21 +225,16 @@ static int parallel_chr_ioctl(Chardev *chr, int cmd, = void *arg)
=C2=A0 =C2=A0 =C2=A0return 0;
=C2=A0}

-static void parallel_chr_open_fd(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 int fd,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
+static void parallel_chr_open_fd(Chardev *chr, int fd, Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ParallelChardev *drv =3D PARALLEL_CHARDEV(chr);
=C2=A0 =C2=A0 =C2=A0drv->fd =3D fd;
-=C2=A0 =C2=A0 *be_opened =3D false;
=C2=A0}
=C2=A0#endif

=C2=A0#ifdef HAVE_CHARDEV_PARALLEL
=C2=A0static void parallel_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevHostdev *parallel =3D backend->u.parallel.dat= a;
@@ -251,7 +244,7 @@ static void parallel_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0if (fd < 0) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 parallel_chr_open_fd(chr, fd, be_opened, errp);
+=C2=A0 =C2=A0 parallel_chr_open_fd(chr, fd, errp);
=C2=A0}

=C2=A0static void parallel_chr_parse(QemuOpts *opts, ChardevBackend *backen= d,
diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c
index e84492d42b..2f26372dfc 100644
--- a/chardev/char-pipe.c
+++ b/chardev/char-pipe.c
@@ -103,10 +103,7 @@ static int win_chr_pipe_init(Chardev *chr, const char = *filename,
=C2=A0 =C2=A0 =C2=A0return -1;
=C2=A0}

-static void pipe_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Error **errp)
+static void pipe_chr_open(Chardev *chr, ChardevBackend *backend, Error **e= rrp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevHostdev *opts =3D backend->u.pipe.data;
=C2=A0 =C2=A0 =C2=A0const char *filename =3D opts->device;
@@ -114,14 +111,13 @@ static void pipe_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0if (win_chr_pipe_init(chr, filename, errp) < 0) { =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0#else

-static void pipe_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Error **errp)
+static void pipe_chr_open(Chardev *chr, ChardevBackend *backend, Error **e= rrp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevHostdev *opts =3D backend->u.pipe.data;
=C2=A0 =C2=A0 =C2=A0int fd_in, fd_out;
@@ -158,6 +154,8 @@ static void pipe_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0#endif /* !_WIN32 */
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index 909ab01f5f..d4d69a29a9 100644
--- a/chardev/char-pty.c
+++ b/chardev/char-pty.c
@@ -331,10 +331,7 @@ static int qemu_openpty_raw(int *aslave, char *pty_nam= e)
=C2=A0 =C2=A0 =C2=A0return amaster;
=C2=A0}

-static void pty_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Error **errp)
+static void pty_chr_open(Chardev *chr, ChardevBackend *backend, Error **er= rp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0PtyChardev *s;
=C2=A0 =C2=A0 =C2=A0int master_fd, slave_fd;
@@ -364,7 +361,6 @@ static void pty_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0qio_channel_set_name(s->ioc, name);
=C2=A0 =C2=A0 =C2=A0g_free(name);
=C2=A0 =C2=A0 =C2=A0s->timer_src =3D NULL;
-=C2=A0 =C2=A0 *be_opened =3D false;

=C2=A0 =C2=A0 =C2=A0/* create symbolic link */
=C2=A0 =C2=A0 =C2=A0if (path) {
diff --git a/chardev/char-ringbuf.c b/chardev/char-ringbuf.c
index 19652fe2b3..30b17a96d3 100644
--- a/chardev/char-ringbuf.c
+++ b/chardev/char-ringbuf.c
@@ -94,7 +94,6 @@ static void char_ringbuf_finalize(Object *obj)

=C2=A0static void ringbuf_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevRingbuf *opts =3D backend->u.ringbuf.data; @@ -111,6 +110,8 @@ static void ringbuf_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0d->prod =3D 0;
=C2=A0 =C2=A0 =C2=A0d->cons =3D 0;
=C2=A0 =C2=A0 =C2=A0d->cbuf =3D g_malloc0(d->size);
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0void qmp_ringbuf_write(const char *device, const char *data,
diff --git a/chardev/char-serial.c b/chardev/char-serial.c
index 54c2b3935c..9995f18425 100644
--- a/chardev/char-serial.c
+++ b/chardev/char-serial.c
@@ -41,14 +41,15 @@

=C2=A0#ifdef _WIN32

-static void serial_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
+static void serial_chr_open(Chardev *chr, ChardevBackend *backend, Error *= *errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevHostdev *serial =3D backend->u.serial.data; +=C2=A0 =C2=A0 int ret =3D win_chr_serial_init(chr, serial->device, errp= );
+=C2=A0 =C2=A0 if (ret < 0) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return;
+=C2=A0 =C2=A0 }

-=C2=A0 =C2=A0 win_chr_serial_init(chr, serial->device, errp);
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0#elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__)= =C2=A0 =C2=A0 =C2=A0 \
@@ -258,10 +259,7 @@ static int serial_chr_ioctl(Chardev *chr, int cmd, voi= d *arg)
=C2=A0 =C2=A0 =C2=A0return 0;
=C2=A0}

-static void serial_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
+static void serial_chr_open(Chardev *chr, ChardevBackend *backend, Error *= *errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevHostdev *serial =3D backend->u.serial.data; =C2=A0 =C2=A0 =C2=A0int fd;
@@ -281,6 +279,8 @@ static void serial_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0close(fd);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}
=C2=A0#endif /* __linux__ || __sun__ */

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 329cd9f0a8..3f57ef4016 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -1365,10 +1365,7 @@ static bool qmp_chardev_validate_socket(ChardevSocke= t *sock,
=C2=A0}


-static void tcp_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Error **errp)
+static void tcp_chr_open(Chardev *chr, ChardevBackend *backend, Error **er= rp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0SocketChardev *s =3D SOCKET_CHARDEV(chr);
=C2=A0 =C2=A0 =C2=A0ChardevSocket *sock =3D backend->u.socket.data;
@@ -1439,9 +1436,6 @@ static void tcp_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0s->registered_yank =3D true;

-=C2=A0 =C2=A0 /* be isn't opened until we get a connection */
-=C2=A0 =C2=A0 *be_opened =3D false;
-
=C2=A0 =C2=A0 =C2=A0update_disconnected_filename(s);

=C2=A0 =C2=A0 =C2=A0if (s->is_listen) {
@@ -1454,6 +1448,8 @@ static void tcp_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0}
+
+=C2=A0 =C2=A0 /* be isn't opened until we get a connection */
=C2=A0}

=C2=A0static void tcp_chr_parse(QemuOpts *opts, ChardevBackend *backend, Er= ror **errp)
diff --git a/chardev/char-stdio.c b/chardev/char-stdio.c
index f0920a23fa..534f6ed565 100644
--- a/chardev/char-stdio.c
+++ b/chardev/char-stdio.c
@@ -85,10 +85,7 @@ static void term_stdio_handler(int sig)
=C2=A0 =C2=A0 =C2=A0stdio_chr_set_echo(NULL, stdio_echo_state);
=C2=A0}

-static void stdio_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0Error **errp)
+static void stdio_chr_open(Chardev *chr, ChardevBackend *backend, Error **= errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevStdio *opts =3D backend->u.stdio.data;
=C2=A0 =C2=A0 =C2=A0struct sigaction act;
@@ -123,6 +120,8 @@ static void stdio_chr_open(Chardev *chr,

=C2=A0 =C2=A0 =C2=A0stdio_allow_signal =3D !opts->has_signal || opts->= ;signal;
=C2=A0 =C2=A0 =C2=A0stdio_chr_set_echo(chr, false);
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}
=C2=A0#endif

diff --git a/chardev/char-udp.c b/chardev/char-udp.c
index 099f76b8c2..b835a967e1 100644
--- a/chardev/char-udp.c
+++ b/chardev/char-udp.c
@@ -188,10 +188,7 @@ static void udp_chr_parse(QemuOpts *opts, ChardevBacke= nd *backend, Error **errp)
=C2=A0 =C2=A0 =C2=A0}
=C2=A0}

-static void upd_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Error **errp)
+static void upd_chr_open(Chardev *chr, ChardevBackend *backend, Error **er= rp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevUdp *udp =3D backend->u.udp.data;
=C2=A0 =C2=A0 =C2=A0SocketAddress *local_addr =3D socket_address_flatten(ud= p->local);
@@ -215,7 +212,6 @@ static void upd_chr_open(Chardev *chr,

=C2=A0 =C2=A0 =C2=A0s->ioc =3D QIO_CHANNEL(sioc);
=C2=A0 =C2=A0 =C2=A0/* be isn't opened until we get a connection */
-=C2=A0 =C2=A0 *be_opened =3D false;
=C2=A0}

=C2=A0static void char_udp_class_init(ObjectClass *oc, const void *data) diff --git a/chardev/char-win-stdio.c b/chardev/char-win-stdio.c
index 866f3a2039..0535960ff1 100644
--- a/chardev/char-win-stdio.c
+++ b/chardev/char-win-stdio.c
@@ -144,7 +144,6 @@ static void win_stiod_chr_set_echo(Chardev *chr, bool e= cho)

=C2=A0static void win_stdio_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevStdio *opts =3D backend->u.stdio.data;
@@ -208,6 +207,7 @@ static void win_stdio_chr_open(Chardev *chr,

=C2=A0 =C2=A0 =C2=A0win_stiod_chr_set_echo(chr, false);

+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0 =C2=A0 =C2=A0return;

=C2=A0err3:
diff --git a/chardev/char.c b/chardev/char.c
index df37d1df16..44bfed3627 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -246,8 +246,7 @@ int qemu_chr_add_client(Chardev *s, int fd)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CHARDEV_GET_CLASS(s)->chr_add_client(s= , fd) : -1;
=C2=A0}

-static void qemu_char_open(Chardev *chr, ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened, Error **errp)
+static void qemu_char_open(Chardev *chr, ChardevBackend *backend, Error **= errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevClass *cc =3D CHARDEV_GET_CLASS(chr);
=C2=A0 =C2=A0 =C2=A0/* Any ChardevCommon member would work */
@@ -268,7 +267,7 @@ static void qemu_char_open(Chardev *chr, ChardevBackend= *backend,
=C2=A0 =C2=A0 =C2=A0}

=C2=A0 =C2=A0 =C2=A0if (cc->chr_open) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 cc->chr_open(chr, backend, be_opened, errp)= ;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 cc->chr_open(chr, backend, errp);
=C2=A0 =C2=A0 =C2=A0}
=C2=A0}

@@ -1009,7 +1008,6 @@ static Chardev *chardev_new(const char *id, const cha= r *typename,
=C2=A0 =C2=A0 =C2=A0Object *obj;
=C2=A0 =C2=A0 =C2=A0Chardev *chr =3D NULL;
=C2=A0 =C2=A0 =C2=A0Error *local_err =3D NULL;
-=C2=A0 =C2=A0 bool be_opened =3D true;

=C2=A0 =C2=A0 =C2=A0assert(g_str_has_prefix(typename, "chardev-")= );
=C2=A0 =C2=A0 =C2=A0assert(id);
@@ -1020,7 +1018,7 @@ static Chardev *chardev_new(const char *id, const cha= r *typename,
=C2=A0 =C2=A0 =C2=A0chr->label =3D g_strdup(id);
=C2=A0 =C2=A0 =C2=A0chr->gcontext =3D gcontext;

-=C2=A0 =C2=A0 qemu_char_open(chr, backend, &be_opened, &local_err)= ;
+=C2=A0 =C2=A0 qemu_char_open(chr, backend, &local_err);
=C2=A0 =C2=A0 =C2=A0if (local_err) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error_propagate(errp, local_err);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0object_unref(obj);
@@ -1030,9 +1028,6 @@ static Chardev *chardev_new(const char *id, const cha= r *typename,
=C2=A0 =C2=A0 =C2=A0if (!chr->filename) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0chr->filename =3D g_strdup(typename + = 8);
=C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 if (be_opened) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
-=C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0return chr;
=C2=A0}
diff --git a/chardev/msmouse.c b/chardev/msmouse.c
index d07cd998cb..9dc04e3b3e 100644
--- a/chardev/msmouse.c
+++ b/chardev/msmouse.c
@@ -255,16 +255,16 @@ static void char_msmouse_finalize(Object *obj)

=C2=A0static void msmouse_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0MouseChardev *mouse =3D MOUSE_CHARDEV(chr);

-=C2=A0 =C2=A0 *be_opened =3D false;
=C2=A0 =C2=A0 =C2=A0mouse->hs =3D qemu_input_handler_register((DeviceSta= te *)mouse,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0&msmouse_handler);
=C2=A0 =C2=A0 =C2=A0mouse->tiocm =3D 0;
=C2=A0 =C2=A0 =C2=A0fifo8_create(&mouse->outbuf, MSMOUSE_BUF_SZ); +
+=C2=A0 =C2=A0 /* Never send CHR_EVENT_OPENED */
=C2=A0}

=C2=A0static void char_msmouse_class_init(ObjectClass *oc, const void *data= )
diff --git a/chardev/spice.c b/chardev/spice.c
index 800784da26..612f358885 100644
--- a/chardev/spice.c
+++ b/chardev/spice.c
@@ -251,9 +251,7 @@ static void chr_open(Chardev *chr, const char *subtype)=
=C2=A0 =C2=A0 =C2=A0s->sin.subtype =3D g_strdup(subtype);
=C2=A0}

-static void spice_vmc_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
+static void spice_vmc_chr_open(Chardev *chr, ChardevBackend *backend,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevSpiceChannel *spicevmc =3D backend->u.spicevm= c.data;
@@ -277,19 +275,17 @@ static void spice_vmc_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}

-=C2=A0 =C2=A0 *be_opened =3D false;
=C2=A0#if SPICE_SERVER_VERSION < 0x000e02
=C2=A0 =C2=A0 =C2=A0/* Spice < 0.14.2 doesn't explicitly open smartc= ard chardev */
=C2=A0 =C2=A0 =C2=A0if (strcmp(type, "smartcard") =3D=3D 0) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 *be_opened =3D true;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 chr_open(chr, type);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0 =C2=A0 =C2=A0}
=C2=A0#endi

Can you add a preliminary patch= to drop support for spice < 0.15 ?
According to repology:
debian_13: 0.15.2
fedora_42: 0.15.1
opensuse_leap_15_4: 0.15.0=
ubuntu_22_04: 0.15.0


=C2=A0
f
=C2=A0 =C2=A0 =C2=A0chr_open(chr, type);
=C2=A0}

-static void spice_port_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
+static void spice_port_chr_open(Chardev *chr, ChardevBackend *backend,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevSpicePort *spiceport =3D backend->u.spiceport= .data;
@@ -308,7 +304,6 @@ static void spice_port_chr_open(Chardev *chr,

=C2=A0 =C2=A0 =C2=A0chr_open(chr, "port");

-=C2=A0 =C2=A0 *be_opened =3D false;
=C2=A0 =C2=A0 =C2=A0s =3D SPICE_CHARDEV(chr);
=C2=A0 =C2=A0 =C2=A0s->sin.portname =3D g_strdup(name);

diff --git a/chardev/wctablet.c b/chardev/wctablet.c
index 8285a56e7b..65b2ceb58c 100644
--- a/chardev/wctablet.c
+++ b/chardev/wctablet.c
@@ -326,13 +326,10 @@ static void wctablet_chr_finalize(Object *obj)

=C2=A0static void wctablet_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0TabletChardev *tablet =3D WCTABLET_CHARDEV(chr);

-=C2=A0 =C2=A0 *be_opened =3D true;
-
=C2=A0 =C2=A0 =C2=A0/* init state machine */
=C2=A0 =C2=A0 =C2=A0memcpy(tablet->outbuf, WC_FULL_CONFIG_STRING, WC_FUL= L_CONFIG_STRING_LENGTH);
=C2=A0 =C2=A0 =C2=A0tablet->outlen =3D WC_FULL_CONFIG_STRING_LENGTH;
@@ -340,6 +337,8 @@ static void wctablet_chr_open(Chardev *chr,

=C2=A0 =C2=A0 =C2=A0tablet->hs =3D qemu_input_handler_register((DeviceSt= ate *)tablet,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 &wctablet_handler);
+
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0static void wctablet_chr_class_init(ObjectClass *oc, const void *data= )
diff --git a/gdbstub/system.c b/gdbstub/system.c
index 61b2b4b8da..49da1f73cc 100644
--- a/gdbstub/system.c
+++ b/gdbstub/system.c
@@ -233,10 +233,9 @@ static int gdb_chr_write(Chardev *chr, const uint8_t *= buf, int len)
=C2=A0 =C2=A0 =C2=A0return len;
=C2=A0}

-static void gdb_chr_open(Chardev *chr, ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened, Error **errp)
+static void gdb_chr_open(Chardev *chr, ChardevBackend *backend, Error **er= rp)
=C2=A0{
-=C2=A0 =C2=A0 *be_opened =3D false;
+=C2=A0 =C2=A0 /* Never send CHR_EVENT_OPENED */
=C2=A0}

=C2=A0static void char_gdb_class_init(ObjectClass *oc, const void *data) diff --git a/include/chardev/char.h b/include/chardev/char.h
index 2baf2a8a1a..47c75c3582 100644
--- a/include/chardev/char.h
+++ b/include/chardev/char.h
@@ -260,8 +260,7 @@ struct ChardevClass {
=C2=A0 =C2=A0 =C2=A0void (*chr_parse)(QemuOpts *opts, ChardevBackend *backe= nd, Error **errp);

=C2=A0 =C2=A0 =C2=A0/* called after construction, open/starts the backend *= /
-=C2=A0 =C2=A0 void (*chr_open)(Chardev *chr, ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_ope= ned, Error **errp);
+=C2=A0 =C2=A0 void (*chr_open)(Chardev *chr, ChardevBackend *backend, Erro= r **errp);

=C2=A0 =C2=A0 =C2=A0/* write buf to the backend */
=C2=A0 =C2=A0 =C2=A0int (*chr_write)(Chardev *s, const uint8_t *buf, int le= n);
diff --git a/ui/console-vc.c b/ui/console-vc.c
index 931068d43a..4c8ea4c148 100644
--- a/ui/console-vc.c
+++ b/ui/console-vc.c
@@ -1093,10 +1093,7 @@ void qemu_text_console_update_size(QemuTextConsole *= c)
=C2=A0 =C2=A0 =C2=A0dpy_text_resize(QEMU_CONSOLE(c), c->width, c->hei= ght);
=C2=A0}

-static void vc_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Error **errp)
+static void vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **err= p)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ChardevVC *vc =3D backend->u.vc.data;
=C2=A0 =C2=A0 =C2=A0VCChardev *drv =3D VC_CHARDEV(chr);
@@ -1144,7 +1141,7 @@ static void vc_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0drv->t_attrib =3D TEXT_ATTRIBUTES_DEFA= ULT;
=C2=A0 =C2=A0 =C2=A0}

-=C2=A0 =C2=A0 *be_opened =3D true;
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0static void vc_chr_parse(QemuOpts *opts, ChardevBackend *backend, Err= or **errp)
diff --git a/ui/dbus-chardev.c b/ui/dbus-chardev.c
index f6c426e220..3e471f84cd 100644
--- a/ui/dbus-chardev.c
+++ b/ui/dbus-chardev.c
@@ -176,9 +176,7 @@ dbus_chr_send_break(
=C2=A0 =C2=A0 =C2=A0return DBUS_METHOD_INVOCATION_HANDLED;
=C2=A0}

-static void
-dbus_chr_open(Chardev *chr, ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool *be_opened, Error **= errp)
+static void dbus_chr_open(Chardev *chr, ChardevBackend *backend, Error **e= rrp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0ERRP_GUARD();

@@ -211,7 +209,7 @@ dbus_chr_open(Chardev *chr, ChardevBackend *backend, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;
=C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0CHARDEV_CLASS(object_class_by_name(TYPE_CHARDEV_SOCKET)= )->chr_open(
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 chr, be, be_opened, errp);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 chr, be, errp);
=C2=A0}

=C2=A0static void
diff --git a/ui/gtk.c b/ui/gtk.c
index b5498a7ce3..3eeb5baa11 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1963,10 +1963,7 @@ static void gd_vc_chr_set_echo(Chardev *chr, bool ec= ho)

=C2=A0static int nb_vcs;
=C2=A0static Chardev *vcs[MAX_VCS];
-static void gd_vc_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0Error **errp)
+static void gd_vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **= errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0if (nb_vcs =3D=3D MAX_VCS) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error_setg(errp, "Maximum number of = consoles reached");
@@ -1975,10 +1972,10 @@ static void gd_vc_chr_open(Chardev *chr,

=C2=A0 =C2=A0 =C2=A0vcs[nb_vcs++] =3D chr;

-=C2=A0 =C2=A0 /* console/chardev init sometimes completes elsewhere in a 2= nd
+=C2=A0 =C2=A0 /*
+=C2=A0 =C2=A0 =C2=A0* console/chardev init sometimes completes elsewhere i= n a 2nd
=C2=A0 =C2=A0 =C2=A0 * stage, so defer OPENED events until they are fully i= nitialized
=C2=A0 =C2=A0 =C2=A0 */
-=C2=A0 =C2=A0 *be_opened =3D false;
=C2=A0}

=C2=A0static void char_gd_vc_class_init(ObjectClass *oc, const void *data)<= br> diff --git a/ui/spice-app.c b/ui/spice-app.c
index ea0b62a22b..7ac9ae4e78 100644
--- a/ui/spice-app.c
+++ b/ui/spice-app.c
@@ -49,8 +49,7 @@ struct VCChardev {

=C2=A0struct VCChardevClass {
=C2=A0 =C2=A0 =C2=A0ChardevClass parent;
-=C2=A0 =C2=A0 void (*parent_open)(Chardev *chr, ChardevBackend *backend, -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 bool *be_opened, Error **errp);
+=C2=A0 =C2=A0 void (*parent_open)(Chardev *chr, ChardevBackend *backend, E= rror **errp);
=C2=A0};

=C2=A0#define TYPE_CHARDEV_VC "chardev-vc"
@@ -67,10 +66,7 @@ chr_spice_backend_new(void)
=C2=A0 =C2=A0 =C2=A0return be;
=C2=A0}

-static void vc_chr_open(Chardev *chr,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 bool *be_opened,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Error **errp)
+static void vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **err= p)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0VCChardevClass *vc =3D CHARDEV_VC_GET_CLASS(chr);
=C2=A0 =C2=A0 =C2=A0ChardevBackend *be;
@@ -87,7 +83,7 @@ static void vc_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0be =3D chr_spice_backend_new();
=C2=A0 =C2=A0 =C2=A0be->u.spiceport.data->fqdn =3D fqdn ?
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0g_strdup(fqdn) : g_strdup_printf("or= g.qemu.console.%s", chr->label);
-=C2=A0 =C2=A0 vc->parent_open(chr, be, be_opened, errp);
+=C2=A0 =C2=A0 vc->parent_open(chr, be, errp);
=C2=A0 =C2=A0 =C2=A0qapi_free_ChardevBackend(be);
=C2=A0}

diff --git a/ui/vdagent.c b/ui/vdagent.c
index 9972a9c476..3becc6c076 100644
--- a/ui/vdagent.c
+++ b/ui/vdagent.c
@@ -662,7 +662,6 @@ static void vdagent_chr_recv_clipboard(VDAgentChardev *= vd, VDAgentMessage *msg)

=C2=A0static void vdagent_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ChardevBackend *backend,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool *be_opened,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Error **errp)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0VDAgentChardev *vd =3D QEMU_VDAGENT_CHARDEV(chr);
@@ -692,7 +691,7 @@ static void vdagent_chr_open(Chardev *chr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &vdagent_mouse_handler);
=C2=A0 =C2=A0 =C2=A0}

-=C2=A0 =C2=A0 *be_opened =3D true;
+=C2=A0 =C2=A0 qemu_chr_be_event(chr, CHR_EVENT_OPENED);
=C2=A0}

=C2=A0static void vdagent_clipboard_peer_register(VDAgentChardev *vd)
--
2.48.1

--00000000000064a3710644e385b3--