Re: [PATCH] ui/vnc: Update display update interval when VM state changes to RUNNING

["Marc-André Lureau" <marcandre.lureau@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

Hi

On Wed, Jun 11, 2025 at 4:34 PM Peter Xu <peterx@redhat.com> wrote:

> On Wed, May 21, 2025 at 05:16:13PM +0200, Juraj Marcin wrote:
> > From: Juraj Marcin <jmarcin@redhat.com>
> >
> > If a virtual machine is paused for an extended period time, for example,
> > due to an incoming migration, there are also no changes on the screen.
> > VNC in such case increases the display update interval by
> > VNC_REFRESH_INTERVAL_INC (50 ms). The update interval can then grow up
> > to VNC_REFRESH_INTERVAL_MAX (3000 ms).
> >
> > When the machine resumes, it can then take up to 3 seconds for the first
> > display update. Furthermore, the update interval is then halved with
> > each display update with changes on the screen. If there are moving
> > elements on the screen, such as a video, this can be perceived as
> > freezing and stuttering for few seconds before the movement is smooth
> > again.
> >
> > This patch resolves this issue, by adding a listener to VM state changes
> > and changing the update interval when the VM state changes to RUNNING.
> > The update_displaychangelistener() function updates the internal timer,
> > and the display is refreshed immediately if the timer is expired.
> >
> > Signed-off-by: Juraj Marcin <jmarcin@redhat.com>
>
> [add Dan]
>
> Ping - anyone is willing to pick this one up?
>

I haven't started gathering pending UI patches. Feel free to pick it up

[-- Attachment #2: Type: text/html, Size: 2015 bytes --]