From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE03C432C3 for ; Wed, 20 Nov 2019 15:29:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5772B20714 for ; Wed, 20 Nov 2019 15:29:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZMr9UDR6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5772B20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXRur-0003fR-3A for qemu-devel@archiver.kernel.org; Wed, 20 Nov 2019 10:29:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34154) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXRs1-00088L-GT for qemu-devel@nongnu.org; Wed, 20 Nov 2019 10:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXRs0-0007C5-Dp for qemu-devel@nongnu.org; Wed, 20 Nov 2019 10:26:17 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55914 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXRs0-0007Bu-9p for qemu-devel@nongnu.org; Wed, 20 Nov 2019 10:26:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574263575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU+UI2P8kLFMywmsiVyG++O4p2hl0m7GnatrLRH30XQ=; b=ZMr9UDR6SC5j75ZnSODGn3aCiZQFfiK++0gNOgYBd6lUGko+WV/qqV0djiLiqmb3LIbbuu e2Nfr8qV28fUXWuYpr1BhmuC8PT/AtVCqRxvUKThHgxI+ZiIb468pL3Nt7dP7ioLTOAgIp iXcB/835qJyhiWgfoZopj+mxrYACgaw= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-TFTnw-aFM7WV57pBQjzttA-1; Wed, 20 Nov 2019 10:26:14 -0500 Received: by mail-ot1-f72.google.com with SMTP id 109so14178547otv.1 for ; Wed, 20 Nov 2019 07:26:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UU+UI2P8kLFMywmsiVyG++O4p2hl0m7GnatrLRH30XQ=; b=s0A2fzXoU+60J9T4KwKqxcLAqNfedmlzhk9MVJainmAXWsqy7FvLqp7K3Ac/XPyT5y JFHpr8L2oyWs3evLJ4JL+pq2rumq8+YlQo/4j0MbOIv/skpCrjbosYJi94CeIipr8paJ nq94pT0NFqlrUYnxqWH2/tnSgLGlcFgwgPSrVGxscFvJS3rjbaviFwPR/kGmeaV6Cbxz z5urs53Vv4z6xO9rk4OG6M4uK3UputU4zq3e9xEUN555w1zXwE9wiYVJG4k+6Y2ZeXU2 S03V4nWfdF4brFeoJ+WgGM3uH/fXNIuERtGAuXukBdjzXP5hBcjE5zYI7Kz4RpBMkL0f uKfQ== X-Gm-Message-State: APjAAAUAxZz7MRs9blby2dJJSz6Cb83djQhCoNM38VrXa5dUoQxGjsrb EdJ2ojubo34pgPXR3vYJY9Pdw07f08Bnxj4Z6WWVHw8MoBokVqNdlbPSaPeC/trtce75wHS60za qPbEONjaoSB125m+TPu9ktZvEH9n4Shc= X-Received: by 2002:a05:6830:164a:: with SMTP id h10mr2386759otr.62.1574263573601; Wed, 20 Nov 2019 07:26:13 -0800 (PST) X-Google-Smtp-Source: APXvYqzShYtb+TsfLwXwI25JiJEYfOzbS74Sau5xOqn3iHn9MRawd59v6FScEBFCF962lkazjTjQYdF5vHJIj4qPIXc= X-Received: by 2002:a05:6830:164a:: with SMTP id h10mr2386733otr.62.1574263573285; Wed, 20 Nov 2019 07:26:13 -0800 (PST) MIME-Version: 1.0 References: <20191120152400.26012-1-marcandre.lureau@redhat.com> In-Reply-To: <20191120152400.26012-1-marcandre.lureau@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 20 Nov 2019 19:26:02 +0400 Message-ID: Subject: Re: [PATCH v6 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR To: qemu-devel X-MC-Unique: TFTnw-aFM7WV57pBQjzttA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 20, 2019 at 7:24 PM Marc-Andr=C3=A9 Lureau wrote: > > Hi, > > QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove > me". In most cases, it can be easily replaced with QDEV_PROP_LINK when > the pointer points to an Object. > > There are a few places where such substitution isn't possible. For > those places, it seems reasonable to use a specific setter method > instead, and keep the user_creatable =3D false. In other places, > proper usage of qdev or other facilies is the solution. > > The serial code wasn't converted to qdev, which makes it a bit more > archaic to deal with. Let's convert it first, so we can more easily > embed it from other devices, and re-export some properties and drop > QDEV_PROP_PTR usage. > > v4: (after Peter & Philippe reviews) Please ignore that cover letter, resending with v4 in subject (let's see how patchew handle that!).