From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "John Snow" <jsnow@redhat.com>, "Bin Meng" <bmeng.cn@gmail.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4] sphinx: adopt kernel readthedoc theme
Date: Tue, 23 Mar 2021 15:37:36 +0400 [thread overview]
Message-ID: <CAMxuvazOeOhyAXvYXb1DpGff+8BAHrZG5bLLG1KYC1xL2eX08Q@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_BL1myi878cE5V48EeUpvzq5HUMgU5fKP74YRsutjdjQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
Hi
On Tue, Mar 23, 2021 at 3:36 PM Peter Maydell <peter.maydell@linaro.org>
wrote:
> On Tue, 23 Mar 2021 at 11:29, Daniel P. Berrangé <berrange@redhat.com>
> wrote:
> > The theme is pre-packaged for Fedora, Debian, Ubuntu, which gives me
> > confidence for Linux distros in general.
> >
> > BSD / macOS / Windows, who knows ?
>
> Mmm, good point. Marc-André's the one who's been doing the work
> here, so I'm happy to leave it up to him if he thinks retaining
> the fallback is the best approach.
>
> > We could check for rtd theme in meson, and disable the docs build
> > if missing.
>
> If you make the docs/conf.py raise an error if the theme is missing,
> then the existing docs/meson.build "does sphinx work?" test will
> disable the docs build. (You would want to improve the error message
> to note that the problem might be missing theme, though.)
>
>
Ok great, I'll do that. thanks
[-- Attachment #2: Type: text/html, Size: 1393 bytes --]
next prev parent reply other threads:[~2021-03-23 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 10:52 [PATCH v4] sphinx: adopt kernel readthedoc theme marcandre.lureau
2021-03-22 10:59 ` Marc-André Lureau
2021-03-22 11:34 ` Marc-André Lureau
2021-03-22 12:14 ` Daniel P. Berrangé
2021-03-23 10:27 ` Daniel P. Berrangé
2021-03-23 11:00 ` Peter Maydell
2021-03-23 11:12 ` Marc-André Lureau
2021-03-23 11:29 ` Daniel P. Berrangé
2021-03-23 11:36 ` Peter Maydell
2021-03-23 11:37 ` Marc-André Lureau [this message]
2021-03-23 11:05 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMxuvazOeOhyAXvYXb1DpGff+8BAHrZG5bLLG1KYC1xL2eX08Q@mail.gmail.com \
--to=marcandre.lureau@redhat.com \
--cc=berrange@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).