Re: [PATCH 1/3] docs: Update mentions of removed '-soundhw' command line option

["Marc-André Lureau" <marcandre.lureau@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]

Hi

On Tue, Oct 21, 2025 at 5:18 PM Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:

> The `-soundhw` CLI was removed in commit 039a68373c4 ("introduce
> -audio as a replacement for -soundhw"). Remove outdated comments
> and update the document mentioning the old usage.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
I'll take it in my v2.


> ---
>  docs/qdev-device-use.txt | 4 ++--
>  system/qdev-monitor.c    | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt
> index 043ae461140..fb420da2a9e 100644
> --- a/docs/qdev-device-use.txt
> +++ b/docs/qdev-device-use.txt
> @@ -311,9 +311,9 @@ constraints.
>
>  Host and guest part of audio devices have always been separate.
>
> -The old way to define guest audio devices is -soundhw C1,...
> +The old way to define guest audio devices was -soundhw C1,...
>
> -The new way is to define each guest audio device separately with
> +The current way is to define each guest audio device separately with
>  -device.
>
>  Map from -soundhw sound card name to -device:
> diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
> index 4b732f579ad..5c95926aadd 100644
> --- a/system/qdev-monitor.c
> +++ b/system/qdev-monitor.c
> @@ -73,9 +73,9 @@ typedef struct QDevAlias
>
>  /* Please keep this table sorted by typename. */
>  static const QDevAlias qdev_alias_table[] = {
> -    { "AC97", "ac97" }, /* -soundhw name */
> +    { "AC97", "ac97" },
>      { "e1000", "e1000-82540em" },
> -    { "ES1370", "es1370" }, /* -soundhw name */
> +    { "ES1370", "es1370" },
>      { "ich9-ahci", "ahci" },
>      { "lsi53c895a", "lsi" },
>      { "virtio-9p-device", "virtio-9p", QEMU_ARCH_VIRTIO_MMIO },
> --
> 2.51.0
>
>

[-- Attachment #2: Type: text/html, Size: 2786 bytes --]