qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marc-Andre Lureau <mlureau@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] tpm: add CRB device
Date: Fri, 26 Jan 2018 13:09:24 +0100	[thread overview]
Message-ID: <CAMxuvazdE3VnxWaF0Z-T5BxExnC4uOnqwU9LiYvMsBSi6Tn85g@mail.gmail.com> (raw)
In-Reply-To: <20180126120306.19225-1-marcandre.lureau@redhat.com>

Hi,

Stash this to fix test leaks:

diff --git a/tests/tpm-crb-test.c b/tests/tpm-crb-test.c
index de78a28844..8bf1507e00 100644
--- a/tests/tpm-crb-test.c
+++ b/tests/tpm-crb-test.c
@@ -81,6 +81,7 @@ static void *emu_tpm_thread(void *data)

     g_free(s->tpm_msg);
     s->tpm_msg = NULL;
+    object_unref(OBJECT(s->tpm_ioc));
     return NULL;
 }

@@ -180,6 +181,8 @@ static void *emu_ctrl_thread(void *data)
         }
     }

+    object_unref(OBJECT(ioc));
+    object_unref(OBJECT(lioc));
     return NULL;
 }

  reply	other threads:[~2018-01-26 14:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 12:03 [Qemu-devel] [PATCH v3] tpm: add CRB device Marc-André Lureau
2018-01-26 12:09 ` Marc-Andre Lureau [this message]
2018-01-26 13:19 ` no-reply
2018-01-28 13:38   ` Stefan Berger
2018-01-29 14:24     ` Eric Blake
2018-01-26 13:23 ` no-reply
2018-01-26 13:27 ` no-reply
2018-01-26 13:27 ` no-reply
2018-01-26 13:30 ` no-reply
2018-01-26 18:50 ` Stefan Berger
2018-01-29 16:24 ` Igor Mammedov
2018-01-29 16:50   ` Stefan Berger
2018-01-30  8:35     ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMxuvazdE3VnxWaF0Z-T5BxExnC4uOnqwU9LiYvMsBSi6Tn85g@mail.gmail.com \
    --to=mlureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).