From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] scripts/qemu-version.sh: Add missing space before ']'
Date: Sun, 23 Aug 2020 19:59:20 +0400 [thread overview]
Message-ID: <CAMxuvazg9xRTcCqXg6MRdvaMreQwGJ-mEe8WFeDP_toqpKMECw@mail.gmail.com> (raw)
In-Reply-To: <20200823102617.32358-1-thuth@redhat.com>
Hi
On Sun, Aug 23, 2020 at 2:26 PM Thomas Huth <thuth@redhat.com> wrote:
>
> When configure has been run with --with-pkgversion=xyz, the shell complains
> about a missing ']' in this script.
>
> Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
oops, my bad
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> scripts/qemu-version.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> index 4847385e42..03128c56a2 100755
> --- a/scripts/qemu-version.sh
> +++ b/scripts/qemu-version.sh
> @@ -6,7 +6,7 @@ dir="$1"
> pkgversion="$2"
> version="$3"
>
> -if [ -z "$pkgversion"]; then
> +if [ -z "$pkgversion" ]; then
> cd "$dir"
> if [ -e .git ]; then
> pkgversion=$(git describe --match 'v*' --dirty | echo "")
> --
> 2.18.2
>
next prev parent reply other threads:[~2020-08-23 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 10:26 [PATCH] scripts/qemu-version.sh: Add missing space before ']' Thomas Huth
2020-08-23 15:59 ` Marc-André Lureau [this message]
2020-08-25 7:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMxuvazg9xRTcCqXg6MRdvaMreQwGJ-mEe8WFeDP_toqpKMECw@mail.gmail.com \
--to=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).