From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 0/2] linux-user: revert previous workaround for glibc >= 2.36
Date: Wed, 11 Jan 2023 13:55:36 +0400 [thread overview]
Message-ID: <CAMxuvazv0EGDytTzK2Ex5810YYUJaXau1TSxm4=S5d7wigVttA@mail.gmail.com> (raw)
In-Reply-To: <20230110174901.2580297-1-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
Hi
On Tue, Jan 10, 2023 at 9:49 PM Daniel P. Berrangé <berrange@redhat.com>
wrote:
> It didn't appear that glibc was going to fix the problem
> breaking includes of linux/mount.h vs sys/mount.h, so
> QEMU applied a workaround copying the symbols/structs we
> need into a local header.
>
> Since then Linux modified linux/btrfs.h to pull in
> linux/fs.h which caused a clash with our workaround.
> Rather than invent workarounds for our workarounds,
> we can luckily just drop our previous workarounds.
> glibc has been fixed after all, and backported this
> fix to the stable 2.36 release series too. We should
> just expect distros to pull in the stable fix, which
> Fedora at least has already done.
>
> Daniel P. Berrangé (2):
> Revert "linux-user: add more compat ioctl definitions"
> Revert "linux-user: fix compat with glibc >= 2.36 sys/mount.h"
>
> linux-user/syscall.c | 43 -------------------------------------------
> meson.build | 2 --
> 2 files changed, 45 deletions(-)
>
> --
> 2.38.1
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
[-- Attachment #2: Type: text/html, Size: 1585 bytes --]
next prev parent reply other threads:[~2023-01-11 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 17:48 [PATCH 0/2] linux-user: revert previous workaround for glibc >= 2.36 Daniel P. Berrangé
2023-01-10 17:49 ` [PATCH 1/2] Revert "linux-user: add more compat ioctl definitions" Daniel P. Berrangé
2023-01-10 17:49 ` [PATCH 2/2] Revert "linux-user: fix compat with glibc >= 2.36 sys/mount.h" Daniel P. Berrangé
2023-01-11 9:55 ` Marc-André Lureau [this message]
2023-01-25 13:30 ` [PATCH 0/2] linux-user: revert previous workaround for glibc >= 2.36 Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMxuvazv0EGDytTzK2Ex5810YYUJaXau1TSxm4=S5d7wigVttA@mail.gmail.com' \
--to=marcandre.lureau@redhat.com \
--cc=berrange@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).