[Qemu-devel] make error

[Qemu-devel] make error

[Ronald Delobel]

Hello,

This is the error I get when building qemu-2.11.[0-1] with
gcc-7.3.0/glibc-2.27, removing the static attribute suffice to finnish the
build using the glibc provided memfd_create and qemu don't crash, but I
miss some knowledge here about what a static function really is, a kind of
private one? Shouldn't it be renamed instead and stay as static?

Just to report it.


  CC      util/qemu-thread-posix.o
  CC      util/memfd.o
util/memfd.c:40:12: error: la déclaration statique de « memfd_create » suit
une déclaration non statique
 static int memfd_create(const char *name, unsigned int flags)
            ^~~~~~~~~~~~
In file included from /usr/include/bits/mman-linux.h:115:0,
                 from /usr/include/bits/mman.h:45,
                 from /usr/include/sys/mman.h:41,
                 from
/usr/local/src/qemu-2.11.1/include/sysemu/os-posix.h:29,
                 from /usr/local/src/qemu-2.11.1/include/qemu/osdep.h:104,
                 from util/memfd.c:28:
/usr/include/bits/mman-shared.h:46:5: note: la déclaration précédente de
« memfd_create » était ici
 int memfd_create (const char *__name, unsigned int __flags) __THROW;
     ^~~~~~~~~~~~
make: *** [/usr/local/src/qemu-2.11.1/rules.mak:66: util/memfd.o] Error 1

Re: [Qemu-devel] make error

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

On Tue, Feb 20, 2018 at 04:40:49PM +0100, Ronald Delobel wrote:
> Hello,
> 
> This is the error I get when building qemu-2.11.[0-1] with
> gcc-7.3.0/glibc-2.27, removing the static attribute suffice to finnish the
> build using the glibc provided memfd_create and qemu don't crash, but I
> miss some knowledge here about what a static function really is, a kind of
> private one? Shouldn't it be renamed instead and stay as static?
> 
> Just to report it.

Thanks for reporting this.  Peter Maydell looked into this and answered
it in another email thread:

  "this looks like a QEMU incompatibility with newer glibc that
  we fixed in QEMU commit 75e5b70e6b5dcc4. That didn't quite make
  the 2.11.0 release, but will be in 2.12.0."

>   CC      util/qemu-thread-posix.o
>   CC      util/memfd.o
> util/memfd.c:40:12: error: la déclaration statique de « memfd_create » suit
> une déclaration non statique
>  static int memfd_create(const char *name, unsigned int flags)
>             ^~~~~~~~~~~~
> In file included from /usr/include/bits/mman-linux.h:115:0,
>                  from /usr/include/bits/mman.h:45,
>                  from /usr/include/sys/mman.h:41,
>                  from
> /usr/local/src/qemu-2.11.1/include/sysemu/os-posix.h:29,
>                  from /usr/local/src/qemu-2.11.1/include/qemu/osdep.h:104,
>                  from util/memfd.c:28:
> /usr/include/bits/mman-shared.h:46:5: note: la déclaration précédente de
> « memfd_create » était ici
>  int memfd_create (const char *__name, unsigned int __flags) __THROW;
>      ^~~~~~~~~~~~
> make: *** [/usr/local/src/qemu-2.11.1/rules.mak:66: util/memfd.o] Error 1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]