From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqR9E-0005Fo-ER for qemu-devel@nongnu.org; Fri, 08 Sep 2017 17:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqR9B-00077K-Mt for qemu-devel@nongnu.org; Fri, 08 Sep 2017 17:49:11 -0400 Received: from mail-ua0-x22e.google.com ([2607:f8b0:400c:c08::22e]:32948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqR9B-00073c-H2 for qemu-devel@nongnu.org; Fri, 08 Sep 2017 17:49:09 -0400 Received: by mail-ua0-x22e.google.com with SMTP id g47so5584003uad.0 for ; Fri, 08 Sep 2017 14:49:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170831093400.GH13619@stefanha-x1.localdomain> References: <20170830082702.3011-1-Sergio.G.DelReal@gmail.com> <20170831093400.GH13619@stefanha-x1.localdomain> From: =?UTF-8?Q?Sergio_Andr=C3=A9s_G=C3=B3mez_del_Real?= Date: Fri, 8 Sep 2017 16:49:04 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v2 00/13] add support for Hypervisor.framework in QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel , Paolo Bonzini Guys, I'm almost done with the new version of the patchset (hopefully the definite one). What I am missing essentially are presenting a few tests as suggested by Stefan. Paolo and I only ran the eventinj test from the kvm suite. If I modify this boot-serial-test to include hvf, should I send these changes first before the patchset so it could be reproduced? would these be sufficient, or should I consider some further tests? On Thu, Aug 31, 2017 at 4:34 AM, Stefan Hajnoczi wrote: > On Wed, Aug 30, 2017 at 03:26:49AM -0500, Sergio Andres Gomez Del Real > wrote: > > ================ > > Changes in v2: > > (1) Removed legacy option "-enable-hvf" in favor of "-M accel=hvf" > > (2) Added missing copyright headers; replace fprintfs for error_report; > > improved commit description. > > (3) Moved patch that adds compilation rules in Makefile.objs right after > > the patch that adds the new files from Google's repo. > > (4) Removed conditional macros from cpus.c and cpu.c > > (5) Moved patch that fixes coding style to patch # 3 > > (6) Fix commit message in apic patch > > (7) Squash some commits to avoid code churn > > ================ > > > > The following patchset adds to QEMU the supporting for macOS's native > > hypervisor, Hypervisor.framework (hvf). The code base is taken from > > Google's Android emulator at > > https://android.googlesource.com/platform/external/qemu/+/emu-master-dev > . > > > > Apart from general code refactoring, some additional features were > implemented: > > retrieve the set of features supported by host cpu and hvf (cpuid); > > dirty page tracking for VGA memory area; reimplementation of the event > > injection mechanism to allow injection of exceptions during vmexits, > which is > > exemplified by the injection of a GP fault when the guest vmexits due to > > execution of the vmcall instruction; changing the emulator's use of > CPUState > > structure in favor of CPUX86State, so as to in the future remove data > structures > > that are uselessly specific to hvf and unified some of the state between > kvm/tcg > > and hvf. > > Some features initially planned to implement that didn't make it include: > > page fault handling in the emulator and implementing the dummy_signal to > handle > > the SIG_IPI signal without race conditions. Hopefully these can be > implemented > > in the near future. > > I have done a brief review (mainly style issues) of the whole series. > > A test case is required. Maybe the easiest option is to extend > tests/boot-serial-test.c to try hvf (if available). That way an > automated test will verify that the BIOS executes inside the guest. > > Stefan >