From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asQT5-0007K5-NK for qemu-devel@nongnu.org; Tue, 19 Apr 2016 03:53:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asQT1-0007CI-L8 for qemu-devel@nongnu.org; Tue, 19 Apr 2016 03:53:07 -0400 Received: from m109-177.yeah.net ([123.58.177.109]:10271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asQT0-0007B3-Im for qemu-devel@nongnu.org; Tue, 19 Apr 2016 03:53:03 -0400 Received: from mail-yw0-f173.google.com (mail-yw0-f173.google.com [209.85.161.173]) by mr213139.mail.yeah.net (HMail) with ESMTPSA id 12DDD1C173F for ; Tue, 19 Apr 2016 15:52:51 +0800 (CST) Received: by mail-yw0-f173.google.com with SMTP id o66so8762500ywc.3 for ; Tue, 19 Apr 2016 00:52:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1461051553-14720-1-git-send-email-hongyang.yang@easystack.cn> References: <1461051553-14720-1-git-send-email-hongyang.yang@easystack.cn> Date: Tue, 19 Apr 2016 15:52:48 +0800 Message-ID: From: Yang Hongyang Content-Type: multipart/alternative; boundary=001a113cd1466dfc5e0530d1c397 Subject: Re: [Qemu-devel] [PATCH] qemu-ga: do not run qga test when guest agent disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang Cc: qemu devel , Michael Roth , Paolo Bonzini , Gerd Hoffmann , "Michael S. Tsirkin" --001a113cd1466dfc5e0530d1c397 Content-Type: text/plain; charset=UTF-8 I think this patch should also be backported to stable v2.5.1 On Tue, Apr 19, 2016 at 3:39 PM, Yang Hongyang wrote: > When configure with --disable-guest-agent, make check will fail with: > ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error == NULL): > Failed to execute child process "/home/xx/qemu/qemu-ga" (No such file or > directory) (g-exec-error-quark, 8) > make: *** [check-tests/test-qga] Error 1 > > This check was commented out by bab47d9a75a. I think that was by > mistake, because the commit message of that commit didn't mention > this change. > > Signed-off-by: Yang Hongyang > Cc: Gerd Hoffmann > Cc: Michael S. Tsirkin > Cc: Michael Roth > Cc: Paolo Bonzini > --- > tests/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/Makefile b/tests/Makefile > index 9de9598..9194f18 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -83,7 +83,9 @@ check-unit-y += tests/test-crypto-cipher$(EXESUF) > check-unit-y += tests/test-crypto-secret$(EXESUF) > check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF) > check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF) > -#check-unit-$(CONFIG_LINUX) += tests/test-qga$(EXESUF) > +ifneq (,$(findstring qemu-ga,$(TOOLS))) > +check-unit-$(CONFIG_LINUX) += tests/test-qga$(EXESUF) > +endif > check-unit-y += tests/test-timed-average$(EXESUF) > check-unit-y += tests/test-io-task$(EXESUF) > check-unit-y += tests/test-io-channel-socket$(EXESUF) > -- > 1.8.3.1 > > > -- Thanks, Yang --001a113cd1466dfc5e0530d1c397 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I think this patch should also be backported to stable v2.= 5.1

On Tue, Apr 19= , 2016 at 3:39 PM, Yang Hongyang <hongyang.yang@easystack.cn&= gt; wrote:
When configure with --d= isable-guest-agent, make check will fail with:
ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error =3D=3D NUL= L):
=C2=A0Failed to execute child process "/home/xx/qemu/qemu-ga" (No= such file or
directory) (g-exec-error-quark, 8)
make: *** [check-tests/test-qga] Error 1

This check was commented out by bab47d9a75a. I think that was by
mistake, because the commit message of that commit didn't mention
this change.

Signed-off-by: Yang Hongyang <hongyang.yang@easystack.cn>
Cc: Gerd Hoffmann <kraxel@redhat.co= m>
Cc: Michael S. Tsirkin <mst@redhat.com= >
Cc: Michael Roth <mdroth@li= nux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redha= t.com>
---
=C2=A0tests/Makefile | 4 +++-
=C2=A01 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/Makefile b/tests/Makefile
index 9de9598..9194f18 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -83,7 +83,9 @@ check-unit-y +=3D tests/test-crypto-cipher$(EXESUF)
=C2=A0check-unit-y +=3D tests/test-crypto-secret$(EXESUF)
=C2=A0check-unit-$(CONFIG_GNUTLS) +=3D tests/test-crypto-tlscredsx509$(EXES= UF)
=C2=A0check-unit-$(CONFIG_GNUTLS) +=3D tests/test-crypto-tlssession$(EXESUF= )
-#check-unit-$(CONFIG_LINUX) +=3D tests/test-qga$(EXESUF)
+ifneq (,$(findstring qemu-ga,$(TOOLS)))
+check-unit-$(CONFIG_LINUX) +=3D tests/test-qga$(EXESUF)
+endif
=C2=A0check-unit-y +=3D tests/test-timed-average$(EXESUF)
=C2=A0check-unit-y +=3D tests/test-io-task$(EXESUF)
=C2=A0check-unit-y +=3D tests/test-io-channel-socket$(EXESUF)
--
1.8.3.1





--
Thanks,
Yang
--001a113cd1466dfc5e0530d1c397--