From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58525)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ronniesahlberg@gmail.com>) id 1TA7uK-0002HB-HH
	for qemu-devel@nongnu.org; Fri, 07 Sep 2012 19:24:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ronniesahlberg@gmail.com>) id 1TA7uJ-0004HK-Lr
	for qemu-devel@nongnu.org; Fri, 07 Sep 2012 19:24:16 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:47764)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ronniesahlberg@gmail.com>) id 1TA7uJ-0004HF-Gf
	for qemu-devel@nongnu.org; Fri, 07 Sep 2012 19:24:15 -0400
Received: by obbta14 with SMTP id ta14so196930obb.4
	for <qemu-devel@nongnu.org>; Fri, 07 Sep 2012 16:24:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1346372920-10459-2-git-send-email-ronniesahlberg@gmail.com>
References: <1346372920-10459-1-git-send-email-ronniesahlberg@gmail.com>
	<1346372920-10459-2-git-send-email-ronniesahlberg@gmail.com>
Date: Fri, 7 Sep 2012 16:24:14 -0700
Message-ID: <CAN05THRJd5sji9dwpsskcMiEXcs34RAw8A-xi7P8Dq9xNS9F-g@mail.gmail.com>
From: ronnie sahlberg <ronniesahlberg@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH] iSCSI: We need to support SG_IO also from
	iscsi_ioctl()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pbonzini@redhat.com, qemu-devel@nongnu.org
Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>

ping?

On Thu, Aug 30, 2012 at 5:28 PM, Ronnie Sahlberg
<ronniesahlberg@gmail.com> wrote:
> We need to support SG_IO from the synchronous iscsi_ioctl() since
> scsi-block uses this to do an INQ to the device to discover its properties
> This patch makes scsi-block work with iscsi.
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  block/iscsi.c |   20 +++++++++++++++++++-
>  1 files changed, 19 insertions(+), 1 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 355ce65..189ab6f 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -537,7 +537,8 @@ iscsi_aio_ioctl_cb(struct iscsi_context *iscsi, int status,
>
>  #define SG_ERR_DRIVER_SENSE    0x08
>
> -    if (status == SCSI_STATUS_CHECK_CONDITION && acb->task->datain.size >= 2) {
> +    if (status == SCSI_STATUS_CHECK_CONDITION
> +    && acb->task->datain.size >= 2) {
>          int ss;
>
>          acb->ioh->driver_status |= SG_ERR_DRIVER_SENSE;
> @@ -622,9 +623,17 @@ static BlockDriverAIOCB *iscsi_aio_ioctl(BlockDriverState *bs,
>      return &acb->common;
>  }
>
> +
> +static void ioctl_cb(void *opaque, int status)
> +{
> +    int *p_status = opaque;
> +    *p_status = status;
> +}
> +
>  static int iscsi_ioctl(BlockDriverState *bs, unsigned long int req, void *buf)
>  {
>      IscsiLun *iscsilun = bs->opaque;
> +    int status;
>
>      switch (req) {
>      case SG_GET_VERSION_NUM:
> @@ -633,6 +642,15 @@ static int iscsi_ioctl(BlockDriverState *bs, unsigned long int req, void *buf)
>      case SG_GET_SCSI_ID:
>          ((struct sg_scsi_id *)buf)->scsi_type = iscsilun->type;
>          break;
> +    case SG_IO:
> +        status = -EINPROGRESS;
> +        iscsi_aio_ioctl(bs, req, buf, ioctl_cb, &status);
> +
> +        while (status == -EINPROGRESS) {
> +            qemu_aio_wait();
> +        }
> +
> +        return 0;
>      default:
>          return -1;
>      }
> --
> 1.7.3.1
>