From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7SvF-0002ty-Lg for qemu-devel@nongnu.org; Wed, 16 Jul 2014 13:23:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7SvE-0001vG-H2 for qemu-devel@nongnu.org; Wed, 16 Jul 2014 13:23:17 -0400 Received: from mail-pd0-x22f.google.com ([2607:f8b0:400e:c02::22f]:47539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7SvE-0001v9-9r for qemu-devel@nongnu.org; Wed, 16 Jul 2014 13:23:16 -0400 Received: by mail-pd0-f175.google.com with SMTP id r10so106740pdi.34 for ; Wed, 16 Jul 2014 10:23:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53C6B24D.4020403@weilnetz.de> References: <20140716002632.23073.40357@loki> <53C6A816.9090306@weilnetz.de> <53C6AD18.8030102@redhat.com> <53C6B24D.4020403@weilnetz.de> Date: Wed, 16 Jul 2014 10:23:14 -0700 Message-ID: From: ronnie sahlberg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Peter Maydell , Michael Tokarev , Peter Lieven , qemu-devel , Paolo Bonzini , =?UTF-8?Q?Aur=C3=A9lien_Jarno?= On Wed, Jul 16, 2014 at 10:11 AM, Stefan Weil wrote: > Am 16.07.2014 18:49, schrieb Paolo Bonzini: >> Il 16/07/2014 18:28, Stefan Weil ha scritto: >>> Debian testing includes a brand new libiscsi, but it >>> does not include libiscsi.pc, so pkg-config won't know that it is >>> available and configure will disable libiscsi. >> >> That's a packaging bug. > > CC'ing Michael as he is the Debian maintainer of this package and > Aur=C3=A9lien who maintains QEMU for Debian. > > Michael, should I send a Debian bug report for libiscsi-dev? Would an > update of libiscsi for Debian stable be reasonable if versions older > than 1.9 are too buggy to be used? If you ask debian to upgrade. Could you ask them to wait and upgrade after = I have release the next version, hopefully if all goes well, at the end of this week? It contains new functionality, thanks to plieven, to better handle cases where active/passive storage arrays perform failover. > I must admit that I'm a little bit > surprised because iSCSI support worked for me quite well the last time I > used it with Debian wheezy. I think, and plieven please correct me if I am wrong, earlier version would work reasonably well for basic use but there were bugs and gaps in functionality that made it ill suited for enterprise environments. > > Regards > Stefan > >> >>> I have a patch which >>> fixes this, so QEMU for Debian testing could include libiscsi again. >>> >>> Is a feature regression like this one acceptable? Do we need additional >>> testing (maybe run the build bots with --enable-xxx, so builds fail whe= n >>> xxx no longer works)? >> >> As mentioned in the e49ab19fcaa617ad6cdfe1ac401327326b6a2552 commit >> message, this was intentional. I was reluctant to do it, but ultimately >> Peter Lieven convinced me that it isn't just about using fancy new APIs; >> libiscsi was too buggy to be useful until release 1.8.0 (even 1.9.0 >> requires a patch to avoid segfaults, and many more if you want to run it >> on ARM). >> >> Paolo > >