From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoAJ6-0005KN-07 for qemu-devel@nongnu.org; Fri, 20 Jan 2012 03:58:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoAJ0-00006y-2x for qemu-devel@nongnu.org; Fri, 20 Jan 2012 03:58:47 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:44139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoAIz-0008Vs-Uy for qemu-devel@nongnu.org; Fri, 20 Jan 2012 03:58:42 -0500 Received: by obbup16 with SMTP id up16so541440obb.4 for ; Fri, 20 Jan 2012 00:58:40 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F1809BD.8020108@redhat.com> References: <1324183735-16930-1-git-send-email-ronniesahlberg@gmail.com> <1324183735-16930-2-git-send-email-ronniesahlberg@gmail.com> <4F1809BD.8020108@redhat.com> Date: Fri, 20 Jan 2012 19:58:40 +1100 Message-ID: From: ronnie sahlberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Jan 19, 2012 at 11:17 PM, Kevin Wolf wrote: > Am 18.12.2011 05:48, schrieb Ronnie Sahlberg: >> This patch adds configuration variables for iSCSI to set >> initiator-name to use when logging in to the target, >> which type of header-digest to negotiate with the target >> and username and password for CHAP authentication. >> >> This allows specifying a initiator-name either from the command line >> -iscsi initiator-name=3Diqn.2004-01.com.example:test >> or from a configuration file included with -readconfig >> [iscsi] >> =A0 initiator-name =3D iqn.2004-01.com.example:test >> =A0 header-digest =3D CRC32C|CRC32C-NONE|NONE-CRC32C|NONE >> =A0 user =3D CHAP username >> =A0 password =3D CHAP password >> >> The patch also updates the manpage and qemu-doc >> >> Signed-off-by: Ronnie Sahlberg > > So these options are global? What if I wanted to use two different > setups for two different images? > Good point. I will rework the patch so that it first checks for [iscsi "iqn.target.name"] and if that is not found it falls-back to just checking for [iscsi] That would allow to have one "catch all" section for all targets, but also the possibility to override and use different settings on a per-target basis. I will post an updated patch in a day or two. regards ronnie sahlberg