From: Fabio Erculiani <lxnay@sabayon.org>
To: Alexander Graf <agraf@suse.de>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault.
Date: Tue, 3 Jan 2012 20:11:26 +0100 [thread overview]
Message-ID: <CAN3Atvo4mWwdHuYwtZUXbCxeZYrEXsbhw5sDxowGN3Fag=ru-Q@mail.gmail.com> (raw)
In-Reply-To: <5410BBE9-2297-407B-A7D7-37EFD6A70AB3@suse.de>
Ok, I've found the reason, i guess it's a bug.
target_argv pointer is placed in bprm->argv;
But then target_argv is freed and nullified.
loader_exec should just allocate a new char** and copy target_argv.
I tried that and it worked.
The problem is, where do I free() it? Am i supposed to do it or the
TaskState lifecycle matches the executable (so there is no need to
free() it) ?
--
Fabio Erculiani
next prev parent reply other threads:[~2012-01-03 19:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 15:43 [Qemu-devel] [PATCH] linux-user: improve fake /proc/self/stat making `ps` not segfault Fabio Erculiani
2012-01-03 16:07 ` Fabio Erculiani
2012-01-03 17:41 ` Alexander Graf
2012-01-03 18:04 ` Fabio Erculiani
2012-01-03 18:08 ` Fabio Erculiani
2012-01-03 18:28 ` Alexander Graf
2012-01-03 18:29 ` Alexander Graf
2012-01-03 18:46 ` Fabio Erculiani
2012-01-03 18:52 ` Fabio Erculiani
2012-01-03 18:52 ` Alexander Graf
2012-01-03 18:54 ` Fabio Erculiani
2012-01-03 19:01 ` Alexander Graf
2012-01-03 19:11 ` Fabio Erculiani [this message]
2012-01-03 19:12 ` Alexander Graf
2012-01-03 19:21 ` Fabio Erculiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN3Atvo4mWwdHuYwtZUXbCxeZYrEXsbhw5sDxowGN3Fag=ru-Q@mail.gmail.com' \
--to=lxnay@sabayon.org \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).