From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuTTa-0004ZQ-Mu for qemu-devel@nongnu.org; Wed, 03 Jul 2013 16:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuTTZ-0005AQ-82 for qemu-devel@nongnu.org; Wed, 03 Jul 2013 16:16:30 -0400 MIME-Version: 1.0 Sender: flukshun@gmail.com In-Reply-To: <1372882200.2883.208.camel@ul30vt.home> References: <1371073298-14519-1-git-send-email-mdroth@linux.vnet.ibm.com> <1371073298-14519-10-git-send-email-mdroth@linux.vnet.ibm.com> <1372882200.2883.208.camel@ul30vt.home> From: Michael Roth Date: Wed, 3 Jul 2013 15:16:08 -0500 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson wrote: > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: >> From: Andreas F=E4rber >> >> The implementation of the ATA FLUSH command invokes a flush at the block >> layer, which may on raw files on POSIX entail a synchronous fdatasync(). >> This may in some cases take so long that the SLES 11 SP1 guest driver >> reports I/O errors and filesystems get corrupted or remounted read-only. >> >> Avoid this by setting BUSY_STAT, so that the guest is made aware we are >> in the middle of an operation and no ATA commands are attempted to be >> processed concurrently. >> >> Addresses BNC#637297. >> >> Suggested-by: Gonglei (Arei) >> Signed-off-by: Andreas F=E4rber >> Signed-off-by: Kevin Wolf >> Signed-off-by: Stefan Hajnoczi >> (cherry picked from commit f68ec8379e88502b4841a110c070e9b118d3151c) >> >> Signed-off-by: Michael Roth >> --- >> hw/ide/core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index c7a8041..9926d92 100644 >> --- a/hw/ide/core.c >> +++ b/hw/ide/core.c >> @@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s) >> return; >> } >> >> + s->status |=3D BUSY_STAT; >> bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH); >> bdrv_aio_flush(s->bs, ide_flush_cb, s); >> } > > This caused a regression for me from 1.5.0->1.5.1. Windows 7 x64 no > longer boots on q35 IDE with this change. Thanks, Are you seeing the issue for upstream builds as well? > > Alex >