From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47714C433EF for ; Wed, 17 Nov 2021 17:32:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B885C61B9F for ; Wed, 17 Nov 2021 17:32:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B885C61B9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:32772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnOnP-0002WP-TB for qemu-devel@archiver.kernel.org; Wed, 17 Nov 2021 12:32:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnOmY-0001pA-5m for qemu-devel@nongnu.org; Wed, 17 Nov 2021 12:31:38 -0500 Received: from [2607:f8b0:4864:20::936] (port=44714 helo=mail-ua1-x936.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnOmV-000053-VL for qemu-devel@nongnu.org; Wed, 17 Nov 2021 12:31:37 -0500 Received: by mail-ua1-x936.google.com with SMTP id p2so7515099uad.11 for ; Wed, 17 Nov 2021 09:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GyXVyur1a00feaEjplWIbOCfHvI3BRFHi0gZNaBqeiI=; b=1c6vxExzwf9tQVrAzzLNlBDUwn7KXdgplG+SaxibxNngdldSZPLN64hRtOo3N7LgvV 7FZf8QDxbuNyNCV8wlS9ZzPvMMbZPmjlnSFZc5PVpWZawmz3psQ4hp+7GbmRkRHC7WIr 1WVOfuYWTxMkGRF3AlH+i/Fd+4XgDYrIaFrtcAocg7FqyaxHd0JwXHSXSe7VrWxJjmrC G/5fh9rVemUD/DE+m44sz1hBVmO/8bjzY4rnZ03bc1v+NoU72M0NK/56ELJtFsw5S0Nr rtPAyiLuXn9AWGJsHnim8p2VEfwIR2CRRx4JMUPBPfoAkwE9KR7SK9ztxaUQXS10+KW1 1FYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GyXVyur1a00feaEjplWIbOCfHvI3BRFHi0gZNaBqeiI=; b=5F9NjKTSt1/QjFNfPneSATkCv8vTnT+nborbz3m6+wuF8xWJWtaUwaffkfnOFaa9cT IpMYxJN+9gja0uNv+Ov4lj+qhH2bi762RfRayrNMRX4LOvkU+d2KGifNe6UUgz85gebA 7Jfe/hzc5n7tRc18XGMyF95ZwhExvrcT8Uckq3lqZ2AH0EWkkcY+B2K1cYAIdfY1R7br oOEqu/V046PK4uxL1RtrFfia2cf/sbiyTjFJUAwwifBUbzYA8DU6SdCpnO8AmJ0W150D B6Sw+s3/LlexJgL5hLGyxD89fFrNwyqnYwFKCN0mDvbskeWM17XGq4L30QrWEeuXCLN6 lA5w== X-Gm-Message-State: AOAM53040VyWvIHRA6PKLVz917vwwe5r1gJ+BpC7O5vV/9onUyFYrrLg bI6jpNHCKjSSUu/NkKsOb4eyO3SBTuH3egAqiGy6bQ== X-Google-Smtp-Source: ABdhPJzanW8ULaNEXeepSXScJM+CiF9kGhPuJIk4lzo1C+hvPxpdINTp6Szjdt5VNP8TIDZ35oHc6YZPYa5hDaEy3f4= X-Received: by 2002:a05:6102:d94:: with SMTP id d20mr72798091vst.12.1637170294915; Wed, 17 Nov 2021 09:31:34 -0800 (PST) MIME-Version: 1.0 References: <20211117160412.71563-1-richard.henderson@linaro.org> <20211117160412.71563-17-richard.henderson@linaro.org> In-Reply-To: <20211117160412.71563-17-richard.henderson@linaro.org> From: Warner Losh Date: Wed, 17 Nov 2021 10:31:24 -0700 Message-ID: Subject: Re: [PATCH v5 16/17] meson: Move linux_user_ss to linux-user/ To: Richard Henderson Content-Type: multipart/alternative; boundary="000000000000dd938905d0ff6910" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::936 (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::936; envelope-from=wlosh@bsdimp.com; helo=mail-ua1-x936.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000dd938905d0ff6910 Content-Type: text/plain; charset="UTF-8" On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson < richard.henderson@linaro.org> wrote: > We have no need to reference linux_user_ss outside of linux-user. > Go ahead and merge it directly into specific_ss. > > Signed-off-by: Richard Henderson > --- > meson.build | 3 --- > linux-user/meson.build | 4 ++++ > 2 files changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Warner Losh BTW, I don't think I have anything meaningful to add to the discussions to date on this bug, and I'm agnostic as to the final decision... > diff --git a/meson.build b/meson.build > index 9f59c57909..ecc181ea13 100644 > --- a/meson.build > +++ b/meson.build > @@ -2363,7 +2363,6 @@ common_user_ss = ss.source_set() > crypto_ss = ss.source_set() > hwcore_ss = ss.source_set() > io_ss = ss.source_set() > -linux_user_ss = ss.source_set() > qmp_ss = ss.source_set() > qom_ss = ss.source_set() > softmmu_ss = ss.source_set() > @@ -2614,8 +2613,6 @@ subdir('linux-user') > > specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) > > -specific_ss.add_all(when: 'CONFIG_LINUX_USER', if_true: linux_user_ss) > - > common_user_ss = common_user_ss.apply(config_all, strict: false) > common_user = static_library('common-user', > sources: common_user_ss.sources(), > diff --git a/linux-user/meson.build b/linux-user/meson.build > index fcf7d40f23..b89534c49c 100644 > --- a/linux-user/meson.build > +++ b/linux-user/meson.build > @@ -2,6 +2,8 @@ if not have_linux_user > subdir_done() > endif > > +linux_user_ss = ss.source_set() > + > common_user_inc += include_directories('host/' / config_host['ARCH']) > common_user_inc += include_directories('.') > > @@ -42,3 +44,5 @@ subdir('sh4') > subdir('sparc') > subdir('x86_64') > subdir('xtensa') > + > +specific_ss.add_all(when: 'CONFIG_LINUX_USER', if_true: linux_user_ss) > -- > 2.25.1 > > --000000000000dd938905d0ff6910 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Nov 17, 2021 at 9:04 AM Richa= rd Henderson <richard.he= nderson@linaro.org> wrote:
We have no need to reference linux_user_ss outside of lin= ux-user.
Go ahead and merge it directly into specific_ss.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
=C2=A0meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 3 ---
=C2=A0linux-user/meson.build | 4 ++++
=C2=A02 files changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Warner Losh <imp@bsdimp.com>

BTW, I don't think = I have anything meaningful to add to the discussions to date on this bug, a= nd I'm
agnostic as to the final decision...
=C2=A0<= /div>
diff --git a/meson.build b/meson.build
index 9f59c57909..ecc181ea13 100644
--- a/meson.build
+++ b/meson.build
@@ -2363,7 +2363,6 @@ common_user_ss =3D ss.source_set()
=C2=A0crypto_ss =3D ss.source_set()
=C2=A0hwcore_ss =3D ss.source_set()
=C2=A0io_ss =3D ss.source_set()
-linux_user_ss =3D ss.source_set()
=C2=A0qmp_ss =3D ss.source_set()
=C2=A0qom_ss =3D ss.source_set()
=C2=A0softmmu_ss =3D ss.source_set()
@@ -2614,8 +2613,6 @@ subdir('linux-user')

=C2=A0specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_use= r_ss)

-specific_ss.add_all(when: 'CONFIG_LINUX_USER', if_true: linux_user= _ss)
-
=C2=A0common_user_ss =3D common_user_ss.apply(config_all, strict: false) =C2=A0common_user =3D static_library('common-user',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sources: common_user_ss.sources(),
diff --git a/linux-user/meson.build b/linux-user/meson.build
index fcf7d40f23..b89534c49c 100644
--- a/linux-user/meson.build
+++ b/linux-user/meson.build
@@ -2,6 +2,8 @@ if not have_linux_user
=C2=A0 =C2=A0 subdir_done()
=C2=A0endif

+linux_user_ss =3D ss.source_set()
+
=C2=A0common_user_inc +=3D include_directories('host/' / config_hos= t['ARCH'])
=C2=A0common_user_inc +=3D include_directories('.')

@@ -42,3 +44,5 @@ subdir('sh4')
=C2=A0subdir('sparc')
=C2=A0subdir('x86_64')
=C2=A0subdir('xtensa')
+
+specific_ss.add_all(when: 'CONFIG_LINUX_USER', if_true: linux_user= _ss)
--
2.25.1

--000000000000dd938905d0ff6910--