From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64F93C04FEE for ; Wed, 20 Sep 2023 19:19:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qj2je-0007hf-1E; Wed, 20 Sep 2023 15:19:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qj2jc-0007gv-Np for qemu-devel@nongnu.org; Wed, 20 Sep 2023 15:19:40 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qj2jb-0002SQ-71 for qemu-devel@nongnu.org; Wed, 20 Sep 2023 15:19:40 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-501bd6f7d11so372163e87.1 for ; Wed, 20 Sep 2023 12:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1695237576; x=1695842376; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6ScSMQIvvFvUvNa0xFuJImGBIbtjHjm9BMs0Gk/lKro=; b=Rt6PvM5l3IUj+Mnl5akUJx6yAxSfU1W90HT5LrcfpFEI2GeU7UFjIZ1UztZc3MqjwQ 9DvDPu1GOw/IQWaODpozqwO5dOx7qJzIqF63PxCxbff2LkHxcDH0ihU1+AdQZMdhDzDZ VrkT338R9nWA3gCOVAOsfGXYz6SAW2s/ADSzeoPI6Ve+QdQsoK/ifxj72tebE45vBSbN z4IpmG4gcDDDs85AtbW5mKkYQIME1jnJHF+rq8l+D77BDLdVUB2N64s4WCLJKpcRo4s7 yqMzVN3uhPd9MQHByQNwdHhzC4XPKE8UnXPhmF3zxwY4Z3WyT90rAmv1HzJ08D5xoGUK v4hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695237576; x=1695842376; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6ScSMQIvvFvUvNa0xFuJImGBIbtjHjm9BMs0Gk/lKro=; b=F+I6BBr5sbc3oACvCih0hrHCWu2AYGnfB1mXUd5i7bVyELVugB1SvyYzFOBnRcSscz x/FOBCy1HV5xVOGqcj4ePJ4g1m31OuTYjQ3Lp3Kb1YSQrFl2s4cFwWoEoyjOlGEobc72 CjUVTVfyt+S2AcOOpozlSqDI/TI+LWvd7nWyec5zBEm/tVOddQiBZ4xar+8HRd4+JaVX ZXNW5PMHV0bIgiJUdHp2aoOdgd+xm1Q8SwZs1ppYb8x/vPphoxGgpwfmUt8ifkssH9Kb MXQ+0sCObZEECDd9SJLqHyOzM/ycMQkVgM8oEuduCDk9+ytZ6OBLIPfBRR7srpkJ++w1 Q8Nw== X-Gm-Message-State: AOJu0YyKHJy+UsPEiG1N+uZGJ4HDmmzu06So9p1YyCn2g/4yS3QGa3Y3 yX2UhkvbYofoPQ2Np7ImAnb81djOEUcnumLgzrxriq7G2Jr8KcDEHgvIZZgv X-Google-Smtp-Source: AGHT+IHaPFgyW3dQKg1a8xTjc1le+YCthUO5eq+7wtljKkQEn/GfZh7PcT37k6erLfh0c5QSJnYZDQHvt6xEyBi19P8= X-Received: by 2002:a05:6512:ea1:b0:500:95f7:c416 with SMTP id bi33-20020a0565120ea100b0050095f7c416mr3832485lfb.7.1695237576412; Wed, 20 Sep 2023 12:19:36 -0700 (PDT) MIME-Version: 1.0 References: <20230917213803.20683-1-kariem.taha2.7@gmail.com> <20230917213803.20683-27-kariem.taha2.7@gmail.com> In-Reply-To: <20230917213803.20683-27-kariem.taha2.7@gmail.com> From: Warner Losh Date: Wed, 20 Sep 2023 20:19:25 +0100 Message-ID: Subject: Re: [PATCH v2 26/28] bsd-user: Implement fork(2) and vfork(2) system calls. To: Karim Taha Cc: qemu-devel@nongnu.org, Richard Henderson , Stacey Son Content-Type: multipart/alternative; boundary="0000000000008d673b0605cf41f2" Received-SPF: none client-ip=2a00:1450:4864:20::12c; envelope-from=wlosh@bsdimp.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --0000000000008d673b0605cf41f2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 17, 2023 at 10:39=E2=80=AFPM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/os-proc.h | 34 ++++++++++++++++++++++++++++++++++ > bsd-user/freebsd/os-syscall.c | 8 ++++++++ > 2 files changed, 42 insertions(+) > Reviewed-by: Warner Losh Though i have minor qualms about vfork =3D=3D fork, for bsd-user it's fine since I don't think the performance difference will be that large for the typical case where vfork + exec exists for older (now kinda really old) programs that used to use this. Warner --0000000000008d673b0605cf41f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Sep 17, 2023 at 10:39=E2=80= =AFPM Karim Taha <kariem.tah= a2.7@gmail.com> wrote:
From: Stacey Son <sson@FreeBSD.org>

Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
=C2=A0bsd-user/freebsd/os-proc.h=C2=A0 =C2=A0 | 34 ++++++++++++++++++++++++= ++++++++++
=C2=A0bsd-user/freebsd/os-syscall.c |=C2=A0 8 ++++++++
=C2=A02 files changed, 42 insertions(+)

Reviewed-by: Warner Losh <imp@bsdimp.= com>

Though i have minor qualms about vfork= =3D=3D fork, for bsd-user it's fine since I
don't think = the performance difference will be that large for the typical case
where vfork=C2=A0+ exec exists for older (now kinda really old) programs = that used
to use this.

Warner
--0000000000008d673b0605cf41f2--