Re: [PATCH v1 01/11] configure: don't override the selected host test compiler if defined

[Warner Losh <imp@bsdimp.com>]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

On Fri, Sep 17, 2021 at 10:23 AM Alex Bennée <alex.bennee@linaro.org> wrote:

> There are not many cases you would want to do this but one is if you
> want to use a test friendly compiler like gcc instead of a system
> compiler like clang. Either way we should honour the users choice if
> they have made it.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Warner Losh <imp@bsdimp.com>
> ---
>  configure | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>

Reviewed-by: Warner Losh <imp@bsdimp.com>


> diff --git a/configure b/configure
> index 1043ccce4f..049c50a933 100755
> --- a/configure
> +++ b/configure
> @@ -1686,8 +1686,11 @@ case "$cpu" in
>      # No special flags required for other host CPUs
>  esac
>
> -eval "cross_cc_${cpu}=\$cc"
> -cross_cc_vars="$cross_cc_vars cross_cc_${cpu}"
> +if eval test -z "\${cross_cc_$cpu}"; then
> +    eval "cross_cc_${cpu}=\$cc"
> +    cross_cc_vars="$cross_cc_vars cross_cc_${cpu}"
> +fi
> +
>  QEMU_CFLAGS="$CPU_CFLAGS $QEMU_CFLAGS"
>
>  # For user-mode emulation the host arch has to be one we explicitly
> --
> 2.30.2
>
>

[-- Attachment #2: Type: text/html, Size: 1925 bytes --]