From: Warner Losh <imp@bsdimp.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2 01/24] target/avr: Remove pointless use of CONFIG_USER_ONLY definition
Date: Sun, 5 Sep 2021 08:24:44 -0600 [thread overview]
Message-ID: <CANCZdfoMw04ODcSaNHsWQGkAHF=_9xE8EMAFu3xe3PwxeFDUjw@mail.gmail.com> (raw)
In-Reply-To: <20210904235542.1092641-2-f4bug@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Sat, Sep 4, 2021 at 5:55 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> Commit f1c671f96cb ("target/avr: Introduce basic CPU class object")
> added to target/avr/cpu.h:
>
> #ifdef CONFIG_USER_ONLY
> #error "AVR 8-bit does not support user mode"
> #endif
>
> Remove the CONFIG_USER_ONLY definition introduced by mistake in
> commit 78271684719 ("cpu: tcg_ops: move to tcg-cpu-ops.h, keep a
> pointer in CPUClass").
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/avr/cpu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-By: Warner Losh <imp@bsdimp.com>
> diff --git a/target/avr/cpu.c b/target/avr/cpu.c
> index ea14175ca55..5d70e34dd54 100644
> --- a/target/avr/cpu.c
> +++ b/target/avr/cpu.c
> @@ -197,10 +197,7 @@ static const struct TCGCPUOps avr_tcg_ops = {
> .synchronize_from_tb = avr_cpu_synchronize_from_tb,
> .cpu_exec_interrupt = avr_cpu_exec_interrupt,
> .tlb_fill = avr_cpu_tlb_fill,
> -
> -#ifndef CONFIG_USER_ONLY
> .do_interrupt = avr_cpu_do_interrupt,
> -#endif /* !CONFIG_USER_ONLY */
> };
>
> static void avr_cpu_class_init(ObjectClass *oc, void *data)
> --
> 2.31.1
>
>
[-- Attachment #2: Type: text/html, Size: 2053 bytes --]
next prev parent reply other threads:[~2021-09-05 14:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 23:55 [PATCH v2 00/24] accel/tcg: Restrict TCGCPUOps::cpu_exec_interrupt() to sysemu Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 01/24] target/avr: Remove pointless use of CONFIG_USER_ONLY definition Philippe Mathieu-Daudé
2021-09-05 8:29 ` Richard Henderson
2021-09-05 14:24 ` Warner Losh [this message]
2021-09-04 23:55 ` [PATCH v2 02/24] target/i386: Restrict sysemu-only fpu_helper helpers Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 03/24] target/i386: Simplify TARGET_X86_64 #ifdef'ry Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 04/24] target/xtensa: Restrict do_transaction_failed() to sysemu Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 05/24] accel/tcg: Rename user-mode do_interrupt hack as fake_user_interrupt Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 06/24] target/alpha: Restrict cpu_exec_interrupt() handler to sysemu Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 07/24] target/arm: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 08/24] target/cris: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 09/24] target/hppa: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 10/24] target/i386: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 11/24] target/i386: Move x86_cpu_exec_interrupt() under sysemu/ folder Philippe Mathieu-Daudé
2021-09-05 8:35 ` Richard Henderson
2021-09-05 14:26 ` Warner Losh
2021-09-04 23:55 ` [PATCH v2 12/24] target/m68k: Restrict cpu_exec_interrupt() handler to sysemu Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 13/24] target/microblaze: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 14/24] target/mips: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 15/24] target/nios2: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 16/24] target/openrisc: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 17/24] target/ppc: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 18/24] target/riscv: " Philippe Mathieu-Daudé
2021-09-05 15:59 ` Bin Meng
2021-09-04 23:55 ` [PATCH v2 19/24] target/sh4: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 20/24] target/sparc: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 21/24] target/rx: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 22/24] target/xtensa: " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 23/24] accel/tcg: Restrict TCGCPUOps::cpu_exec_interrupt() " Philippe Mathieu-Daudé
2021-09-04 23:55 ` [PATCH v2 24/24] user: Remove cpu_get_pic_interrupt() stubs Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANCZdfoMw04ODcSaNHsWQGkAHF=_9xE8EMAFu3xe3PwxeFDUjw@mail.gmail.com' \
--to=imp@bsdimp.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).