From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46263C433EF for ; Sun, 5 Sep 2021 14:25:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA79F6103B for ; Sun, 5 Sep 2021 14:25:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA79F6103B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMt5X-00005c-V7 for qemu-devel@archiver.kernel.org; Sun, 05 Sep 2021 10:25:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMt4r-0007s5-K4 for qemu-devel@nongnu.org; Sun, 05 Sep 2021 10:24:57 -0400 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]:38791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMt4q-0002OV-6d for qemu-devel@nongnu.org; Sun, 05 Sep 2021 10:24:57 -0400 Received: by mail-ua1-x92d.google.com with SMTP id s4so2306935uar.5 for ; Sun, 05 Sep 2021 07:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iMki1WzaAxIJV+tuRfGlAaQ7qzuCZHF4lXSuNzk/JY4=; b=CKvvUlWHHZ/yZZPJGq9W/UKfosoGuHkpmCd+9atYPTE28r2o+fG+VAfZHsI0wlcJ5r O47jN0xj1JyEMQxRDZ9LJ40hG3rY9v0jnIToD/xmvnk2rrNcHxSSyISzumIy75Wan47K SsubXZqna3+YHjgl7oOdS47lM8TuPEiGsEWpAn5uhfnN7FSea7InYm4U7WH7jCSJv47f PAx1Zd/DcuxL1qgI8j+xvl9OTPyvOLt5gFDbC7QwcZiVJJVFFZFUbu/75nKMWgGIm3mv gMpDbQkNEhOmpjexXV7DodiYhGIVnSjg7JE26ff9Ng+PotoAsOA4dyJNAtINvASRyDoO 05pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iMki1WzaAxIJV+tuRfGlAaQ7qzuCZHF4lXSuNzk/JY4=; b=dBJimQ9NVaAcNHclNdgJsrnG36V9vsFH9atYYhi8wBCPMS86sg7oASsMfX0bXLHOkT Krcx1eAaokXfrie8k25/cXfITPW4sJ6vMyU0ZEOyiWXBjZOjIe7FKud4eBYhpCo6rhry KWbSCIZAQpL/DJoMRVlbbufD64XVI20/2x+Vf1HpOP9PuLDV8k+h8xFl4mSq/y6QQ0KT +gf00kaoRCjY5qda8NQ9rsozIovBT9ofvdJWXgDvFuRYu2MspwJ7G0mXRF1+Mq8Xi89U 43twZEqacT8gJSD0KqmF9ISB0UwXRLFsm2q5dDA4CRkyeLJDo7eT5nzQ6AH9dgKkjXEC jv1w== X-Gm-Message-State: AOAM531lg8ZMlEEKvaDtAeqAKDJgQ9zIzPVvHhQkt/1J+mcwFzzpXPzv vPtk/WQ/J8EVhq/y6SYH0o14dlhnv95cHYMgpUm/MVVQy0my9w== X-Google-Smtp-Source: ABdhPJxR0z7TlAd+ZtraRiLagXyNOFGm4SF6A5JqC/3BKqq1j4suVHcmQADpUVyAgKsMVQ/g2QHqXVvXCzqxfQCb2AM= X-Received: by 2002:a9f:2a87:: with SMTP id z7mr3579923uai.11.1630851895046; Sun, 05 Sep 2021 07:24:55 -0700 (PDT) MIME-Version: 1.0 References: <20210904235542.1092641-1-f4bug@amsat.org> <20210904235542.1092641-2-f4bug@amsat.org> In-Reply-To: <20210904235542.1092641-2-f4bug@amsat.org> From: Warner Losh Date: Sun, 5 Sep 2021 08:24:44 -0600 Message-ID: Subject: Re: [PATCH v2 01/24] target/avr: Remove pointless use of CONFIG_USER_ONLY definition To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000e2cc8005cb404bb3" Received-SPF: none client-ip=2607:f8b0:4864:20::92d; envelope-from=wlosh@bsdimp.com; helo=mail-ua1-x92d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000e2cc8005cb404bb3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 4, 2021 at 5:55 PM Philippe Mathieu-Daud=C3=A9 wrote: > Commit f1c671f96cb ("target/avr: Introduce basic CPU class object") > added to target/avr/cpu.h: > > #ifdef CONFIG_USER_ONLY > #error "AVR 8-bit does not support user mode" > #endif > > Remove the CONFIG_USER_ONLY definition introduced by mistake in > commit 78271684719 ("cpu: tcg_ops: move to tcg-cpu-ops.h, keep a > pointer in CPUClass"). > > Reported-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/avr/cpu.c | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-By: Warner Losh > diff --git a/target/avr/cpu.c b/target/avr/cpu.c > index ea14175ca55..5d70e34dd54 100644 > --- a/target/avr/cpu.c > +++ b/target/avr/cpu.c > @@ -197,10 +197,7 @@ static const struct TCGCPUOps avr_tcg_ops =3D { > .synchronize_from_tb =3D avr_cpu_synchronize_from_tb, > .cpu_exec_interrupt =3D avr_cpu_exec_interrupt, > .tlb_fill =3D avr_cpu_tlb_fill, > - > -#ifndef CONFIG_USER_ONLY > .do_interrupt =3D avr_cpu_do_interrupt, > -#endif /* !CONFIG_USER_ONLY */ > }; > > static void avr_cpu_class_init(ObjectClass *oc, void *data) > -- > 2.31.1 > > --000000000000e2cc8005cb404bb3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Sep 4, 2021 at 5:55 PM Philip= pe Mathieu-Daud=C3=A9 <f4bug@amsat.or= g> wrote:
Commit f1c671f96cb ("target/avr: Introduce basic CPU class object&quo= t;)
added to target/avr/cpu.h:

=C2=A0 #ifdef CONFIG_USER_ONLY
=C2=A0 #error "AVR 8-bit does not support user mode"
=C2=A0 #endif

Remove the CONFIG_USER_ONLY definition introduced by mistake in
commit 78271684719 ("cpu: tcg_ops: move to tcg-cpu-ops.h, keep a
pointer in CPUClass").

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
---
=C2=A0target/avr/cpu.c | 3 ---
=C2=A01 file changed, 3 deletions(-)

Reviewed-By: Warner Losh <imp@bsdim= p.com>

=C2=A0
diff --git a/target/avr/cpu.c b/target/avr/cpu.c
index ea14175ca55..5d70e34dd54 100644
--- a/target/avr/cpu.c
+++ b/target/avr/cpu.c
@@ -197,10 +197,7 @@ static const struct TCGCPUOps avr_tcg_ops =3D {
=C2=A0 =C2=A0 =C2=A0.synchronize_from_tb =3D avr_cpu_synchronize_from_tb, =C2=A0 =C2=A0 =C2=A0.cpu_exec_interrupt =3D avr_cpu_exec_interrupt,
=C2=A0 =C2=A0 =C2=A0.tlb_fill =3D avr_cpu_tlb_fill,
-
-#ifndef CONFIG_USER_ONLY
=C2=A0 =C2=A0 =C2=A0.do_interrupt =3D avr_cpu_do_interrupt,
-#endif /* !CONFIG_USER_ONLY */
=C2=A0};

=C2=A0static void avr_cpu_class_init(ObjectClass *oc, void *data)
--
2.31.1

--000000000000e2cc8005cb404bb3--