From: Warner Losh <imp@bsdimp.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Kyle Evans" <kevans@freebsd.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 6/6] gitlab-ci: Add FreeBSD jobs
Date: Wed, 12 May 2021 14:25:50 -0600 [thread overview]
Message-ID: <CANCZdfouF2RgQz55JDLEB8_aqKfc817f=a56Vj9VhEN=hrQMjw@mail.gmail.com> (raw)
In-Reply-To: <20210512053714.3268162-7-f4bug@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 3237 bytes --]
On Tue, May 11, 2021 at 11:37 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> Add system/user emulation jobs on FreeBSD host.
>
> To build these jobs, you need to add a FreeBSD runner and
> add 'freebsd' to the QEMU_CUSTOM_RUNNER variable in your
> GitLab project.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> .gitlab-ci.d/buildtest-freebsd.yml | 59 ++++++++++++++++++++++++++++++
> .gitlab-ci.d/qemu-project.yml | 1 +
> 2 files changed, 60 insertions(+)
> create mode 100644 .gitlab-ci.d/buildtest-freebsd.yml
>
This looks good to my eye, modulo the typo below. Fix that and it's
Reviewed by: Warner Losh <imp@bsdimp.com>
I can't wait to use it...
Warner
> diff --git a/.gitlab-ci.d/buildtest-freebsd.yml
> b/.gitlab-ci.d/buildtest-freebsd.yml
> new file mode 100644
> index 00000000000..683e815afbf
> --- /dev/null
> +++ b/.gitlab-ci.d/buildtest-freebsd.yml
> @@ -0,0 +1,59 @@
> +include:
> + - local: '/.gitlab-ci.d/buildtest-template.yml'
> +
> +.runner_freebsd_template:
> + rules:
> + # To enable thss job template, add 'freebsd' to the QEMU_CUSTOM_RUNNER
>
thss -> this
> + # variable in your project UI via Settings -> CI/CD -> Variables
> + #
> https://docs.gitlab.com/ee/ci/variables/README.html#project-cicd-variables
> + - if: $QEMU_CUSTOM_RUNNER =~ /freebsd/
> + when: always
> + - when: never
> + tags:
> + - freebsd
> +
> +build-user-freebsd:
> + extends:
> + - .runner_freebsd_template
> + - .native_build_job_template
> + image:
> + variables:
> + MAKE_CHECK_ARGS: check-build
> + CONFIGURE_ARGS: --disable-system --python=/usr/local/bin/python3.7
> +
> +build-system-freebsd:
> + extends:
> + - .runner_freebsd_template
> + - .native_build_job_template
> + image:
> + variables:
> + TARGETS: aarch64-softmmu avr-softmmu hppa-softmmu ppc64-softmmu
> + riscv64-softmmu s390x-softmmu x86_64-softmmu
> + MAKE_CHECK_ARGS: check-build
> + CONFIGURE_ARGS: --enable-trace-backends=log,simple,syslog
> + --python=/usr/local/bin/python3.7
> + artifacts:
> + expire_in: 2 days
> + paths:
> + - .git-submodule-status
> + - build
> +
> +check-system-freebsd:
> + extends:
> + - .runner_freebsd_template
> + - .native_test_job_template
> + needs:
> + - job: build-system-freebsd
> + artifacts: true
> + variables:
> + MAKE_CHECK_ARGS: check
> +
> +acceptance-system-freebsd:
> + extends:
> + - .runner_freebsd_template
> + - .integration_test_job_template
> + needs:
> + - job: build-system-freebsd
> + artifacts: true
> + variables:
> + MAKE_CHECK_ARGS: check-acceptance
> diff --git a/.gitlab-ci.d/qemu-project.yml b/.gitlab-ci.d/qemu-project.yml
> index 64cb2ba1da5..5dcf1d34c5b 100644
> --- a/.gitlab-ci.d/qemu-project.yml
> +++ b/.gitlab-ci.d/qemu-project.yml
> @@ -8,4 +8,5 @@ include:
> - local: '/.gitlab-ci.d/containers.yml'
> - local: '/.gitlab-ci.d/crossbuilds.yml'
> - local: '/.gitlab-ci.d/buildtest.yml'
> + - local: '/.gitlab-ci.d/buildtest-freebsd.yml'
> - local: '/.gitlab-ci.d/static_checks.yml'
> --
> 2.26.3
>
>
[-- Attachment #2: Type: text/html, Size: 4509 bytes --]
prev parent reply other threads:[~2021-05-12 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 5:37 [PATCH v2 0/6] gitlab-ci: Allow using FreeBSD runners Philippe Mathieu-Daudé
2021-05-12 5:37 ` [PATCH v2 1/6] gitlab-ci: Extract &environment_variables template Philippe Mathieu-Daudé
2021-05-12 5:37 ` [PATCH v2 2/6] gitlab-ci: Adapt JOBS variable for FreeBSD runners Philippe Mathieu-Daudé
2021-05-12 5:37 ` [PATCH v2 3/6] gitlab-ci: Run GNU make via the $MAKE variable Philippe Mathieu-Daudé
2021-05-12 5:37 ` [PATCH v2 4/6] gitlab-ci: Add ccache in $PATH and display statistics Philippe Mathieu-Daudé
2021-05-12 5:37 ` [PATCH v2 5/6] gitlab-ci: Simplify before/after script for Avocado based jobs Philippe Mathieu-Daudé
2021-05-12 5:37 ` [PATCH v2 6/6] gitlab-ci: Add FreeBSD jobs Philippe Mathieu-Daudé
2021-05-12 20:25 ` Warner Losh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANCZdfouF2RgQz55JDLEB8_aqKfc817f=a56Vj9VhEN=hrQMjw@mail.gmail.com' \
--to=imp@bsdimp.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).