From: Warner Losh <imp@bsdimp.com>
To: Karim Taha <kariem.taha2.7@gmail.com>
Cc: qemu-devel@nongnu.org, Stacey Son <sson@freebsd.org>
Subject: Re: [PATCH 12/22] Implement mmap(2) and munmap(2)
Date: Sat, 19 Aug 2023 22:27:28 -0600 [thread overview]
Message-ID: <CANCZdfp3rDTqk2Ztxd1J_CGQJEiJXFJunhC1vEFewDJZhJ7paQ@mail.gmail.com> (raw)
In-Reply-To: <20230819094806.14965-13-kariem.taha2.7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]
On Sat, Aug 19, 2023 at 3:49 AM Karim Taha <kariem.taha2.7@gmail.com> wrote:
> From: Stacey Son <sson@FreeBSD.org>
>
> Signed-off-by: Stacey Son <sson@FreeBSD.org>
> Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
> ---
> bsd-user/bsd-mem.h | 20 ++++++++++++++++++++
> bsd-user/freebsd/os-syscall.c | 9 +++++++++
> 2 files changed, 29 insertions(+)
>
Reviewed-by: Warner Losh <imp@bsdimp.com>
> diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h
> index fed7b7cd80..057c995a6e 100644
> --- a/bsd-user/bsd-mem.h
> +++ b/bsd-user/bsd-mem.h
> @@ -62,4 +62,24 @@ extern abi_ulong bsd_target_brk;
> extern abi_ulong bsd_target_original_brk;
> extern abi_ulong brk_page;
>
> +/* mmap(2) */
> +static inline abi_long do_bsd_mmap(void *cpu_env, abi_long arg1, abi_long
> arg2,
> + abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6, abi_long
> arg7,
> + abi_long arg8)
> +{
> + if (regpairs_aligned(cpu_env) != 0) {
> + arg6 = arg7;
> + arg7 = arg8;
> + }
> + return get_errno(target_mmap(arg1, arg2, arg3,
> + target_to_host_bitmask(arg4,
> mmap_flags_tbl),
> + arg5, target_arg64(arg6, arg7)));
> +}
> +
> +/* munmap(2) */
> +static inline abi_long do_bsd_munmap(abi_long arg1, abi_long arg2)
> +{
> + return get_errno(target_munmap(arg1, arg2));
> +}
> +
> #endif /* BSD_USER_BSD_MEM_H */
> diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
> index 7e2a395e0f..3525d39d7b 100644
> --- a/bsd-user/freebsd/os-syscall.c
> +++ b/bsd-user/freebsd/os-syscall.c
> @@ -486,6 +486,15 @@ static abi_long freebsd_syscall(void *cpu_env, int
> num, abi_long arg1,
> /*
> * Memory management system calls.
> */
> + case TARGET_FREEBSD_NR_mmap: /* mmap(2) */
> + ret = do_bsd_mmap(cpu_env, arg1, arg2, arg3, arg4, arg5, arg6,
> arg7,
> + arg8);
> + break;
> +
> + case TARGET_FREEBSD_NR_munmap: /* munmap(2) */
> + ret = do_bsd_munmap(arg1, arg2);
> + break;
> +
> #if defined(__FreeBSD_version) && __FreeBSD_version >= 1300048
> case TARGET_FREEBSD_NR_shm_open2: /* shm_open2(2) */
> ret = do_freebsd_shm_open2(arg1, arg2, arg3, arg4, arg5);
> --
> 2.40.0
>
>
[-- Attachment #2: Type: text/html, Size: 3193 bytes --]
next prev parent reply other threads:[~2023-08-20 4:27 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 9:47 [PATCH 00/22] Implement the mmap system call for FreeBSD Karim Taha
2023-08-19 9:47 ` [PATCH 01/22] Implement struct target_ipc_perm Karim Taha
2023-08-19 14:37 ` Richard Henderson
2023-08-20 4:07 ` Warner Losh
2023-08-19 9:47 ` [PATCH 02/22] Implement struct target_shmid_ds Karim Taha
2023-08-19 14:38 ` Richard Henderson
2023-08-20 4:08 ` Warner Losh
2023-08-19 9:47 ` [PATCH 03/22] Declarations for ipc_perm and shmid_ds conversion functions Karim Taha
2023-08-19 14:40 ` Richard Henderson
2023-08-20 4:08 ` Warner Losh
2023-08-19 9:47 ` [PATCH 04/22] Introduce freebsd/os-misc.h to the source tree Karim Taha
2023-08-19 14:40 ` Richard Henderson
2023-08-20 4:09 ` Warner Losh
2023-08-19 9:47 ` [PATCH 05/22] Implement shm_open2(2) system call Karim Taha
2023-08-19 15:10 ` Richard Henderson
2023-08-20 4:16 ` Warner Losh
2023-08-19 9:47 ` [PATCH 06/22] Implement shm_rename(2) " Karim Taha
2023-08-20 4:18 ` Warner Losh
2023-08-20 14:05 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 07/22] Add bsd-mem.c to meson.build Karim Taha
2023-08-20 4:19 ` Warner Losh
2023-08-20 14:06 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 08/22] Implement target_set_brk function in bsd-mem.c instead of os-syscall.c Karim Taha
2023-08-20 4:22 ` Warner Losh
2023-08-20 14:12 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 09/22] Implement ipc_perm conversion between host and target Karim Taha
2023-08-20 4:23 ` Warner Losh
2023-08-20 14:16 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 10/22] Implement shmid_ds " Karim Taha
2023-08-20 4:25 ` Warner Losh
2023-08-20 14:20 ` Richard Henderson
2023-09-03 8:45 ` Kariiem Taha
2023-09-05 1:43 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 11/22] Introduce bsd-mem.h to the source tree Karim Taha
2023-08-20 4:26 ` Warner Losh
2023-08-20 14:21 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 12/22] Implement mmap(2) and munmap(2) Karim Taha
2023-08-20 4:27 ` Warner Losh [this message]
2023-08-20 14:25 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 13/22] Implement mprotect(2) Karim Taha
2023-08-20 4:28 ` Warner Losh
2023-08-20 14:25 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 14/22] Implement msync(2) Karim Taha
2023-08-20 4:34 ` Warner Losh
2023-08-20 14:37 ` Richard Henderson
2023-08-19 9:47 ` [PATCH 15/22] Implement mlock(2), munlock(2), mlockall(2), munlockall(2), madvise(2), minherit(2) Karim Taha
2023-08-20 4:37 ` Warner Losh
2023-08-20 14:42 ` Richard Henderson
2023-08-20 14:43 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 16/22] Implement mincore(2) Karim Taha
2023-08-20 4:37 ` Warner Losh
2023-08-20 14:55 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 17/22] Implement do_obreak function Karim Taha
2023-08-20 4:40 ` Warner Losh
2023-08-20 15:03 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 18/22] Implement shm_open(2) Karim Taha
2023-08-20 4:42 ` Warner Losh
2023-08-20 15:04 ` Richard Henderson
2023-08-20 15:10 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 19/22] Implement shm_unlink(2) and shmget(2) Karim Taha
2023-08-20 4:42 ` Warner Losh
2023-08-20 15:05 ` Richard Henderson
2023-08-20 15:07 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 20/22] Implement shmctl(2) Karim Taha
2023-08-20 4:43 ` Warner Losh
2023-08-20 15:13 ` Richard Henderson
2023-09-09 1:59 ` Karim Taha
2023-09-09 17:51 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 21/22] Implement shmat(2) and shmdt(2) Karim Taha
2023-08-20 4:44 ` Warner Losh
2023-08-20 15:30 ` Richard Henderson
2023-08-22 18:03 ` Warner Losh
2023-08-22 18:11 ` Richard Henderson
2023-08-22 19:54 ` Warner Losh
2023-08-22 21:00 ` Richard Henderson
2023-08-19 9:48 ` [PATCH 22/22] Add stubs for vadvise(), sbrk() and sstk() Karim Taha
2023-08-20 4:45 ` Warner Losh
2023-08-20 15:35 ` Richard Henderson
2023-08-20 20:42 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANCZdfp3rDTqk2Ztxd1J_CGQJEiJXFJunhC1vEFewDJZhJ7paQ@mail.gmail.com \
--to=imp@bsdimp.com \
--cc=kariem.taha2.7@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sson@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).